Classify save failures as transient or terminal (`transient-error?` over the repo retryable types plus `:invalid-save-response`). Transient failures keep the head commit queued under a new `:retrying` status and resend it with backoff (2s/8s/20s, then terminal): stamp rotation reuses the same `:commit-id`, the in-flight guard prevents double-sends, and episode tokens silence stale timers. One tagged reconnect notice per episode (hidden on save and on terminal failure, silent recovery) plus a `:retrying` save-indicator state; the browser `online` event and new edits resume the episode. Terminal failures keep the exact `:error` path. Covers tasks 4, 6 and 7 with 31 persistence tests; updates the persistence memory. Relates to #11724 AI-assisted-by: muse-spark-1.3-contributor
7.8 KiB
Frontend Testing and Live Verification
Frontend validation: CLJS + React/Rumext + RxJS/Potok; SCSS modules; shared CLJC from common/.
Unit tests
READ mem:testing FIRST — it defines the execution discipline (no piping, tee to file, preferred commands) that applies to all CLJS/JS test runs.
Frontend unit tests live under frontend/test/frontend_tests/ and use cljs.test. They should be deterministic, avoid DOM/UI integration where possible, and mock side effects such as RPC, storage, timers, or network access.
Async-first stance
Frontend testing is async-first: everything essentially asynchronous is modeled with a test reproducing the asynchrony, even when the test could be written "synchronously". Sync-passing tests prove nothing about async behavior and rot as soon as an async boundary appears downstream. Consequences: mock through frontend-tests.helpers.mock, never with-redefs, except unit tests of purely synchronous functions; transport doubles deliver asynchronously (observe-on :async) while the test keeps scenario timing (explicit pushes); assertions always follow quiescence (wait-for on presence, bare settle tick for absence-only blocks), never a trigger.
Primitives
mock/with-mocks(callback style, legacy compat): installs withset!so mocks survive async boundaries; bodies run deferred past the current tick viaasap, so only done-chained (t/async) contexts are allowed;done'restores and completes exactly once (twice only warns; never calling it stalls the run and leaks the mocks). Prefermock/with-mocks*for new tests.mock/with-mocks*(direction): body forms wrapped in a generated^:asyncfn, evaluates to a promise —awaitit,awaitnested scopes too, nodonein test code. Rejections and non-promise returns report as:errorviarun-mocked.mock/stubwraps fns for arities 0-6 (the:esmtest build dispatches multi-arity vars ascljs$core$IFn$_invoke$arity$N); when the mocked var is variadic-defined (or called with more than 6 args), the call compiles to variadic dispatch, so use a plain variadicfn— the stub does not forward variadic. A mock must not call the mocked var again (self-delegation inside a multi-arity function recurses).- Helpers in
frontend-tests.helpers.async:->promise(single-value observable → promise; beicon has noto-promise),await-response(subscribe→push→await, atomic),settle,wait-for(immediate check + bounded poll, fails instead of hanging),observe(stream → termination promise; asserts provided, timeout rejects). - Fixtures return promises (
with-watchdog,with-persistence);awaitthem from^:asynctests.main_errorsandfontsare fully migrated (no legacywith-mocksleft). - Valid
^:asyncplacements:mem:clojure/idioms.
Observing event streams
To assert over emitted event sequences, observe termination: subscribe through observe (async delivery forced even for sync sources), await its promise, then assert the collected values. Never branch on nil (when-let skipping observation lets setup bugs pass as "empty"): producers answer refusals with empty streams, never nil, so every path subscribes uniformly. Observed termination is exact quiescence — no manual settle after it. Errors reject unless :on-error handles them.
Runner and library facts (verified: CLJS 1.12.145, beicon2 df7058a)
cljs.testkeeps its env in aset!var: assertions inside deferred ticks count.run-block: doubledoneonly warns; missingdonestalls.t/asyncdiscards the body promise — completion signals ONLY viadone.t/deftest ^:asyncadds auto async-context + autodone, but awaiting stays the author's job; without it the test passes empty.take 1is per-subscription on a hot subject: subscribe-before-push or hang.end!/.errorwith pending takes only forwards valueless completion.
Traps that bit
^:asynctests require map-style fixtures ((t/use-fixtures :each {:before f})): function-style fixtures abort the whole run ("Async tests require fixtures to be specified as maps").st/emit!doubles collect heterogeneous events: auditDataEvents deref, toast reify-objects do not — discriminate withptk/type(total, never throws), never blindderef.- Subscription order decides delivery order: never resolve settlement from a pre-subscribed branch racing the pipeline.
- Auto-answering mocks lose deadline expressiveness (can't time answers), need teardown timer-cancellation, and post-teardown deliveries hit real implementations — explicit pushes + async delivery +
wait-forwon on every axis. - Teardown belongs to the terminal continuation, never to
finally-around-triggers (it would dispose in-flight flows). - A body that awaits must be
(^:async fn …)even if the rest is sync; sync sequences are atomic vs the event loop.
From frontend/:
- Full unit test run (always builds, suppressed output):
pnpm run test:quiet. - Full unit test run (always builds, build output visible):
pnpm run test. - Focus a frontend CLJS test namespace:
pnpm run test:quiet -- --focus frontend-tests.logic.components-and-tokens. - Focus one frontend CLJS test var:
pnpm run test:quiet -- --focus frontend-tests.logic.components-and-tokens/change-spacing-token-in-main-updates-copy-layout. - Quiet
app.*logging during a run: append--log-level warn(ortrace|debug|info|warn|error). - Build test target only (no run):
pnpm run build:test. - After
build:testhas been run, run the compiled runner directly:node target/tests/test.js [--focus ...] [--log-level ...]. - Watch tests:
pnpm run watch:test.
New frontend test namespaces must be required/listed in frontend_tests/runner.cljs; new vars in existing namespaces need no runner change.
Playwright integration tests
Do not add, modify, or run Playwright integration tests under frontend/playwright unless explicitly asked. When explicitly asked, use pnpm run test:e2e or pnpm run test:e2e --grep "pattern" from frontend/; ensure dependencies are installed through ./scripts/setup if the environment is not prepared.
Integration tests fake backend behavior by intercepting network/websocket traffic, so every RPC or websocket the page needs must be mocked. Use existing Page Object Models:
BasePage.mockRPCintercepts RPC calls and already prefixes/api/rpc/command/; pass command names such asget-profile, not full URLs.- Workspace or other websocket-using pages should extend/use
BaseWebSocketPage, initialize websocket mocks before each test, and mock/ws/notificationswith the provided helpers. - Prefer common locators/actions in POMs; ad-hoc locators can stay in a single test.
Locator priority should follow user-facing semantics: getByRole, getByLabel, getByPlaceholder, getByText, then semantic alternatives such as alt/title, with getByTestId as the last resort. Name tests from the user's perspective and prefer positive, single-purpose assertions.
CI (E2E)
.github/workflows/tests-e2e.yml runs the integration specs, the composable component suite, and the mocked Plugin API suite from one workflow that builds the frontend bundle once per SHA. Before adding a job that needs the bundle, read mem:frontend/e2e-ci-workflow (build-once contract, cache key, stable check names).
Live browser verification
Because CLJC compiles to both JVM and CLJS, JVM/common tests can miss frontend-only state caused by browser runtime, WASM modifier math, or real pointer events. Use mem:frontend/cljs-repl to inspect live app state and mem:frontend/playwright-gestures when real input is needed.
For stale hot reload or failed CLJ/CLJC/CLJS source builds, read mem:frontend/compile-diagnostics. For Internal Error pages or delayed runtime crashes after automation/API actions, read mem:frontend/handling-crashes. Translation .po changes are bundled into index.html and require a browser refresh.