Filip Sajdak c40287254c
✨ Explain why a library cannot be disconnected in its modal (#12921)
* ✨ Explain why a library cannot be disconnected in its modal

A library that another connected library uses cannot be disconnected from
a file, but the Libraries modal showed it with the same disconnect button
as any other library, only disabled, and said nothing about why.

Replace that button with an icon and a tooltip. A nested library ("Connected
through ...") says it is inherited from its parent, and a direct library
that another connected library uses says which one. Both name the library
to disconnect first. A library nothing else uses keeps its button.

library-disconnect-hint decides the case from the same data the disabled
state used, so the buttons that were disabled are the ones that change.
The legacy libraries tab keeps its button.

Closes #12838

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 🐛 Name every library to disconnect in the disconnect hint

The hint named only the parent of a nested library as the one to
disconnect. That was wrong when several libraries use it (disconnecting
one leaves it linked through the others) and no help when the parent is
nested too and has no disconnect button either.

The removal step now lists the libraries the user can actually disconnect:
those that use the library directly or through others, and that no linked
library uses. The parent is still named as the reason it is inherited. In
a cycle nothing is removable, so the parent is named as before.

Tests cover a shared dependency, a deep chain and a cycle.

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 🐛 List directly linked libraries in the disconnect hint

A library linked to the file directly stays until the user disconnects
it, even when another linked library uses it. The hint skipped those: for
a file linked to A and B, with A using B and B using C, it told the user
to disconnect only A, and C stayed linked through B.

Collect the libraries that use it, however far up, and that are either
linked directly or used by no linked library. A directly linked library
that another one uses cannot be disconnected yet, and its own tooltip
says to disconnect that one first.

The test covers a directly linked intermediate library.

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 🐛 Count a library linked in this session as direct in the hint

Only the libraries fetched when the workspace opens carry :is-indirect.
One linked afterwards comes back without it, so the hint did not treat it
as directly linked: after connecting B (which uses C) and then A (which
uses B) without reloading, C's tooltip said to disconnect only A, and C
stayed linked through B.

A library the user linked has no flag and is direct by construction, so
only one known to be indirect is skipped.

The test covers that sequence.

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 🐛 Flag libraries linked in this session as direct or indirect

Only the libraries fetched when the workspace opens carried :is-indirect.
Linking a library afterwards loads it and its dependencies through
load-library-file, and none of them got the flag, so a missing flag could
mean either. The disconnect hint in the Libraries modal reads it to tell
which libraries the user can disconnect, and it listed the wrong ones for
a chain connected in the same session (it named a dependency that has no
disconnect button).

Set the flag where the library is loaded: the library the user links is
direct and the libraries it brings in are indirect. The hint is back to
trusting only a flag that says false, because a missing one no longer
means a direct link.

The test links a library with one dependency and checks both flags.

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 🐛 Keep a library's direct flag when it is loaded twice

When links overlap, a library can be requested twice: once because the
user linked it and once because a library linked right after brings it
in. Each load stored its own :is-indirect value, so whichever answer
landed last won, and an indirect one could erase the direct link. The
disconnect hint then listed the wrong libraries.

Store a loaded library through one event that never turns a known direct
link into an indirect one. The reverse order already ends direct, since
the user's link is stored with the flag false.

The test links a library and then one that uses it before the first
answer arrives, and answers in the order that used to lose the flag.

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 🐛 Scope a library's kept direct flag to the file it belongs to

The flag kept when a library is loaded twice was read from :files, which
outlives a workspace. A library that was a direct link of the file visited
before could keep that flag in the next file, where another library only
brings it in, and the disconnect hint then listed one library too many.

Keep the flag only when it was recorded for the file being loaded, using
the :library-of the entry already carries.

The test leaves a library flagged direct for another file and links a
library that brings it in.

AI-assisted-by: claude-opus-5-5
AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

* 💄 Name the libraries in the disconnect hint as design asked

The nested library hint now reads "Connected through <parent>. To
remove it, disconnect <libraries>." instead of "Inherited from ...".
The library names in both hints (connected through and used by) show
in the primary foreground color, so they stand out from the text.

The translation is split on its two placeholders instead of rendered
as HTML, because the library names are written by users. The full
plain sentence stays as the aria label of the icon.

The new key is workspace.libraries.connected-through-hint, since
workspace.libraries.connected-through already labels the parent in the
list.

AI-assisted-by: claude-sonnet-5-5
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>

---------

Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>
Co-authored-by: Eva Marco <evamarcod@gmail.com>
2026-11-20 09:49:28 +01:00
..
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-08 10:51:22 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-09 11:07:01 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2023-10-04 13:49:57 +02:00
2026-11-05 23:21:26 +01:00
2026-11-07 08:51:32 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-09 11:06:59 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00
2026-11-05 23:21:26 +01:00