* ♻️ Simplify storage GC delays and add skip-delay task params The touched GC no longer applies an extra deletion-delay when marking storage objects as deleted. By the time a storage object is touched, its referencing domain row has already passed its own deletion delay, and the reference scan is the only safety check needed. Touched objects are now marked with deleted_at = now, so the deleted GC removes them on the next run. For the tempfile bucket, upload chunks now set touched-at in the future (1h, aligned with the upload-session-gc TTL) instead of relying on a special-case deletion delay. Task handlers now read their task props: - storage-gc-touched accepts :skip-delay to process all touched objects immediately, bypassing the min-age threshold. - objects-gc accepts :chunk-size and :skip-delay to process recently deleted rows without waiting for the deletion delay. This allows running the deletion cascade immediately from the REPL via run-task! with the skip-delay option. AI-assisted-by: deepseek-v4-flash * ✨ Add storage object status lifecycle, verified dedup, and deletion retry tracking Storage object lifecycle hardening: - Add status column ('valid' | 'pending') as write-ahead marker for object creation. put-object! inserts in 'pending' state, writes blob, then promotes to 'valid'. Failed writes remove the pending row. - Add :storage-pending-gc task to reclaim orphaned pending rows (e.g. after crash between blob write and promotion). - Verify blob existence on every dedup hit via exists-object? (fs stat / s3 headObject). Missing blobs mark the row as deleted and create fresh object. - Add deletion_attempts column (migration 0154) to track physical blob deletion attempts. Restructure gc_deleted to use chunked processing with per-chunk transactions (short lock duration). Failed deletions are deferred to tomorrow (deleted_at = NOW() + 1 day) to prevent infinite loops. After 7 attempts, give up and accept orphan. - Change del-objects-in-bulk contract to return #{fail-ids} for precise per-id tracking (fs and s3 backends updated). - Use tmp/tempfile for fs atomic writes with cleanup queue registration (crashed-JVM temp files swept ~60min later). Document ATOMIC_MOVE POSIX-only assumption. - Add linear backoff to s3 exists-object? retries (100ms/200ms/300ms). - Wrap compensating delete in put-object! catch block to prevent masking original error when connection is aborted. - Fix assert messages in pending_gc.clj and gc_deleted.clj (pool assertion said 'expected valid storage' instead of 'db pool'). - Add pending-objects-excluded-from-gc-deleted test. Use unique path in put-object-write-failure-leaves-no-row test to avoid collisions. AI-assisted-by: qwen3.7-plus * 🐛 Fix review comments on gc-deleted and storage - Fix process-chunk! returning nil causing (+ acc nil) crash - Add FOR UPDATE SKIP LOCKED to sql:get-deleted-chunk to prevent infinite loop when another worker holds locks - Pass :cause to log messages in gc_deleted.clj and s3.clj - Fix extra space in log hint string - Remove unused ::blob-missing? reference from storage memory - Rename test to match actual behavior (leaves pending row) - Add test for gc-deleted giving up after max attempts AI-assisted-by: qwen3.7-plus
7.7 KiB
Backend Storage
Abstraction
app.storagestores binary objects.- Each object has a
storage_objectdatabase row. - The row stores the UUID, size, backend, timestamps, and Transit metadata.
- The backend stores the binary content.
- Supported backends are
:fsand:s3. - FS uses one root directory and a UUID-derived path.
- S3 uses one configured bucket and an optional prefix.
- A Penpot bucket is metadata. It is not an S3 bucket or a filesystem directory.
- FS and S3 use the same UUID-derived object path. The bucket does not change the path.
PENPOT_OBJECTS_STORAGE_*configures the current object backend.- Deprecated asset-storage config keys remain supported for migration.
- Database rows keep the backend name. Keep the legacy
:assets-fsand:assets-s3aliases.
Object Lifecycle
put-object!creates the database row before it writes backend content.- Backend content is written only when the row is new.
- A failed backend write can leave an unreferenced database row.
- Callers often set
:touched-atso garbage collection can remove such rows. get-objectexcludes rows withdeleted_at.- Existing object values can remain readable until physical deletion.
:expired-atblocks reads after the expiration time.del-object!setsdeleted_at. It does not remove backend content.storage-gc-deletedremoves the database row and backend content after the deletion delay.storage-gc-touchedfinds references before it setsdeleted_at.objects-gcremoves deleted domain rows and touches their storage object IDs.- Use
::db/reuse-conn truewithsto/resolveinside a database transaction.
Connection Reuse Details
app.storage/resolve patterns:
1. Pool mode (default) - (sto/resolve cfg)
- Returns storage abstraction from config
- Uses whatever database pool is available
- Safe to call outside transaction context
- Used in:
rpc/commands/media.clj:363,rpc/commands/auth.clj:327,rpc/commands/profile.clj:362
2. Connection reuse mode - (sto/resolve cfg ::db/reuse-conn true)
- Internally calls
db/get-connection cfgto obtain connectable - Configures storage with the specific connection from config
- Must be paired with transaction that owns this connection
- Used in:
features/fdata.clj:100,rpc/commands/media.clj:425,rpc/commands/files_thumbnails.clj:307,319,binfile/v3.clj:722
3. Explicit configuration - (sto/configure storage conn)
- Sets
::db/connon storage map directly - Asserts
db/conn? connection(storage.clj:349) - Used inside
db/tx-run!blocks whereconnis already available - Used in:
tasks/file_gc.clj:256,rpc/commands/files_thumbnails.clj:347,371
Key Warning (from function notes):
The improved note in import-storage-objects and handle-persistence warns:
Do not reuse the main database connection for storage operations within a transaction. The storage upload process can fail mid-operation, leaving orphaned objects on the backend. If the outer transaction aborts, pending storage objects become unreconciliable because the storage subsystem registers its pending state in separate transactions.
Rule of Thumb for sto/put-object!:
Since put-object! uses backend-specific operations (impl/resolve-backend + impl/put-object) and does not directly use ::db/conn or ::db/pool, all usage of put-object! will never run inside a common transaction (if configured at all). The storage backend operations are independent of the database transaction boundary.
Deduplication
- Deduplication requires
::sto/deduplicate?, a content hash, and bucket metadata. - The lookup matches hash, bucket, backend, and
deleted_at IS NULL. - The lookup only considers rows with
status='valid'; pending rows are invisible. - A hit whose blob is missing is repaired in place: the same row/id is kept,
and
put-object!rewrites the blob under that id. This heals all existing references to the object. If the rewrite fails, the row is left live and valid for a later retry. - The lookup does not include file ID, profile ID, team ID, or organization ID.
- Objects can therefore share content across users and files within one bucket.
- Deleted objects are not reused.
tempfileobjects never use deduplication, even when the caller requests it.- Use
sto/wrap-with-hashwhen the caller already calculated the content hash.
Bucket Rules
| Bucket | Content and references | Dedup | Direct /assets/by-id access |
Cleanup |
|---|---|---|---|---|
file-media-object |
Original file images and generated media thumbnails. References: file_media_object.media_id and thumbnail_id. |
Yes | Public | Reference scan. |
team-font-variant |
Font variants in team_font_variant. References: woff1_file_id, woff2_file_id, otf_file_id, and ttf_file_id. |
Yes | Public | Reference scan. |
file-object-thumbnail |
Frame and component thumbnails in file_tagged_object_thumbnail.media_id. |
Yes | Public | Reference scan. |
file-thumbnail |
File grid thumbnails in file_thumbnail.media_id. |
Yes | Authentication required | Reference scan. |
profile |
User and team profile photos. References: profile.photo_id and team.photo_id. |
Yes | Authentication required | Reference scan. |
organization |
Organization logos uploaded by the Nitrate management API. | Yes | Public | No reference scan. A touched object is deleted. |
tempfile |
Export files, chunked-upload chunks, and temporary font downloads. | No | Authentication required | No reference scan. A touched object uses a two-hour deletion delay. |
file-data |
Encoded file data when file-data-backend is storage. Reference metadata has storage-ref-id, file-id, and the file_data row ID. |
Yes | Authentication required | Reference scan. |
file-data-fragment |
Compatibility value for file-data fragments. The current backend has no dedicated producer for this bucket. | No current write semantics | Public | No touched-object collector case. |
file-change |
Compatibility value for file changes. Current snapshots store data in file_data, not this bucket. |
No current write semantics | Authentication required | No touched-object collector case. |
- The valid bucket set lives in
app.storage/valid-buckets. file-media-objectis the default bucket for old rows without bucket metadata.- Do not assign a new bucket without adding its access and cleanup behavior.
- The touched-object collector raises an internal error for an unknown bucket.
- It supports
file-media-object,team-font-variant,file-object-thumbnail,file-thumbnail,profile,file-data,tempfile, andorganization. - It does not support
file-data-fragmentorfile-change.
Access Rules
app.http.assetsdecides direct object authentication from the bucket.- Public buckets are
file-media-object,file-object-thumbnail,team-font-variant,file-data-fragment, andorganization. - Other valid buckets require a session or access-token profile ID.
- File-media routes also require file read permission.
- Non-public direct responses set
content-disposition: attachment. - FS responses use
x-accel-redirectfor the configured asset path. - S3 responses use a presigned URL and an HTTP redirect.
File Data
file-data-backendacceptslegacy-db,db, orstorage.legacy-dbstores main data infile.dataand snapshots infile_change.data.dbstores encoded data infile_data.data.storagestores encoded data in storage subsystem withfile-databucket and keepsdatanil infile_datatable.- The
file_data.metadata.storage-ref-idvalue points to the storage object. fdata/upsert!touches a storage object from incoming metadata before it stores the new row.- File snapshots use
file_datafor snapshot data andfile_changefor snapshot metadata.