github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-04-25 11:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix nested frames border clipping

Browse Source
This commit is contained in:
Alejandro Alonso 2026-01-14 07:10:26 +01:00
parent d593e299e3
commit c60d74df62
3 changed files with 1990 additions and 1078 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3057
frontend/playwright/data/render-wasm/get-file-frame-nested-clipping.json
View File

File diff suppressed because it is too large Load Diff

BIN
frontend/playwright/ui/render-wasm-specs/shapes.spec.js-snapshots/Renders-a-file-with-nested-clipping-frames-1.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 23 KiB

After

Width:  |  Height:  |  Size: 25 KiB

11
render-wasm/src/render.rs
View File

@ -1212,7 +1212,12 @@ impl RenderState {
}
#[inline]
pub fn render_shape_exit(&mut self, element: &Shape, visited_mask: bool) {
pub fn render_shape_exit(
&mut self,
element: &Shape,
visited_mask: bool,
clip_bounds: Option<ClipStack>,
) {
if visited_mask {
// Because masked groups needs two rendering passes (first drawing
// the content and then drawing the mask), we need to do an
@ -1268,7 +1273,7 @@ impl RenderState {
element_strokes.to_mut().clip_content = false;
self.render_shape(
&element_strokes,
None,
clip_bounds,
SurfaceId::Fills,
SurfaceId::Strokes,
SurfaceId::InnerShadows,
@ -1528,7 +1533,7 @@ impl RenderState {
if visited_children {
// Skip render_shape_exit for flattened containers
if !element.can_flatten() {
self.render_shape_exit(element, visited_mask);
self.render_shape_exit(element, visited_mask, clip_bounds);
}
continue;
}