github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-09-09 05:28:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix typo in icon name elipse to ellipse (#9948)

Browse Source 
Rename the icon file and fix the icon ID from "elipse" (single "l")
to "ellipse" (double "l") across the codebase.

The root cause was a mismatch: the icon file/ID was named "elipse"
but get-shape-icon returns "ellipse" for circle shapes. Since the
icon* component validates icon-id against the auto-generated
icon-list set, the string "ellipse" failed validation.

Changes:
- Rename frontend/resources/images/icons/elipse.svg to ellipse.svg
- Fix icon def in icon.cljs: ^:icon-id elipse -> ^:icon-id ellipse
- Fix deprecated icon in icons.cljs: ^:icon elipse -> ^:icon ellipse
- Fix usage in top_toolbar.cljs: deprecated-icon/elipse -> ellipse
- Fix usage in history.cljs: deprecated-icon/elipse -> ellipse

Signed-off-by: Andrey Antukh <niwi@niwi.nz>
This commit is contained in:
Andrey Antukh 2026-06-01 12:49:24 +02:00 committed by GitHub
parent a9e88b8fa8
commit 9e12e413ca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
frontend/resources/images/icons/elipse.svg → frontend/resources/images/icons/ellipse.svg
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 166 B

After

Width:  |  Height:  |  Size: 166 B

2
frontend/src/app/main/ui/ds/foundations/assets/icon.cljs
View File

@ -133,7 +133,7 @@
(def ^:icon-id easing-ease-out "easing-ease-out") (def ^:icon-id easing-ease-out "easing-ease-out")
(def ^:icon-id easing-linear "easing-linear") (def ^:icon-id easing-linear "easing-linear")
(def ^:icon-id effects "effects") (def ^:icon-id effects "effects")
(def ^:icon-id elipse "elipse") (def ^:icon-id ellipse "ellipse")
(def ^:icon-id exit "exit") (def ^:icon-id exit "exit")
(def ^:icon-id expand "expand") (def ^:icon-id expand "expand")
(def ^:icon-id external-link "external-link") (def ^:icon-id external-link "external-link")

2
frontend/src/app/main/ui/icons.cljs
View File

@ -114,7 +114,7 @@
(def ^:icon easing-ease (icon-xref :easing-ease)) (def ^:icon easing-ease (icon-xref :easing-ease))
(def ^:icon easing-linear (icon-xref :easing-linear)) (def ^:icon easing-linear (icon-xref :easing-linear))
(def ^:icon effects (icon-xref :effects)) (def ^:icon effects (icon-xref :effects))
(def ^:icon elipse (icon-xref :elipse)) (def ^:icon ellipse (icon-xref :ellipse))
(def ^:icon exit (icon-xref :exit)) (def ^:icon exit (icon-xref :exit))
(def ^:icon expand (icon-xref :expand)) (def ^:icon expand (icon-xref :expand))
(def ^:icon external-link (icon-xref :external-link)) (def ^:icon external-link (icon-xref :external-link))

2
frontend/src/app/main/ui/workspace/sidebar/history.cljs
View File

@ -154,7 +154,7 @@
:page deprecated-icon/document :page deprecated-icon/document
:shape deprecated-icon/svg :shape deprecated-icon/svg
:rect deprecated-icon/rectangle :rect deprecated-icon/rectangle
:circle deprecated-icon/elipse :circle deprecated-icon/ellipse
:text deprecated-icon/text :text deprecated-icon/text
:path deprecated-icon/path :path deprecated-icon/path
:frame deprecated-icon/board :frame deprecated-icon/board

2
frontend/src/app/main/ui/workspace/top_toolbar.cljs
View File

@ -170,7 +170,7 @@
:on-click select-drawtool :on-click select-drawtool
:data-tool "circle" :data-tool "circle"
:data-testid "ellipse-btn"} :data-testid "ellipse-btn"}
deprecated-icon/elipse]] deprecated-icon/ellipse]]
[:li [:li
[:button [:button
{:title (tr "workspace.toolbar.text" (sc/get-tooltip :draw-text)) {:title (tr "workspace.toolbar.text" (sc/get-tooltip :draw-text))