From 9e12e413ca3701b5492760848e0c07d5fa401999 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Mon, 1 Jun 2026 12:49:24 +0200 Subject: [PATCH] :bug: Fix typo in icon name elipse to ellipse (#9948) Rename the icon file and fix the icon ID from "elipse" (single "l") to "ellipse" (double "l") across the codebase. The root cause was a mismatch: the icon file/ID was named "elipse" but get-shape-icon returns "ellipse" for circle shapes. Since the icon* component validates icon-id against the auto-generated icon-list set, the string "ellipse" failed validation. Changes: - Rename frontend/resources/images/icons/elipse.svg to ellipse.svg - Fix icon def in icon.cljs: ^:icon-id elipse -> ^:icon-id ellipse - Fix deprecated icon in icons.cljs: ^:icon elipse -> ^:icon ellipse - Fix usage in top_toolbar.cljs: deprecated-icon/elipse -> ellipse - Fix usage in history.cljs: deprecated-icon/elipse -> ellipse Signed-off-by: Andrey Antukh --- frontend/resources/images/icons/{elipse.svg => ellipse.svg} | 0 frontend/src/app/main/ui/ds/foundations/assets/icon.cljs | 2 +- frontend/src/app/main/ui/icons.cljs | 2 +- frontend/src/app/main/ui/workspace/sidebar/history.cljs | 2 +- frontend/src/app/main/ui/workspace/top_toolbar.cljs | 2 +- 5 files changed, 4 insertions(+), 4 deletions(-) rename frontend/resources/images/icons/{elipse.svg => ellipse.svg} (100%) diff --git a/frontend/resources/images/icons/elipse.svg b/frontend/resources/images/icons/ellipse.svg similarity index 100% rename from frontend/resources/images/icons/elipse.svg rename to frontend/resources/images/icons/ellipse.svg diff --git a/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs b/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs index 35da1fc550..e766ff9247 100644 --- a/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs +++ b/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs @@ -133,7 +133,7 @@ (def ^:icon-id easing-ease-out "easing-ease-out") (def ^:icon-id easing-linear "easing-linear") (def ^:icon-id effects "effects") -(def ^:icon-id elipse "elipse") +(def ^:icon-id ellipse "ellipse") (def ^:icon-id exit "exit") (def ^:icon-id expand "expand") (def ^:icon-id external-link "external-link") diff --git a/frontend/src/app/main/ui/icons.cljs b/frontend/src/app/main/ui/icons.cljs index 1cc3569881..d4d1c18956 100644 --- a/frontend/src/app/main/ui/icons.cljs +++ b/frontend/src/app/main/ui/icons.cljs @@ -114,7 +114,7 @@ (def ^:icon easing-ease (icon-xref :easing-ease)) (def ^:icon easing-linear (icon-xref :easing-linear)) (def ^:icon effects (icon-xref :effects)) -(def ^:icon elipse (icon-xref :elipse)) +(def ^:icon ellipse (icon-xref :ellipse)) (def ^:icon exit (icon-xref :exit)) (def ^:icon expand (icon-xref :expand)) (def ^:icon external-link (icon-xref :external-link)) diff --git a/frontend/src/app/main/ui/workspace/sidebar/history.cljs b/frontend/src/app/main/ui/workspace/sidebar/history.cljs index 31972b2868..1ba10dd837 100644 --- a/frontend/src/app/main/ui/workspace/sidebar/history.cljs +++ b/frontend/src/app/main/ui/workspace/sidebar/history.cljs @@ -154,7 +154,7 @@ :page deprecated-icon/document :shape deprecated-icon/svg :rect deprecated-icon/rectangle - :circle deprecated-icon/elipse + :circle deprecated-icon/ellipse :text deprecated-icon/text :path deprecated-icon/path :frame deprecated-icon/board diff --git a/frontend/src/app/main/ui/workspace/top_toolbar.cljs b/frontend/src/app/main/ui/workspace/top_toolbar.cljs index 2df664ec9a..16db2d86cf 100644 --- a/frontend/src/app/main/ui/workspace/top_toolbar.cljs +++ b/frontend/src/app/main/ui/workspace/top_toolbar.cljs @@ -170,7 +170,7 @@ :on-click select-drawtool :data-tool "circle" :data-testid "ellipse-btn"} - deprecated-icon/elipse]] + deprecated-icon/ellipse]] [:li [:button {:title (tr "workspace.toolbar.text" (sc/get-tooltip :draw-text))