mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-09-18 18:46:17 +00:00
A cron task could become permanently unschedulable after a run that failed
fast. Reproduced against the real SQL adapters, and against the legacy path
for contrast -- the legacy code does not have this bug, so the hexagonal
slice introduced it.
The window
----------
`dispatch_task` already documents it: "a fast-failing run can reach
handle_run_completion before this write lands". The hook therefore reads the
task while the dispatch path has not yet written its bookkeeping, and the
snapshot it holds still carries the elapsed `next_run_at` the claim was made
on. `handle_run_completion` then wrote that whole snapshot back through
`save()`, so whichever landed second undid the other.
For a cron task the result is terminal in the worst way. `record_launch`
writes the fresh fire time, bumps `run_count` and clears the claim; the
completion's whole-aggregate write restores the elapsed fire time, rolls
`run_count` back and leaves `status='running'` with `lease_expires_at IS
NULL`. Neither `claim_due` branch matches that shape (one needs `enabled`,
the other needs an expired claim), and `cancel_stuck_once_tasks` only sweeps
`once` rows -- so nothing can ever reach the task again.
The legacy `app/scheduler/service.py` wrote the same outcome field by field
(`update(..., updates={"last_error": ...})`) and never touched scheduling
state, which is why it survives the same interleaving.
The fix
-------
`record_completion` joins `record_launch` as a second deliberately narrow
port method, for the same stated reason `record_launch` is not expressed as
`save(task)`: the two race, so neither may write through the aggregate. They
now own disjoint fields -- the launch owns the schedule, the completion owns
the verdict (terminal status plus `last_error`, with `None` meaning "do not
move the status", i.e. every cron task).
`save()` keeps its documented purpose, the user-initiated whole-aggregate
updates (`update_task` / `pause` / `resume`). `handle_run_completion` still
reads the task first, but only to ask `status_after_completion`, which reads
nothing but the schedule type -- immutable, so that read carries no
time-of-check risk.
Tests
-----
The contract suite missed this because it groups cases by port method:
`record_launch` appears only among its own, never interleaved with `save`,
and `test_protect_terminal_keeps_a_concurrently_finalized_verdict` pins the
mirror-image direction only. The in-memory double replaces the whole row too,
so both implementations were faithfully wrong -- the defect was in the
contract, not either adapter.
Added: `TestRecordCompletion` (5 cases, both implementations), including the
interleaving itself; and `test_a_cron_task_survives_a_launch_write_landing_mid_completion`,
which drives a real `ScheduleService` over a repo double that commits
`record_launch` between the hook's read and its write. Both were watched
failing first -- the service case failing with the actual symptom, a rolled
back `next_run_at`, not a missing method.
Verified end to end against file-backed sqlite with the real service: the
task keeps `enabled`, the concurrent fire time and run count survive, the
verdict is recorded, and the next poll still claims it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
489 lines
20 KiB
Python
489 lines
20 KiB
Python
"""Application service of the schedule context (its input port).
|
|
|
|
Orchestrates use cases only: fetch, apply domain rules, persist through output
|
|
ports. It holds no business rules itself -- every decision below is delegated
|
|
to the aggregate -- and knows nothing about HTTP, SQL, or the run runtime.
|
|
`user_id` is always passed in explicitly; resolving the current user is the
|
|
primary adapter's job.
|
|
|
|
The dispatch path deliberately mirrors the structure of the pre-migration
|
|
`app/scheduler/service.py`, including its ordering and its comments, because
|
|
its concurrency and idempotency semantics are load-bearing and are pinned by
|
|
tests that must keep passing unchanged.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from dataclasses import dataclass, replace
|
|
from datetime import datetime
|
|
|
|
from deerflow.domain.schedule.model import (
|
|
ActiveRunConflictError,
|
|
ContextMode,
|
|
DispatchOutcome,
|
|
LaunchFailedError,
|
|
RunStatus,
|
|
ScheduledRun,
|
|
ScheduledTask,
|
|
SchedulePolicy,
|
|
ScheduleSpec,
|
|
ScheduleType,
|
|
TaskNotFoundError,
|
|
ThreadBusyError,
|
|
ThreadNotFoundError,
|
|
TriggerKind,
|
|
)
|
|
from deerflow.domain.schedule.ports import (
|
|
RunLauncher,
|
|
RunOutcome,
|
|
ScheduledRunRepository,
|
|
ScheduledTaskRepository,
|
|
ThreadLookup,
|
|
)
|
|
|
|
# Shared so the has_active fast path and the active-slot race path produce
|
|
# byte-identical outcomes for the same "task already has an active run"
|
|
# condition. Two callers must not be able to tell which one rejected them.
|
|
_ACTIVE_RUN_CONFLICT_ERROR = "task already has an active run"
|
|
_SKIP_ACTIVE_RUN_ERROR = "skipped: a previous run of this task is still active"
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ContextChange:
|
|
"""A requested change of execution context.
|
|
|
|
The mode and the thread always move together -- `with_context` takes
|
|
both, and clearing the thread is what switching to a fresh-thread mode
|
|
means. Packaging them removes the one place where `None` was ambiguous
|
|
("unbind the thread" versus "leave it alone") and lets every other
|
|
update field use plain `None` for "not supplied".
|
|
"""
|
|
|
|
context_mode: str | ContextMode
|
|
thread_id: str | None = None
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class DispatchResult:
|
|
"""What one dispatch attempt produced.
|
|
|
|
`outcome` drives the caller's protocol mapping -- a manual trigger turns
|
|
CONFLICT into 409 and FAILED into 502 -- so it is domain vocabulary
|
|
rather than a bare string.
|
|
"""
|
|
|
|
outcome: DispatchOutcome
|
|
record_id: str | None
|
|
run_id: str | None
|
|
thread_id: str
|
|
error: str | None
|
|
|
|
|
|
class ScheduleService:
|
|
"""Every scheduled-task use case, orchestrated over the four output ports.
|
|
|
|
The input port of this context: primary adapters (an HTTP router, the
|
|
poller, the run-completion hook) call these methods and translate what
|
|
comes back. Domain errors are allowed to propagate -- mapping them onto a
|
|
protocol is the adapter's job, not this class's.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
*,
|
|
tasks: ScheduledTaskRepository,
|
|
runs: ScheduledRunRepository,
|
|
launcher: RunLauncher,
|
|
threads: ThreadLookup,
|
|
policy: SchedulePolicy,
|
|
) -> None:
|
|
self._tasks = tasks
|
|
self._runs = runs
|
|
self._launcher = launcher
|
|
self._threads = threads
|
|
self._policy = policy
|
|
|
|
# ------------------------------------------------------------------ reads
|
|
|
|
async def list_tasks(self, user_id: str) -> list[ScheduledTask]:
|
|
"""Every task the user owns, newest first."""
|
|
return await self._tasks.list_by_user(user_id)
|
|
|
|
async def list_tasks_by_thread(self, user_id: str, thread_id: str) -> list[ScheduledTask]:
|
|
"""The user's tasks bound to one thread.
|
|
|
|
Only reuse_thread tasks can appear: a fresh-thread task carries no
|
|
binding to show.
|
|
"""
|
|
return await self._tasks.list_by_user_and_thread(user_id, thread_id)
|
|
|
|
async def get_task(self, task_id: str, *, user_id: str) -> ScheduledTask:
|
|
"""Raises TaskNotFoundError when absent or owned by someone else -- the
|
|
caller must not be able to tell those apart."""
|
|
task = await self._tasks.get(task_id, user_id=user_id)
|
|
if task is None:
|
|
raise TaskNotFoundError("Scheduled task not found")
|
|
return task
|
|
|
|
async def list_task_runs(self, task_id: str, *, user_id: str, limit: int = 50, offset: int = 0) -> list[ScheduledRun]:
|
|
"""Execution history, gated on ownership of the parent task."""
|
|
await self.get_task(task_id, user_id=user_id)
|
|
return await self._runs.list_by_task(task_id, limit=limit, offset=offset)
|
|
|
|
# ------------------------------------------------------------------ writes
|
|
|
|
async def create_task(
|
|
self,
|
|
*,
|
|
user_id: str,
|
|
title: str,
|
|
prompt: str,
|
|
schedule: ScheduleSpec,
|
|
context_mode: str | ContextMode,
|
|
thread_id: str | None,
|
|
now: datetime,
|
|
) -> ScheduledTask:
|
|
"""Register a new standing instruction.
|
|
|
|
The aggregate is built first so a malformed schedule or context mode is
|
|
reported as such before any IO happens; only then is the thread
|
|
binding verified.
|
|
|
|
Raises:
|
|
InvalidScheduleError / InvalidContextModeError: from the aggregate.
|
|
ThreadNotFoundError: reuse_thread pointing at a thread the user
|
|
cannot use.
|
|
"""
|
|
task = ScheduledTask.create(
|
|
user_id=user_id,
|
|
title=title,
|
|
prompt=prompt,
|
|
schedule=schedule,
|
|
context_mode=context_mode,
|
|
thread_id=thread_id,
|
|
now=now,
|
|
policy=self._policy,
|
|
)
|
|
await self._require_thread(task)
|
|
return await self._tasks.add(task)
|
|
|
|
async def update_task(
|
|
self,
|
|
task_id: str,
|
|
*,
|
|
user_id: str,
|
|
now: datetime,
|
|
title: str | None = None,
|
|
prompt: str | None = None,
|
|
schedule: ScheduleSpec | None = None,
|
|
context: ContextChange | None = None,
|
|
) -> ScheduledTask:
|
|
"""Partially update a task; `None` means "not supplied".
|
|
|
|
No sentinel is needed because nothing here has `None` as a meaningful
|
|
value -- the one field that does, `thread_id`, travels inside
|
|
`ContextChange` where it is unambiguous.
|
|
|
|
Context and schedule are applied through the aggregate's own
|
|
transitions, so the re-arm rule and the running-task gate cannot be
|
|
bypassed by patching fields directly.
|
|
"""
|
|
task = await self.get_task(task_id, user_id=user_id)
|
|
task.ensure_mutable()
|
|
|
|
if context is not None:
|
|
task = task.with_context(context.context_mode, context.thread_id)
|
|
await self._require_thread(task)
|
|
if schedule is not None:
|
|
task = task.with_schedule(schedule, now=now, policy=self._policy)
|
|
if title is not None:
|
|
task = replace(task, title=title)
|
|
if prompt is not None:
|
|
task = replace(task, prompt=prompt)
|
|
|
|
return await self._save(task)
|
|
|
|
async def pause_task(self, task_id: str, *, user_id: str) -> ScheduledTask:
|
|
"""Stop claiming this task until it is resumed.
|
|
|
|
Refused while the task is being dispatched -- see `ensure_mutable`.
|
|
"""
|
|
task = await self.get_task(task_id, user_id=user_id)
|
|
return await self._save(task.paused())
|
|
|
|
async def resume_task(self, task_id: str, *, user_id: str) -> ScheduledTask:
|
|
"""Re-admit this task to claiming. Same gate as `pause_task`."""
|
|
task = await self.get_task(task_id, user_id=user_id)
|
|
return await self._save(task.resumed())
|
|
|
|
async def delete_task(self, task_id: str, *, user_id: str) -> None:
|
|
"""Deleting is deliberately not gated on the task being idle: the
|
|
pre-migration router applied that gate to update/pause/resume only."""
|
|
if not await self._tasks.delete(task_id, user_id=user_id):
|
|
raise TaskNotFoundError("Scheduled task not found")
|
|
|
|
# ------------------------------------------------------------------ dispatch
|
|
|
|
async def trigger_task(self, task_id: str, *, user_id: str, now: datetime) -> DispatchResult:
|
|
"""Dispatch a task on demand. Unlike the scheduled path this is allowed
|
|
while the task is paused, and leaves it paused."""
|
|
task = await self.get_task(task_id, user_id=user_id)
|
|
return await self.dispatch_task(task, now=now, trigger=TriggerKind.MANUAL)
|
|
|
|
async def run_once(self, *, now: datetime) -> list[DispatchResult]:
|
|
"""Claim whatever is due and dispatch it.
|
|
|
|
`max_concurrent_runs` is a global cap on active scheduled runs, not a
|
|
per-poll batch size: long runs accumulate across poll cycles, so each
|
|
cycle only claims into the remaining budget.
|
|
"""
|
|
active = await self._runs.count_active()
|
|
budget = self._policy.max_concurrent_runs - active
|
|
if budget <= 0:
|
|
return []
|
|
claimed = await self._tasks.claim_due(now=now, lease_seconds=self._policy.lease_seconds, limit=budget)
|
|
return [await self.dispatch_task(task, now=now, trigger=TriggerKind.SCHEDULED) for task in claimed]
|
|
|
|
async def dispatch_task(self, task: ScheduledTask, *, now: datetime, trigger: TriggerKind) -> DispatchResult:
|
|
"""Turn one due task into one execution.
|
|
|
|
Called once per dispatch, so `resolve_execution_thread` is called once
|
|
and its value reused for the record, the launch, and the result.
|
|
"""
|
|
execution_thread_id = task.resolve_execution_thread()
|
|
|
|
# "skip" must hold for fresh-thread runs too, where every run gets a
|
|
# new thread and the same-thread busy signal below can never fire.
|
|
# Checked before creating this dispatch's own record so the record does
|
|
# not count itself as the active run. A manual trigger against an
|
|
# active run is rejected outright instead of being recorded as a
|
|
# skipped occurrence -- nothing was scheduled to happen.
|
|
#
|
|
# This check is a NON-ATOMIC fast path: two concurrent dispatches (a
|
|
# manual trigger racing the poller, a double-click, a client retry) can
|
|
# both observe no active run. The repository is the atomic arbiter --
|
|
# it rejects the second active record with ActiveRunConflictError,
|
|
# which collapses to the SAME outcome as this fast path just below.
|
|
if task.skips_on_overlap and await self._runs.has_active(task.task_id):
|
|
if trigger is TriggerKind.MANUAL:
|
|
return self._conflict(execution_thread_id)
|
|
return await self._record_scheduled_skip(task, thread_id=execution_thread_id, now=now, trigger=trigger)
|
|
|
|
record = ScheduledRun.queued(
|
|
task_id=task.task_id,
|
|
thread_id=execution_thread_id,
|
|
scheduled_for=now,
|
|
trigger=trigger,
|
|
)
|
|
try:
|
|
await self._runs.add(record)
|
|
except ActiveRunConflictError:
|
|
# Lost the race for the task's single active slot: a concurrent
|
|
# dispatch passed the same fast-path check and inserted first.
|
|
# Identical outcome to the fast path above -- that equality is what
|
|
# the dispatch-race regression tests pin.
|
|
if trigger is TriggerKind.MANUAL:
|
|
return self._conflict(execution_thread_id)
|
|
return await self._record_scheduled_skip(task, thread_id=execution_thread_id, now=now, trigger=trigger)
|
|
|
|
# Only the launch is guarded. The port contract admits exactly two
|
|
# escapes, so a failure of the bookkeeping writes below is a genuine
|
|
# fault and propagates instead of being recorded as a failed launch --
|
|
# which would mark an already-running execution as failed.
|
|
try:
|
|
launched = await self._launcher.launch(
|
|
thread_id=execution_thread_id,
|
|
assistant_id=task.assistant_id,
|
|
prompt=task.prompt,
|
|
owner_user_id=task.user_id,
|
|
metadata={
|
|
"scheduled_task_id": task.task_id,
|
|
"scheduled_task_run_id": record.record_id,
|
|
"scheduled_trigger": str(trigger),
|
|
},
|
|
)
|
|
except ThreadBusyError as exc:
|
|
# The execution thread is already busy. On the scheduled path under
|
|
# a skip policy this is an overlap like any other; anything else is
|
|
# reported as a conflict the caller has to deal with.
|
|
if trigger is TriggerKind.SCHEDULED and task.skips_on_overlap:
|
|
return await self._finalize_skip(task, record_id=record.record_id, thread_id=execution_thread_id, now=now, error=str(exc))
|
|
return await self._fail(task, record_id=record.record_id, thread_id=execution_thread_id, now=now, trigger=trigger, error=str(exc), outcome=DispatchOutcome.CONFLICT)
|
|
except LaunchFailedError as exc:
|
|
return await self._fail(task, record_id=record.record_id, thread_id=execution_thread_id, now=now, trigger=trigger, error=str(exc), outcome=DispatchOutcome.FAILED)
|
|
|
|
await self._runs.update_status(
|
|
record.record_id,
|
|
status=RunStatus.RUNNING,
|
|
run_id=launched.run_id,
|
|
started_at=now,
|
|
# A fast-failing run can reach handle_run_completion before this
|
|
# write lands; never clobber its terminal verdict.
|
|
protect_terminal=True,
|
|
)
|
|
await self._tasks.record_launch(
|
|
task.task_id,
|
|
status=task.status_after_launch(trigger=trigger),
|
|
next_run_at=task.schedule.next_after(now),
|
|
last_run_at=now,
|
|
last_run_id=launched.run_id,
|
|
last_thread_id=launched.thread_id,
|
|
last_error=None,
|
|
increment_run_count=True,
|
|
# Same race as the record write above.
|
|
protect_terminal=True,
|
|
)
|
|
return DispatchResult(DispatchOutcome.LAUNCHED, record.record_id, launched.run_id, launched.thread_id, None)
|
|
|
|
# ------------------------------------------------------------------ lifecycle
|
|
|
|
async def handle_run_completion(self, outcome: RunOutcome, *, now: datetime) -> None:
|
|
"""Write back a launched run's terminal verdict.
|
|
|
|
A task deleted while its run was in flight simply has nothing to
|
|
update, and that is not an error.
|
|
"""
|
|
await self._runs.update_status(
|
|
outcome.record_id,
|
|
status=outcome.status,
|
|
run_id=outcome.run_id,
|
|
error=outcome.error,
|
|
finished_at=now,
|
|
)
|
|
# Read to ask the aggregate what this outcome means, then write only
|
|
# that. `status_after_completion` reads nothing but the schedule type,
|
|
# which no concurrent write can change, so this read carries no
|
|
# time-of-check risk -- and `record_completion` deliberately does not
|
|
# write the fields that a concurrent `record_launch` owns.
|
|
task = await self._tasks.get(outcome.task_id, user_id=outcome.user_id)
|
|
if task is None:
|
|
return
|
|
# The error is recorded whether or not the status moves: a cron task
|
|
# keeps its schedule but still reports what went wrong last time.
|
|
await self._tasks.record_completion(
|
|
outcome.task_id,
|
|
user_id=outcome.user_id,
|
|
status=task.status_after_completion(outcome.status),
|
|
error=outcome.error,
|
|
)
|
|
|
|
async def reconcile_on_startup(self, *, error: str) -> tuple[int, int]:
|
|
"""Clean up what a process crash left behind, returning what was fixed.
|
|
|
|
Two sweeps, because a crash strands two different things: execution
|
|
records that can never finish, and `once` tasks parked waiting for a
|
|
completion hook that died with the process. The second is not covered
|
|
by expired-claim reclaim -- a launched task released its claim, so the
|
|
claim query can never see it again.
|
|
|
|
Failures propagate: whether a partial reconcile should block startup is
|
|
the caller's policy, not the domain's.
|
|
"""
|
|
stale_runs = await self._runs.mark_stale_active(error=error)
|
|
stuck_tasks = await self._tasks.cancel_stuck_once_tasks(error=error)
|
|
return stale_runs, stuck_tasks
|
|
|
|
# ------------------------------------------------------------------ internals
|
|
|
|
async def _require_thread(self, task: ScheduledTask) -> None:
|
|
if task.context_mode is not ContextMode.REUSE_THREAD:
|
|
return
|
|
# The aggregate guarantees a thread here; the check keeps that
|
|
# guarantee from being silently dropped under `python -O`.
|
|
if not task.thread_id or not await self._threads.exists_for_user(task.thread_id, task.user_id):
|
|
raise ThreadNotFoundError("Thread not found")
|
|
|
|
async def _save(self, task: ScheduledTask) -> ScheduledTask:
|
|
"""Persist an already-validated aggregate.
|
|
|
|
Read-modify-write rather than a conditional UPDATE: pushing the
|
|
"not while running" rule into a storage predicate would put it beyond
|
|
the reach of a zero-IO test and give it a second home. The pre-existing
|
|
code had the same shape, and closing the window properly needs
|
|
optimistic locking, which needs a schema change.
|
|
"""
|
|
saved = await self._tasks.save(task)
|
|
if saved is None:
|
|
raise TaskNotFoundError("Scheduled task not found")
|
|
return saved
|
|
|
|
def _conflict(self, thread_id: str) -> DispatchResult:
|
|
"""A manual trigger against an active run.
|
|
|
|
No history record is written: nothing was scheduled to happen, so there
|
|
is no occurrence to account for.
|
|
"""
|
|
return DispatchResult(DispatchOutcome.CONFLICT, None, None, thread_id, _ACTIVE_RUN_CONFLICT_ERROR)
|
|
|
|
async def _record_scheduled_skip(self, task: ScheduledTask, *, thread_id: str, now: datetime, trigger: TriggerKind) -> DispatchResult:
|
|
"""Account for a scheduled occurrence dropped because of an overlap.
|
|
|
|
The tombstone is created directly terminal rather than as the transient
|
|
queued record the launch path uses: a queued record is active and would
|
|
itself be refused against the pre-existing run that is still holding
|
|
the task's single active slot.
|
|
"""
|
|
record = ScheduledRun.skipped_tombstone(
|
|
task_id=task.task_id,
|
|
thread_id=thread_id,
|
|
scheduled_for=now,
|
|
trigger=trigger,
|
|
)
|
|
await self._runs.add(record)
|
|
return await self._finalize_skip(task, record_id=record.record_id, thread_id=thread_id, now=now, error=_SKIP_ACTIVE_RUN_ERROR)
|
|
|
|
async def _finalize_skip(self, task: ScheduledTask, *, record_id: str, thread_id: str, now: datetime, error: str) -> DispatchResult:
|
|
await self._runs.update_status(
|
|
record_id,
|
|
status=RunStatus.SKIPPED,
|
|
error=error,
|
|
started_at=now,
|
|
finished_at=now,
|
|
)
|
|
await self._tasks.record_launch(
|
|
task.task_id,
|
|
status=task.status_after_skip(),
|
|
next_run_at=task.schedule.next_after(now),
|
|
# A skip is not an execution, so the launch bookkeeping carries
|
|
# over unchanged; record_launch assigns unconditionally, so
|
|
# "unchanged" has to be spelled out.
|
|
last_run_at=task.last_run_at,
|
|
last_run_id=task.last_run_id,
|
|
last_thread_id=task.last_thread_id,
|
|
# Only a lost one-shot occurrence is worth surfacing; a cron task
|
|
# simply waits for its next turn.
|
|
last_error=error if task.schedule.schedule_type is ScheduleType.ONCE else None,
|
|
increment_run_count=False,
|
|
)
|
|
return DispatchResult(DispatchOutcome.SKIPPED, record_id, None, thread_id, error)
|
|
|
|
async def _fail(
|
|
self,
|
|
task: ScheduledTask,
|
|
*,
|
|
record_id: str,
|
|
thread_id: str,
|
|
now: datetime,
|
|
trigger: TriggerKind,
|
|
error: str,
|
|
outcome: DispatchOutcome,
|
|
) -> DispatchResult:
|
|
await self._runs.update_status(
|
|
record_id,
|
|
status=RunStatus.FAILED,
|
|
error=error,
|
|
started_at=now,
|
|
finished_at=now,
|
|
)
|
|
await self._tasks.record_launch(
|
|
task.task_id,
|
|
status=task.status_after_failure(trigger=trigger),
|
|
next_run_at=task.schedule.next_after(now),
|
|
last_run_at=now,
|
|
last_run_id=None,
|
|
last_thread_id=thread_id,
|
|
last_error=error,
|
|
increment_run_count=False,
|
|
)
|
|
return DispatchResult(outcome, record_id, None, thread_id, error)
|