mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-28 00:48:07 +00:00
`browserless` reads `cfg["timeout_s"]`, while its sibling web providers `crawl4ai` and `jina_ai` read `cfg["timeout"]`. Tool configs allow extra fields, so the unrecognised spelling is dropped without a diagnostic: someone adapting one provider's config snippet for another silently gets the 30s default instead of the timeout they set. (Observed in the other direction, on a deployment whose crawl4ai entry carried `timeout_s`.) Accept both keys, preferring the documented `timeout_s` when both are present. While adding coverage, two pre-existing bugs in the same three lines surfaced, both already guarded in crawl4ai/jina_ai but not here: - `timeout_s: "30s"` (or any non-numeric string) raised ValueError out of `float(raw)` during tool construction rather than falling back. - `timeout_s: off` -- YAML parses that as `False`, and `float(False)` is `0.0`, so every request timed out immediately against a healthy server. `_coerce_timeout` now mirrors the sibling providers: booleans and unparsable strings fall back to the default, with a warning for the string case. Tests: five cases in tests/test_browserless_client.py covering both keys, the precedence order, and both coercion bugs. Verified red before the fix (3 of 5 fail) and green after. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
359 lines
14 KiB
Python
359 lines
14 KiB
Python
import asyncio
|
|
import logging
|
|
import os
|
|
import re
|
|
from datetime import UTC, datetime
|
|
from pathlib import Path
|
|
from typing import Annotated
|
|
from urllib.parse import urlparse
|
|
|
|
from langchain.tools import InjectedToolCallId, tool
|
|
from langchain_core.messages import ToolMessage
|
|
from langgraph.types import Command
|
|
|
|
from deerflow.community.url_safety import resolve_host_addresses as _resolve_host_addresses
|
|
from deerflow.community.url_safety import validate_public_http_url
|
|
from deerflow.config import get_app_config
|
|
from deerflow.config.paths import VIRTUAL_PATH_PREFIX
|
|
from deerflow.tools.types import Runtime
|
|
from deerflow.utils.readability import ReadabilityExtractor
|
|
|
|
from .browserless_client import BrowserlessClient, BrowserlessFetchResult, BrowserlessScreenshotResult
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
# readability_extractor runs CPU-bound parsing; always call via asyncio.to_thread
|
|
_readability_extractor = ReadabilityExtractor()
|
|
_OUTPUTS_VIRTUAL_PREFIX = f"{VIRTUAL_PATH_PREFIX}/outputs"
|
|
_OUTPUT_FORMAT_TO_EXTENSION = {
|
|
"png": "png",
|
|
"jpeg": "jpeg",
|
|
"webp": "webp",
|
|
}
|
|
_SAFE_FILENAME_RE = re.compile(r"[^A-Za-z0-9._-]+")
|
|
# Cap collision-suffix probing so a saturated outputs directory cannot spin forever.
|
|
_MAX_FILENAME_COLLISION_PROBES = 1000
|
|
|
|
|
|
def _get_tool_config(tool_name: str) -> dict | None:
|
|
"""Get tool config extras safely, returning None if not configured."""
|
|
config = get_app_config().get_tool_config(tool_name)
|
|
if config is None:
|
|
return None
|
|
extras = config.model_extra
|
|
return extras if extras is not None else {}
|
|
|
|
|
|
def _coerce_timeout(value: object, default: float) -> float:
|
|
"""Coerce a config timeout into seconds, falling back to ``default`` on bad input.
|
|
|
|
Mirrors ``crawl4ai._coerce_timeout`` / ``jina_ai._coerce_timeout``: booleans and
|
|
non-numeric strings fall back to the default, so ``timeout_s: off`` (YAML ``False``)
|
|
does not become ``0.0`` and time out every request against a healthy server, and a
|
|
typo'd value does not raise out of tool construction.
|
|
"""
|
|
if isinstance(value, bool):
|
|
return default
|
|
if isinstance(value, (int, float)):
|
|
return float(value)
|
|
if isinstance(value, str):
|
|
try:
|
|
return float(value)
|
|
except ValueError:
|
|
logger.warning("Browserless: invalid timeout %r in config; using %ss", value, default)
|
|
return default
|
|
|
|
|
|
def _resolve_timeout(cfg: dict, default: float) -> float:
|
|
"""Read the timeout, accepting this provider's key and the sibling providers' key.
|
|
|
|
``browserless`` documents ``timeout_s`` while ``crawl4ai`` and ``jina_ai`` read
|
|
``timeout``. An unrecognised key is dropped silently by the extra-fields tool config,
|
|
so someone adapting another provider's snippet got the default with no diagnostic.
|
|
Accept both, preferring the documented ``timeout_s`` when both are present.
|
|
"""
|
|
if "timeout_s" in cfg:
|
|
return _coerce_timeout(cfg["timeout_s"], default)
|
|
if "timeout" in cfg:
|
|
return _coerce_timeout(cfg["timeout"], default)
|
|
return default
|
|
|
|
|
|
def _get_browserless_client(tool_name: str = "web_fetch") -> BrowserlessClient:
|
|
cfg = _get_tool_config(tool_name)
|
|
base_url = "http://localhost:3032"
|
|
token = os.getenv("BROWSERLESS_TOKEN", "")
|
|
timeout_s = 30.0
|
|
if cfg is not None:
|
|
base_url = cfg.get("base_url", base_url)
|
|
token = cfg.get("token", token)
|
|
timeout_s = _resolve_timeout(cfg, timeout_s)
|
|
return BrowserlessClient(base_url=base_url, token=token, timeout_s=timeout_s)
|
|
|
|
|
|
def _as_bool(value: object, default: bool) -> bool:
|
|
if isinstance(value, bool):
|
|
return value
|
|
if isinstance(value, str):
|
|
lowered = value.strip().lower()
|
|
if lowered in {"1", "true", "yes", "on"}:
|
|
return True
|
|
if lowered in {"0", "false", "no", "off"}:
|
|
return False
|
|
return default
|
|
|
|
|
|
def _as_int(value: object, default: int) -> int:
|
|
if isinstance(value, int) and not isinstance(value, bool):
|
|
return value
|
|
if isinstance(value, str):
|
|
try:
|
|
return int(value.strip())
|
|
except ValueError:
|
|
return default
|
|
return default
|
|
|
|
|
|
def _as_optional_quality(value: object, output_format: str) -> int | None:
|
|
if output_format not in {"jpeg", "webp"}:
|
|
return None
|
|
quality = _as_int(value, -1)
|
|
return quality if 0 <= quality <= 100 else None
|
|
|
|
|
|
def _normalize_output_format(value: object) -> str:
|
|
output_format = str(value or "png").strip().lower()
|
|
return output_format if output_format in _OUTPUT_FORMAT_TO_EXTENSION else "png"
|
|
|
|
|
|
def _validate_capture_url(url: str, allow_private_addresses: bool = False) -> str | None:
|
|
"""Validate a capture URL for scheme and (unless opted out) SSRF safety.
|
|
|
|
Blocks requests that resolve to loopback, private, link-local (incl. the
|
|
169.254.169.254 cloud-metadata endpoint), reserved, multicast, or
|
|
unspecified addresses. Operators who intentionally point the tool at an
|
|
internal Browserless target can opt out via ``allow_private_addresses``.
|
|
"""
|
|
return validate_public_http_url(
|
|
url,
|
|
allow_private_addresses=allow_private_addresses,
|
|
action="capture",
|
|
resolver=_resolve_host_addresses,
|
|
)
|
|
|
|
|
|
def _default_capture_stem(url: str) -> str:
|
|
parsed = urlparse(url)
|
|
parts = [parsed.netloc, *[part for part in parsed.path.split("/") if part]]
|
|
raw = "-".join(parts) or "web-capture"
|
|
return raw[:80]
|
|
|
|
|
|
def _safe_capture_filename(filename: str | None, url: str, output_format: str) -> str:
|
|
extension = _OUTPUT_FORMAT_TO_EXTENSION[output_format]
|
|
if filename:
|
|
raw_name = Path(filename).name
|
|
stem = Path(raw_name).stem or "web-capture"
|
|
else:
|
|
timestamp = datetime.now(UTC).strftime("%Y%m%d-%H%M%S")
|
|
stem = f"{_default_capture_stem(url)}-{timestamp}"
|
|
|
|
safe_stem = _SAFE_FILENAME_RE.sub("_", stem).strip("._-") or "web-capture"
|
|
return f"{safe_stem[:100]}.{extension}"
|
|
|
|
|
|
def _thread_outputs_path(runtime: Runtime) -> Path | str:
|
|
if runtime.state is None:
|
|
return "Error: Thread runtime state is not available"
|
|
thread_data = runtime.state.get("thread_data") or {}
|
|
outputs_path = thread_data.get("outputs_path")
|
|
if not outputs_path:
|
|
return "Error: Thread outputs path is not available"
|
|
return Path(outputs_path)
|
|
|
|
|
|
def _tool_message(content: str, tool_call_id: str) -> Command:
|
|
return Command(update={"messages": [ToolMessage(content, tool_call_id=tool_call_id)]})
|
|
|
|
|
|
def _dedupe_output_name(outputs_path: Path, output_name: str) -> str:
|
|
"""Return a non-colliding filename under ``outputs_path``.
|
|
|
|
Keeps the original name when free, otherwise appends ``-1``, ``-2``, ...
|
|
before the extension so an explicit filename never silently overwrites an
|
|
earlier capture. Falls back to a timestamp suffix if the directory is
|
|
saturated with the bounded probe range.
|
|
"""
|
|
candidate = outputs_path / output_name
|
|
if not candidate.exists():
|
|
return output_name
|
|
|
|
stem = Path(output_name).stem
|
|
suffix = Path(output_name).suffix
|
|
for index in range(1, _MAX_FILENAME_COLLISION_PROBES + 1):
|
|
probe = f"{stem}-{index}{suffix}"
|
|
if not (outputs_path / probe).exists():
|
|
return probe
|
|
|
|
timestamp = datetime.now(UTC).strftime("%Y%m%d-%H%M%S-%f")
|
|
return f"{stem}-{timestamp}{suffix}"
|
|
|
|
|
|
def _write_capture_output(outputs_path: Path, output_name: str, content: bytes) -> str:
|
|
"""Write ``content`` into ``outputs_path`` and return the actual filename used."""
|
|
outputs_path.mkdir(parents=True, exist_ok=True)
|
|
final_name = _dedupe_output_name(outputs_path, output_name)
|
|
(outputs_path / final_name).write_bytes(content)
|
|
return final_name
|
|
|
|
|
|
def _target_status_warning(result: BrowserlessScreenshotResult | BrowserlessFetchResult) -> str:
|
|
"""Return a human-readable warning when the fetched/captured page itself errored.
|
|
|
|
Browserless returns HTTP 200 for the render request even when the target
|
|
page responded with a 4xx/5xx (or was an error/anti-bot page), so the raw
|
|
content alone cannot be trusted as a normal successful response. The
|
|
target's real status is surfaced via the X-Response-Code header.
|
|
"""
|
|
code = result.target_status_code.strip()
|
|
if not code or code.startswith(("2", "3")):
|
|
return ""
|
|
status = result.target_status.strip()
|
|
detail = f"{code} {status}".strip()
|
|
return f" (warning: target page responded {detail})"
|
|
|
|
|
|
@tool("web_fetch", parse_docstring=True)
|
|
async def web_fetch_tool(url: str) -> str:
|
|
"""Fetch the contents of a web page at a given URL using Browserless (headless Chrome).
|
|
Only fetch EXACT URLs that have been provided directly by the user or have been returned in results from the web_search and web_fetch tools.
|
|
This tool can NOT access content that requires authentication, such as private Google Docs or pages behind login walls.
|
|
Do NOT add www. to URLs that do NOT have them.
|
|
URLs must include the schema: https://example.com is a valid URL while example.com is an invalid URL.
|
|
|
|
Args:
|
|
url: The URL to fetch the contents of.
|
|
"""
|
|
try:
|
|
cfg = _get_tool_config("web_fetch") or {}
|
|
allow_private_addresses = _as_bool(cfg.get("allow_private_addresses"), False)
|
|
url_error = validate_public_http_url(
|
|
url,
|
|
allow_private_addresses=allow_private_addresses,
|
|
resolver=_resolve_host_addresses,
|
|
)
|
|
if url_error:
|
|
return url_error
|
|
|
|
wait_for_event = ""
|
|
wait_for_timeout_ms = 0
|
|
wait_for_selector = ""
|
|
wait_for_selector_timeout_ms = 5000
|
|
reject_resource_types: list[str] | None = None
|
|
reject_request_pattern: list[str] | None = None
|
|
|
|
wait_for_event = cfg.get("wait_for_event", wait_for_event)
|
|
raw_wait = cfg.get("wait_for_timeout_ms", wait_for_timeout_ms)
|
|
wait_for_timeout_ms = int(raw_wait) if not isinstance(raw_wait, int) else raw_wait
|
|
wait_for_selector = cfg.get("wait_for_selector", wait_for_selector)
|
|
|
|
client = _get_browserless_client("web_fetch")
|
|
result = await client.fetch_html_with_status(
|
|
url=url,
|
|
wait_for_event=wait_for_event,
|
|
wait_for_timeout_ms=wait_for_timeout_ms,
|
|
wait_for_selector=wait_for_selector,
|
|
wait_for_selector_timeout_ms=wait_for_selector_timeout_ms,
|
|
reject_resource_types=reject_resource_types,
|
|
reject_request_pattern=reject_request_pattern,
|
|
)
|
|
|
|
if isinstance(result, str):
|
|
return result
|
|
|
|
article = await asyncio.to_thread(_readability_extractor.extract_article, result.html)
|
|
return f"{article.to_markdown()[:4096]}{_target_status_warning(result)}"
|
|
|
|
except Exception as e:
|
|
logger.error(f"Error in web_fetch_tool: {e}")
|
|
return f"Error: {str(e)}"
|
|
|
|
|
|
@tool("web_capture", parse_docstring=True)
|
|
async def web_capture_tool(
|
|
runtime: Runtime,
|
|
url: str,
|
|
tool_call_id: Annotated[str, InjectedToolCallId],
|
|
filename: str | None = None,
|
|
full_page: bool | None = None,
|
|
output_format: str | None = None,
|
|
viewport_width: int | None = None,
|
|
viewport_height: int | None = None,
|
|
) -> Command:
|
|
"""Capture a rendered webpage screenshot and present it as an artifact.
|
|
|
|
Use this tool when you need a visual capture of a public webpage, especially JavaScript-heavy pages, UI states, dashboards, or visual evidence for a report.
|
|
Only capture exact URLs provided by the user or discovered through other tools. Do not use this for private pages behind login unless the user has explicitly configured Browserless outside DeerFlow.
|
|
URLs must include the schema: https://example.com is valid while example.com is invalid.
|
|
|
|
Args:
|
|
url: The http(s) URL to capture.
|
|
filename: Optional output filename. Directories are ignored and the extension is determined by output_format.
|
|
full_page: Optional override for full-page capture.
|
|
output_format: Optional image format: png, jpeg, or webp.
|
|
viewport_width: Optional viewport width in pixels.
|
|
viewport_height: Optional viewport height in pixels.
|
|
"""
|
|
try:
|
|
cfg = _get_tool_config("web_capture") or {}
|
|
allow_private_addresses = _as_bool(cfg.get("allow_private_addresses"), False)
|
|
|
|
url_error = _validate_capture_url(url, allow_private_addresses=allow_private_addresses)
|
|
if url_error:
|
|
return _tool_message(url_error, tool_call_id)
|
|
|
|
outputs_path = _thread_outputs_path(runtime)
|
|
if isinstance(outputs_path, str):
|
|
return _tool_message(outputs_path, tool_call_id)
|
|
|
|
final_format = _normalize_output_format(output_format or cfg.get("output_format", "png"))
|
|
final_full_page = full_page if full_page is not None else _as_bool(cfg.get("full_page"), True)
|
|
final_width = viewport_width if viewport_width is not None else _as_int(cfg.get("viewport_width"), 1280)
|
|
final_height = viewport_height if viewport_height is not None else _as_int(cfg.get("viewport_height"), 720)
|
|
quality = _as_optional_quality(cfg.get("quality"), final_format)
|
|
wait_for_selector = str(cfg.get("wait_for_selector") or "")
|
|
wait_for_selector_timeout_ms = _as_int(cfg.get("wait_for_selector_timeout_ms"), 5000)
|
|
wait_for_timeout_ms = _as_int(cfg.get("wait_for_timeout_ms"), 0)
|
|
best_attempt = _as_bool(cfg.get("best_attempt"), False)
|
|
|
|
output_name = _safe_capture_filename(filename, url, final_format)
|
|
|
|
client = _get_browserless_client("web_capture")
|
|
result = await client.capture_screenshot(
|
|
url=url,
|
|
full_page=final_full_page,
|
|
output_format=final_format,
|
|
quality=quality,
|
|
viewport={"width": final_width, "height": final_height},
|
|
wait_for_selector=wait_for_selector,
|
|
wait_for_selector_timeout_ms=wait_for_selector_timeout_ms,
|
|
wait_for_timeout_ms=wait_for_timeout_ms,
|
|
best_attempt=best_attempt,
|
|
)
|
|
if isinstance(result, str):
|
|
return _tool_message(result, tool_call_id)
|
|
|
|
final_name = await asyncio.to_thread(_write_capture_output, outputs_path, output_name, result.content)
|
|
virtual_path = f"{_OUTPUTS_VIRTUAL_PREFIX}/{final_name}"
|
|
message = f"Captured screenshot: {virtual_path}{_target_status_warning(result)}"
|
|
return Command(
|
|
update={
|
|
"artifacts": [virtual_path],
|
|
"messages": [ToolMessage(message, tool_call_id=tool_call_id)],
|
|
}
|
|
)
|
|
|
|
except Exception as e:
|
|
logger.error(f"Error in web_capture_tool: {e}")
|
|
return _tool_message(f"Error: {str(e)}", tool_call_id)
|