mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-27 16:37:55 +00:00
* refactor(memory): pluggable MemoryManager interface for backend onboarding
Optimize the MemoryManager interface layer so new backends (mem0/openviking)
onboard with less code and the contract stays stable as capabilities are
added. A minimal backend now implements only from_config + add + get_context
(verified by test_memory_manager_interface.py::_MinimalBackend onboarding via
the factory); the factory no longer knows a backend's private hooks.
- MemoryManager: ABC -> pydantic BaseModel; three-tier methods (tier-1
add/get_context abstract; tier-2 management defaults; tier-3 optional hooks
warm/reload/fact + on_pre_compress/on_turn_start). Dropped 3 self-serving
hooks. 6 hasattr probe sites -> direct call + try/except NotImplementedError.
- from_config classmethod: factory thins to resolve + inject storage_path +
collect host hooks + call from_config; DeerMem-specific hook consumption
moved from factory to DeerMem.from_config.
- Invariants: @model_validator (mode='tool' requires search via supports_search
ClassVar); DeerMemConfig storage_path-is-file check moved here from factory.
- Async: aadd/aget_context/asearch default to the sync path (speculative).
- Callbacks: MemoryCallbacks + LangfuseMemoryCallbacks; on_memory_llm_call
subsumes tracing_callback (same signature/timing/mutation); deleted the
tracing_callback field. DeerMem decoupled from langfuse (portability).
- noop keeps read-op empty overrides (avoids router 500s on the
disable-memory-via-noop path); only delete/export inherit the base raise.
Behavior preserved: 661 passed / 13 skipped. Docs: backends/README.md rewritten
(three-tier + from_config + callbacks); samples README updated; removed stale
private doc paths.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(memory): 501 on unsupported read/manage endpoints + accurate warm log
Review follow-up on the three-tier MemoryManager refactor.
- Read/manage endpoints (GET /memory, /memory/export, /memory/status,
DELETE /memory, POST /memory/import) and the /memory/reload fallback now
catch NotImplementedError -> 501, matching the fact-CRUD endpoints. The
hasattr->try/except migration had skipped these: they were @abstractmethod
before (every backend implemented them, so they never raised), so once they
became tier-2 default-raise a minimal backend (only add + get_context) hit a
raw 500 -- there is no global NotImplementedError handler. get_memory is
shared via _get_memory_or_501 (covers /memory, export, status, reload
fallback). noop is unchanged: its read-op empty overrides never raise.
- warm() base default returns None (tri-state: True=warmed, False=failed,
None=nothing to warm) so the Gateway lifespan logs "skipping" for a
non-DeerMem backend (e.g. noop) instead of the inaccurate "warmed
successfully" it never earned. DeerMem.warm keeps True/False.
- Tests: 6 router 501 tests (read/manage + reload fallback) + 2 lifespan
warm-log tests (None->skipping, False->warning); conformance/pluggable
assert warm() is None.
705 passed / 13 skipped; lint clean.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(memory): review follow-ups - search-flag consistency, client reload, backend_config purity
Address review feedback on the three-tier MemoryManager refactor:
- [Medium] supports_search/search drift: the invariant now requires the
supports_search ClassVar flag to MATCH whether search() is actually
overridden (type(self).search is not MemoryManager.search), so the flag
can't drift from the impl. Catches both directions at instantiation: a
backend that overrides search() but forgets supports_search=True (was a
misleading tool-mode rejection), and one that sets the flag without
overriding (was a runtime NotImplementedError on the first memory_search).
noop sets supports_search=True to match its search() override. Conformance
adds drift + consistent-backend tests.
- [Low] client.reload_memory fallback: wrap the get_memory fallback so a
minimal backend (only add + get_context) surfaces a clean NotImplementedError
("implements neither reload_memory nor get_memory") instead of an uncaught
propagation -- mirrors the router's 501. Test added.
- [Low] backend_config purity: DeerMem.from_config restores backend_config to
the pure data the host passed after model_post_init parses the injected hooks
into DeerMemConfig (self._config, PrivateAttr); the field stays serializable
(no callables/LLM) and matches the README ("host hooks NOT in backend_config").
Test asserts purity + hooks wired.
- [Low] CHANGELOG: breaking-change note that mode='tool' + non-search backend
now fails fast at startup (was silently empty) so operators recognize it on
upgrade.
- [Nit] .gitignore: drop the env-specific .tmp-pytest/ entry (--basetemp is
local-only, not make test/CI).
709 passed / 13 skipped; lint clean.
Co-Authored-By: Claude <noreply@anthropic.com>
* docs(changelog): correct memory tool-mode fail-fast note
The CHANGELOG entry said mode='tool' + a non-search backend "(e.g. noop)"
fails fast at startup, but noop overrides search() (returns []) and sets
supports_search=True (required by the consistency invariant), so noop IS
search-capable and noop+tool does NOT fail fast. The fail-fast only affects a
custom backend that onboards without overriding search(). Reworded to drop the
misleading noop example and state both shipping backends implement search().
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
249 lines
9.7 KiB
Python
249 lines
9.7 KiB
Python
"""Memory tools for tool-driven memory mode.
|
|
|
|
Exposes memory_search, memory_add, memory_update, memory_delete as
|
|
LangChain @tool functions the model can call directly.
|
|
|
|
When memory.mode == "tool", these tools are registered on the agent
|
|
instead of appending MemoryMiddleware. The model gains agency over
|
|
its own persistent memory: it decides what to remember, when to
|
|
search, and when to update or remove stale facts.
|
|
|
|
Backend-agnostic: every tool goes through the ``MemoryManager`` ABC
|
|
(:func:`get_memory_manager`) -- ``search``/``get_memory`` are tier-2 methods;
|
|
``create_fact``/``update_fact``/``delete_fact`` are tier-3 hooks with a default
|
|
``raise NotImplementedError`` (unsupported -> the tool catches it and returns a
|
|
JSON ``error`` instead of crashing). So tool mode works for any backend that
|
|
overrides those ops (DeerMem does; noop inherits the raises -> errors).
|
|
"""
|
|
|
|
import json
|
|
import logging
|
|
|
|
from langchain.tools import tool
|
|
|
|
from deerflow.agents.memory.manager import get_memory_manager
|
|
from deerflow.runtime.user_context import resolve_runtime_user_id
|
|
from deerflow.tools.types import Runtime
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def _resolve_scope(runtime: Runtime | None = None) -> tuple[str | None, str]:
|
|
"""Resolve agent_name and user_id for tool handler scope.
|
|
|
|
Tool execution receives user and agent metadata through LangGraph runtime
|
|
context. Prefer that channel over ContextVar fallback so persistence stays
|
|
scoped correctly across request/task boundaries.
|
|
"""
|
|
context = getattr(runtime, "context", None)
|
|
agent_name = None
|
|
if isinstance(context, dict) and context.get("agent_name"):
|
|
agent_name = str(context["agent_name"])
|
|
return agent_name, resolve_runtime_user_id(runtime)
|
|
|
|
|
|
def _memory_content_key(content: str) -> str:
|
|
return content.strip().casefold()
|
|
|
|
|
|
@tool("memory_search", parse_docstring=True)
|
|
def memory_search_tool(
|
|
runtime: Runtime,
|
|
query: str,
|
|
category: str | None = None,
|
|
limit: int = 10,
|
|
) -> str:
|
|
"""Search existing facts by natural language query.
|
|
|
|
Use this when you need to check what you already know about the user
|
|
- their preferences, past corrections, context, or any stored facts.
|
|
|
|
Args:
|
|
query: Natural language query to match against fact content.
|
|
Case-insensitive substring matching.
|
|
category: Optional category filter (e.g. "preference", "correction",
|
|
"context"). Only facts with this exact category are returned.
|
|
limit: Maximum results to return (default 10).
|
|
|
|
Returns:
|
|
JSON string with "results" (list of fact objects) and "count".
|
|
Each fact has id, content, category, confidence, createdAt, and source.
|
|
"""
|
|
agent_name, user_id = _resolve_scope(runtime)
|
|
try:
|
|
results = get_memory_manager().search(
|
|
query,
|
|
top_k=limit,
|
|
user_id=user_id,
|
|
agent_name=agent_name,
|
|
category=category,
|
|
)
|
|
return json.dumps({"results": results, "count": len(results)}, ensure_ascii=False)
|
|
except Exception as exc:
|
|
logger.exception("memory_search_tool failed")
|
|
return json.dumps({"error": str(exc)})
|
|
|
|
|
|
@tool("memory_add", parse_docstring=True)
|
|
def memory_add_tool(
|
|
runtime: Runtime,
|
|
content: str,
|
|
category: str = "context",
|
|
confidence: float = 0.7,
|
|
) -> str:
|
|
"""Store a new fact about the user or conversation context.
|
|
|
|
Use this when the user shares something worth remembering for future
|
|
conversations - preferences, corrections, personal details, work context.
|
|
The fact persists across sessions and will be available via memory_search
|
|
and automatic context injection.
|
|
|
|
Args:
|
|
content: The fact text to remember. Be specific and factual.
|
|
category: Category label for organization (default "context").
|
|
e.g. "preference", "correction", "behavior", "personal".
|
|
confidence: How certain you are about this fact, 0.0-1.0
|
|
(default 0.7). Use higher values for explicit user statements,
|
|
lower for inferences.
|
|
|
|
Returns:
|
|
JSON string with "fact_id" and "status": "added".
|
|
On duplicate content, returns "error" with explanation.
|
|
"""
|
|
agent_name, user_id = _resolve_scope(runtime)
|
|
try:
|
|
normalized_content = content.strip()
|
|
if not normalized_content:
|
|
return json.dumps({"error": "empty content"})
|
|
content_key = _memory_content_key(normalized_content)
|
|
manager = get_memory_manager()
|
|
existing_facts = manager.get_memory(agent_name=agent_name, user_id=user_id).get("facts", [])
|
|
# Tool calls normally run one-at-a-time per user turn. If tool-mode
|
|
# writing broadens to multiple concurrent calls for the same user,
|
|
# move duplicate rejection into the storage/update critical section.
|
|
if any(_memory_content_key(str(fact.get("content", ""))) == content_key for fact in existing_facts):
|
|
return json.dumps({"error": "Duplicate fact"})
|
|
|
|
# create_fact returns (memory_data, fact_id) -- use the id directly rather
|
|
# than re-deriving it by content matching (which would couple the tool to
|
|
# the backend's content normalization and could misreport a storage cap).
|
|
# Unsupported backends raise NotImplementedError (tier-3 default) -> JSON error.
|
|
try:
|
|
_memory_data, fact_id = manager.create_fact(
|
|
normalized_content,
|
|
category=category,
|
|
confidence=confidence,
|
|
agent_name=agent_name,
|
|
user_id=user_id,
|
|
)
|
|
except NotImplementedError:
|
|
return json.dumps({"error": f"memory backend {type(manager).__name__} does not support create_fact"})
|
|
if fact_id is None:
|
|
# max_facts cap kept higher-confidence facts and evicted the new one;
|
|
# the fact was not stored -- report honestly instead of a dangling id.
|
|
return json.dumps({"error": "Fact was not stored because memory.max_facts kept higher-confidence facts"})
|
|
return json.dumps({"fact_id": fact_id, "status": "added"})
|
|
except ValueError as exc:
|
|
return json.dumps({"error": str(exc)})
|
|
except Exception as exc:
|
|
logger.exception("memory_add_tool failed")
|
|
return json.dumps({"error": str(exc)})
|
|
|
|
|
|
# Tool mode exposes explicit CRUD, not the passive staleness-review path.
|
|
# The staleness age/category/removal-count guardrails protect automatic
|
|
# middleware cleanup; tool-mode operators opt into model-directed updates
|
|
# and deletes. The docs call out this difference for configuration review.
|
|
|
|
|
|
@tool("memory_update", parse_docstring=True)
|
|
def memory_update_tool(
|
|
runtime: Runtime,
|
|
fact_id: str,
|
|
content: str | None = None,
|
|
category: str | None = None,
|
|
confidence: float | None = None,
|
|
) -> str:
|
|
"""Update an existing fact. Only provided fields are changed; omitted
|
|
fields stay as-is.
|
|
|
|
Use this when a stored fact is outdated, incorrect, or needs refinement.
|
|
First use memory_search to find the fact_id, then update it.
|
|
|
|
Args:
|
|
fact_id: Fact ID from memory_search results (required).
|
|
content: New fact text (unchanged if omitted).
|
|
category: New category (unchanged if omitted).
|
|
confidence: New confidence score 0.0-1.0 (unchanged if omitted).
|
|
|
|
Returns:
|
|
JSON string with "fact_id" and "status": "updated".
|
|
On invalid fact_id, returns "error" with explanation.
|
|
"""
|
|
agent_name, user_id = _resolve_scope(runtime)
|
|
try:
|
|
manager = get_memory_manager()
|
|
try:
|
|
manager.update_fact(
|
|
fact_id,
|
|
content=content,
|
|
category=category,
|
|
confidence=confidence,
|
|
agent_name=agent_name,
|
|
user_id=user_id,
|
|
)
|
|
except NotImplementedError:
|
|
return json.dumps({"error": f"memory backend {type(manager).__name__} does not support update_fact"})
|
|
return json.dumps({"fact_id": fact_id, "status": "updated"})
|
|
except KeyError:
|
|
return json.dumps({"error": f"Fact not found: {fact_id}"})
|
|
except ValueError as exc:
|
|
return json.dumps({"error": str(exc)})
|
|
except Exception as exc:
|
|
logger.exception("memory_update_tool failed")
|
|
return json.dumps({"error": str(exc)})
|
|
|
|
|
|
@tool("memory_delete", parse_docstring=True)
|
|
def memory_delete_tool(runtime: Runtime, fact_id: str) -> str:
|
|
"""Delete a fact by its ID.
|
|
|
|
Use this when a fact is no longer accurate or relevant. First use
|
|
memory_search to find the fact_id, then delete it.
|
|
|
|
Args:
|
|
fact_id: Fact ID to delete (from memory_search results).
|
|
|
|
Returns:
|
|
JSON string with "fact_id" and "status": "deleted".
|
|
On invalid fact_id, returns "error" with explanation.
|
|
"""
|
|
agent_name, user_id = _resolve_scope(runtime)
|
|
try:
|
|
manager = get_memory_manager()
|
|
try:
|
|
manager.delete_fact(fact_id, agent_name=agent_name, user_id=user_id)
|
|
except NotImplementedError:
|
|
return json.dumps({"error": f"memory backend {type(manager).__name__} does not support delete_fact"})
|
|
return json.dumps({"fact_id": fact_id, "status": "deleted"})
|
|
except KeyError:
|
|
return json.dumps({"error": f"Fact not found: {fact_id}"})
|
|
except ValueError as exc:
|
|
return json.dumps({"error": str(exc)})
|
|
except Exception as exc:
|
|
logger.exception("memory_delete_tool failed")
|
|
return json.dumps({"error": str(exc)})
|
|
|
|
|
|
def get_memory_tools() -> list:
|
|
"""Return all memory tools for agent registration.
|
|
|
|
Called by agent factory when memory.mode == "tool".
|
|
"""
|
|
return [
|
|
memory_search_tool,
|
|
memory_add_tool,
|
|
memory_update_tool,
|
|
memory_delete_tool,
|
|
]
|