* fix(design): make workflows self-contained, add bundled-skill contract (#474 finding 2)
The design skill's banner and social-photos workflows named skills the plugin
does not ship (frontend-design, ai-artist, ai-multimodal, chrome-devtools,
project-management, assets-organizing) and claudekit command namespaces
(/ckm:brand, /ck:ui-ux-pro-max), so those steps fail or force the agent to
improvise under a plugin or CLI install. Rewrite them after the pattern of
#473: bundled skills stay referenced by name, optional tooling becomes an
optional runtime capability, unbundled steps are implemented inline or
dropped. The same references sat in references/social-photos-design.md, so
the fix covers the skill directory, not just SKILL.md; the CLI copy is synced.
check-asset-sync.yml gains a bundled-skill contract over both skill trees:
no /ck: or /ckm: namespace, every "`name` skill" reference must be a
directory under .claude/skills, and none of the claudekit-only names above
in any spelling.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(design): address review - list-aware skill grep, case-insensitive denylist, banner intro, report naming
- contract grep 2 walks comma/and/or lists so every member is checked, not
only the last one, and accepts the sub-skill and bold forms; grep 3 matches
case-insensitively; the step comment states what is not covered
- banner intro no longer claims "no sibling skills" while step 2 names the
bundled ui-ux-pro-max skill
- social-photos report name stated inline instead of "naming pattern from
session hooks" (a claudekit convention nothing in the bundle provides);
"persistent" dropped from the task-list step; device-scale note scoped to
tools that support it
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(ci): match wrapped skill lists - read each file as one record in the bundled-skill contract
A Markdown list wrapped over two lines ("`playwright-mcp`,\n`brand`, and
`ui-ux-pro-max` skills") passed the line-oriented allowlist grep. Read the
file as one record (-z, separators as \s+) so wrapped lists are still lists;
a hit now names the file and the name instead of the line. grep's own exit
status is taken inside the substitution so an unreadable file still fails the
step under plain bash -e, pipefail or not.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Refs #474 (finding 1 follow-up to #476, which rewrote design/SKILL.md
and added a contract that grepped only */SKILL.md; the same defect one
level down survived).
- 29 home-rooted paths (~/.claude/skills/design/scripts/...) in
design/references/{cip,icon,logo}-design.md -> scripts/... (27 at
review time, two more added by #470); the printed
hint in design/scripts/cip/generate.py now derives the absolute path
from __file__
- 19 project-rooted invocations (.claude/skills/<skill>/scripts/...) in
brand/, slides/ and design/ references -> scripts/... (own skill) or
../<skill>/scripts/... (sibling sub-skill; sub-skills are installed
side by side in every layout)
- brand/scripts/sync-brand-to-tokens.cjs resolved its sibling script from
process.cwd(), silently skipping CSS regeneration under plugin and
--global installs; now resolved from __dirname, with a warning when
the sibling skill is missing; regression test asserts the regeneration
- brand/scripts/extract-colors.cjs: tool-neutral hint instead of a
project-rooted path into a skill this plugin does not ship
- "Script Paths" section in the five sub-skills that invoke scripts:
script path from the skill directory, working directory at the
project root
- new test_skill_script_paths.py (src, mirrored to both scripts/tests
copies): every python/node/bash invocation in every shipped skill
markdown must be skill-relative and name a file that ships
- check-asset-sync.yml: contract covers every file under both skill
trees and home-/project-/variable-rooted forms; ${CLAUDE_PLUGIN_ROOT}
allowed only in the plugin-only core SKILL.md; LC_ALL=C + -I for the tracked
.coverage binary; grep errors fail instead of passing; push filter
includes the workflow and sync-assets.mjs
- CLI copy regenerated via sync-assets.mjs
Co-authored-by: notbucki <daniel@buckenmaier.xyz>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Replace all 22 hard-coded ~/.claude/skills/design/scripts/... invocations
in the design skill with skill-relative paths (python3 scripts/...), the
same convention the brand and design-system sub-skills already use. The
user-level path only works in one install context: under a marketplace/
plugin install the skill lives in the plugin cache, and under project-level
CLI installs there is no ~/.claude/skills/design/ either.
Edited .claude/skills/design/SKILL.md (source of truth) and regenerated
the CLI copy with cli/scripts/sync-assets.mjs; --check passes.
Adds a path-contract step to check-asset-sync.yml that fails if any
SKILL.md (either copy) reintroduces a ~/.claude/skills/ invocation, and
widens the workflow's path filters to .claude/skills/** so the contract
actually fires on sub-skill edits.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Adds a workflow that triggers on release published, checks out main,
updates the version field in skill.json, marketplace.json, and plugin.json
to match the release tag, then opens a PR automatically.
Merged by github-maintain cron. Approved by @clark-cant and @jizc. Pre-existing pytest failure on main (ui-styling/shadcn test) is unrelated to PR scope.
- Add SECURITY.md and CODE_OF_CONDUCT.md (community health was at 50%)
- Add bug/feature issue templates and a PR template
- Wire the existing pytest suite under .claude/skills/*/scripts/tests into
a new CI workflow; the test docstrings claimed "the existing pytest CI
runs them" but no workflow actually did
- Add @playwright/test to cli/ with a smoke test that loads the shipped
preview/xiaomaomi-app.html and asserts no console errors
- Fix a malformed SVG path (invalid `d` attribute) in
preview/xiaomaomi-app.html found by that new test, replacing it with
the equivalent valid paw icon path already used elsewhere in the file
- add CSV structural validation and all-domain smoke tests
- repair malformed CSV rows in source and bundled CLI assets
- run data validation in CI and prepublish checks
- add npm build wrapper with TypeScript fallback when Bun is unavailable
- fix CLI asset resolution for TypeScript fallback builds
Adds WPF, WinUI 3, UWP, Avalonia, and Uno Platform stacks (17 -> 22 total),
each with its own guidelines CSV, registered in core.py and synced to cli/assets.
- New stack CSVs in src/ and cli/assets/data/stacks/
- search.py / core.py registry updated
- smoke-stacks.sh: EXPECTED_STACK_COUNT 21 -> 22 with a smoke-test workflow
- platform template descriptions and README bumped to 22 technology stacks
* fix CLI asset sync
* fix(cli): normalize line endings in asset sync/check
check:assets hashed raw bytes, so identical CSV/JSON/py content with
CRLF vs LF (git autocrlf on checkout) was reported as stale drift,
blocking the release guard on Windows/mixed checkouts.
- fileHash now normalizes CRLF->LF before hashing, so check:assets
compares content, not line endings.
- sync:assets writes LF-normalized copies instead of a raw byte copy,
so re-syncing is deterministic across platforms.
All synced assets are text (csv/json/md/py); no binaries affected.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* ci: enforce CLI asset sync on PRs
Adds a Check asset sync workflow that runs `npm run check:assets` on any
PR touching src/ui-ux-pro-max/** or cli/assets/**, so the bundled CLI
assets can't silently drift from the source of truth.
The check uses only node builtins (no install step) and normalizes
line endings before hashing, so it hard-fails on real content drift
without the CRLF/LF soft-fail hack other approaches needed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>