From 28b3b8dee8c976df4fa3e94aed4e092ad43fcb03 Mon Sep 17 00:00:00 2001 From: Jallepalli Harsha Vardhan <87539405+harshajv7981@users.noreply.github.com> Date: Mon, 26 Oct 2026 15:37:27 +0530 Subject: [PATCH] fix: don't read '3d'/'2fa' after a stack name as a framework version (#548) The version pattern in _stack_query_requests_legacy had no trailing boundary, so 'react 3d ...' parsed as React 3 and the query got only deprecated rows (or none, for stacks without legacy guidance). Fixes #547 --- .claude/skills/ui-ux-pro-max/scripts/core.py | 2 +- .../scripts/tests/test_web_stack_freshness.py | 14 ++++++++++++++ cli/assets/scripts/core.py | 2 +- .../scripts/tests/test_web_stack_freshness.py | 14 ++++++++++++++ src/ui-ux-pro-max/scripts/core.py | 2 +- .../scripts/tests/test_web_stack_freshness.py | 14 ++++++++++++++ 6 files changed, 45 insertions(+), 3 deletions(-) diff --git a/.claude/skills/ui-ux-pro-max/scripts/core.py b/.claude/skills/ui-ux-pro-max/scripts/core.py index 670fe33..80319d6 100644 --- a/.claude/skills/ui-ux-pro-max/scripts/core.py +++ b/.claude/skills/ui-ux-pro-max/scripts/core.py @@ -856,7 +856,7 @@ def _stack_query_requests_legacy(query, stack): if current_version is not None and stack_name is not None: matches = re.finditer( rf"\b(?:{stack_name})\s*(?:sdk|ui)?\s*(?:[@(]\s*)?(?:v(?:ersion)?\s*)?" - rf"(\d+)(?:\.(\d+))?\s*\)?", + rf"(\d+)(?:\.(\d+))?(?!\w)\s*\)?", normalized, ) requested_versions = [ diff --git a/.claude/skills/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py b/.claude/skills/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py index a54b0ea..2d4dc30 100644 --- a/.claude/skills/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py +++ b/.claude/skills/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py @@ -116,6 +116,20 @@ class TestWebStackFreshness(unittest.TestCase): {row["Status"] for row in result["results"]}, {"deprecated"} ) + def test_number_starting_a_word_is_not_a_version(self): + cases = { + "react": "react 3d canvas effect cleanup", + "html-tailwind": "tailwind 2xl breakpoint", + "angular": "angular 2fa login form", + } + for stack, query in cases.items(): + with self.subTest(stack=stack, query=query): + result = search_stack(query, stack) + self.assertGreater(result["count"], 0) + self.assertNotIn( + "deprecated", {row["Status"] for row in result["results"]} + ) + def test_old_major_without_curated_legacy_guidance_abstains(self): result = search_stack("Astro 5 content collections", "astro") self.assertEqual(result["count"], 0) diff --git a/cli/assets/scripts/core.py b/cli/assets/scripts/core.py index 670fe33..80319d6 100644 --- a/cli/assets/scripts/core.py +++ b/cli/assets/scripts/core.py @@ -856,7 +856,7 @@ def _stack_query_requests_legacy(query, stack): if current_version is not None and stack_name is not None: matches = re.finditer( rf"\b(?:{stack_name})\s*(?:sdk|ui)?\s*(?:[@(]\s*)?(?:v(?:ersion)?\s*)?" - rf"(\d+)(?:\.(\d+))?\s*\)?", + rf"(\d+)(?:\.(\d+))?(?!\w)\s*\)?", normalized, ) requested_versions = [ diff --git a/cli/assets/scripts/tests/test_web_stack_freshness.py b/cli/assets/scripts/tests/test_web_stack_freshness.py index a54b0ea..2d4dc30 100644 --- a/cli/assets/scripts/tests/test_web_stack_freshness.py +++ b/cli/assets/scripts/tests/test_web_stack_freshness.py @@ -116,6 +116,20 @@ class TestWebStackFreshness(unittest.TestCase): {row["Status"] for row in result["results"]}, {"deprecated"} ) + def test_number_starting_a_word_is_not_a_version(self): + cases = { + "react": "react 3d canvas effect cleanup", + "html-tailwind": "tailwind 2xl breakpoint", + "angular": "angular 2fa login form", + } + for stack, query in cases.items(): + with self.subTest(stack=stack, query=query): + result = search_stack(query, stack) + self.assertGreater(result["count"], 0) + self.assertNotIn( + "deprecated", {row["Status"] for row in result["results"]} + ) + def test_old_major_without_curated_legacy_guidance_abstains(self): result = search_stack("Astro 5 content collections", "astro") self.assertEqual(result["count"], 0) diff --git a/src/ui-ux-pro-max/scripts/core.py b/src/ui-ux-pro-max/scripts/core.py index 670fe33..80319d6 100755 --- a/src/ui-ux-pro-max/scripts/core.py +++ b/src/ui-ux-pro-max/scripts/core.py @@ -856,7 +856,7 @@ def _stack_query_requests_legacy(query, stack): if current_version is not None and stack_name is not None: matches = re.finditer( rf"\b(?:{stack_name})\s*(?:sdk|ui)?\s*(?:[@(]\s*)?(?:v(?:ersion)?\s*)?" - rf"(\d+)(?:\.(\d+))?\s*\)?", + rf"(\d+)(?:\.(\d+))?(?!\w)\s*\)?", normalized, ) requested_versions = [ diff --git a/src/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py b/src/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py index a54b0ea..2d4dc30 100644 --- a/src/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py +++ b/src/ui-ux-pro-max/scripts/tests/test_web_stack_freshness.py @@ -116,6 +116,20 @@ class TestWebStackFreshness(unittest.TestCase): {row["Status"] for row in result["results"]}, {"deprecated"} ) + def test_number_starting_a_word_is_not_a_version(self): + cases = { + "react": "react 3d canvas effect cleanup", + "html-tailwind": "tailwind 2xl breakpoint", + "angular": "angular 2fa login form", + } + for stack, query in cases.items(): + with self.subTest(stack=stack, query=query): + result = search_stack(query, stack) + self.assertGreater(result["count"], 0) + self.assertNotIn( + "deprecated", {row["Status"] for row in result["results"]} + ) + def test_old_major_without_curated_legacy_guidance_abstains(self): result = search_stack("Astro 5 content collections", "astro") self.assertEqual(result["count"], 0)