From 1f8857914da3c723d58dab1d609dd0d55a86bf51 Mon Sep 17 00:00:00 2001 From: Shubham Padkonde Date: Mon, 26 Oct 2026 12:36:53 +0530 Subject: [PATCH] fix: clean up successful legacy release downloads (#546) --- cli/src/commands/init.ts | 9 ++-- cli/tests/e2e/legacy-cleanup.spec.ts | 63 ++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+), 5 deletions(-) create mode 100644 cli/tests/e2e/legacy-cleanup.spec.ts diff --git a/cli/src/commands/init.ts b/cli/src/commands/init.ts index 9f0a59a..80dcdf5 100755 --- a/cli/src/commands/init.ts +++ b/cli/src/commands/init.ts @@ -82,11 +82,6 @@ async function tryGitHubInstall( return copiedFolders; } catch (error) { - // Cleanup temp directory on error - if (tempDir) { - await cleanup(tempDir); - } - if (error instanceof GitHubRateLimitError) { spinner.warn(`GitHub rate limit reached, falling back to bundled assets.\n${getGitHubTokenGuidance()}`); return null; @@ -106,6 +101,10 @@ async function tryGitHubInstall( // Unknown errors - still fall back spinner.warn('Download failed, using template generation...'); return null; + } finally { + if (tempDir) { + await cleanup(tempDir); + } } } diff --git a/cli/tests/e2e/legacy-cleanup.spec.ts b/cli/tests/e2e/legacy-cleanup.spec.ts new file mode 100644 index 0000000..8244205 --- /dev/null +++ b/cli/tests/e2e/legacy-cleanup.spec.ts @@ -0,0 +1,63 @@ +import { expect, test } from '@playwright/test'; +import { mkdir, mkdtemp, readFile, readdir, rm } from 'node:fs/promises'; +import { tmpdir } from 'node:os'; +import { join } from 'node:path'; +import { initCommand } from '../../src/commands/init.js'; + +// ZIP containing release/.claude/skills/test/SKILL.md with "release fixture". +const releaseZip = Buffer.from( + 'UEsDBBQAAAAIAE9SWl1tv+CuEQAAAA8AAAAkAAAAcmVsZWFzZS8uY2xhdWRlL3NraWxscy90ZXN0L1NLSUxMLm1kK0rNSU0sTlVIy6woKS1KBQBQSwECFAAUAAAACABPUlpdbb/grhEAAAAPAAAAJAAAAAAAAAAAAAAAgAEAAAAAcmVsZWFzZS8uY2xhdWRlL3NraWxscy90ZXN0L1NLSUxMLm1kUEsFBgAAAAABAAEAUgAAAFMAAAAAAA==', + 'base64' +); + +for (const outcome of ['success', 'download failure', 'extraction failure'] as const) { + test(`legacy install removes temporary downloads after ${outcome}`, async () => { + const scratch = await mkdtemp(join(tmpdir(), 'uipro-legacy-test-')); + const downloads = join(scratch, 'downloads'); + const target = join(scratch, 'project'); + await mkdir(downloads); + await mkdir(target); + + const previousCwd = process.cwd(); + const previousFetch = globalThis.fetch; + const tempKeys = ['TMPDIR', 'TEMP', 'TMP'] as const; + const previousEnv = tempKeys.map(key => process.env[key]); + const requests: string[] = []; + const assetUrl = 'https://example.invalid/release.zip'; + + try { + process.chdir(target); + for (const key of tempKeys) process.env[key] = downloads; + globalThis.fetch = async (input) => { + const url = String(input); + requests.push(url); + if (url.endsWith('/releases/latest')) { + return Response.json({ + tag_name: 'v-test', + assets: [{ name: 'release.zip', browser_download_url: assetUrl }], + }); + } + expect(url).toBe(assetUrl); + if (outcome === 'download failure') return new Response(null, { status: 503 }); + return new Response(outcome === 'success' ? releaseZip : 'invalid ZIP'); + }; + + await initCommand({ ai: 'claude', legacy: true }); + + expect(requests).toHaveLength(2); + if (outcome === 'success') { + expect(await readFile(join(target, '.claude/skills/test/SKILL.md'), 'utf8')) + .toBe('release fixture'); + } + expect(await readdir(downloads)).toEqual([]); + } finally { + globalThis.fetch = previousFetch; + process.chdir(previousCwd); + tempKeys.forEach((key, index) => { + if (previousEnv[index] === undefined) delete process.env[key]; + else process.env[key] = previousEnv[index]; + }); + await rm(scratch, { recursive: true, force: true }); + } + }); +}