mirror of
https://github.com/penpot/penpot.git
synced 2026-11-19 00:20:35 +00:00
* 🐛 Fix shared files 500 on shapes with invalid child ids Old files can list in :shapes ids that are not uuids or that point to no shape. Migration 0033 walked them and hit the uuid assert in get-shape, which throws an AssertionError. The shared files list only caught Exception, so that Error broke the whole list with a 500. Make migration 0033 skip those ids, and catch Throwable when loading each shared file, so a broken file is skipped and logged. Closes #12343 AI-assisted-by: claude-opus-5-5 * 🐛 Repair invalid child ids in migration 0033 v2 Skipping invalid child ids in migration 0033 was not enough: the ids stayed in :shapes, so the file still failed schema validation and could not load. Files that already applied the migration would also never run a changed version of it. The migration now repairs each container before the naming walk: string ids are parsed with uuid/coerce, nil and ids that point to no shape are dropped, the duplicate that 0032 adds when a child is listed as a string is removed, and a :shapes list becomes a vector. Only the shapes that change are re-assoc'ed, so a healthy ObjectsMap is not marked as modified and its page is not rewritten. It ships as 0033-normalize-main-instance-names-v2 at the same position in available-migrations, so files that recorded the old id run it again. That position also makes it parse strings before 0035-fix-dangling-children drops the ids it cannot find. The shared files listing restores the interrupt flag when the cause of a skipped file is an InterruptedException. Tests cover children outside the root walk, legacy components, the objects-map wrapper of the unrealized save path, a list turned into a vector, a shape without a :shapes key, a file that applied the old id, and the end-to-end load of a broken shared file. Relates to #12343 AI-assisted-by: claude-opus-5-5 AI-assisted-by: inkling-2-small-free