mirror of
https://github.com/penpot/penpot.git
synced 2026-11-19 00:20:35 +00:00
* ⚡ Stop resending deleted component objects on every touch `pcb/update-component` attached the whole `:objects` map of a deleted component to every `mod-component` change, so a single component swap re-sent thousands of shapes that the same batch already carried as shape changes. In one measured swap the 49 maps with objects were 94% of the request (6.3 MB), and only 27% of the 4.275 shapes they carried differed from what the server had. Now `mod-component` carries component metadata only, and shapes inside a component travel as `:mod-obj` changes scoped with `:component-id`, which is what the component sync already emits. An absent `:objects` key means "leave the stored shapes alone", only an explicit `nil` drops them, so metadata-only changes cannot wipe a deleted component. The two repairs that fix shapes inside a component (shape-ref cycle and duplicated swap slot) now emit one `:mod-obj` per shape; the two that move or clear the `:objects` key keep the whole-map write behind the new `:objects? true` option. Same swap on the measured file: 6.328.307 to 382.571 bytes. AI-assisted-by: space-bunny * 🔧 Cover the mod-component objects contract with tests `pcb/update-component` sends the `:objects` map only when the caller passes `:objects? true`, and `ctkl/mod-component` reads an absent key as "leave the stored shapes alone". Two repairs depend on that option, and dropping it broke nothing visible: the change carried no `:objects`, the applier kept the invalid component as is, and the suite stayed green. Add one repair test per error code, including the deleted-component branch that must keep the map empty, and a round-trip test for the shape-ref cycle repair. That repair now emits one `:mod-obj` per shape and had no coverage; the test pins the scoped `:component-id` and that no shape is lost. Reword the `update-component` docstring as well: it describes what the option does to the change instead of listing its current callers, which goes stale as soon as another caller uses it. AI-assisted-by: deepseek-v4.1-flash * 🔧 Harden the mod-component repair tests Address the review of the previous commit. The cycle test only rejected a shape-ref pointing to itself, so it would have passed if the repair repointed the link instead of removing it, or if it left the component links on the main root untouched. It now compares the resulting objects map with the expected one. The four tests only inspected the first change, so a duplicated change went unnoticed. They now compare the full list of changes: an exact vector for the two repairs that rewrite the map, and id frequencies for the cycle repair, which emits one change per shape in no fixed order. The deleted-component fixture now removes the main instance through `tho/delete-shape`, the same change generator the editor uses, instead of a hand-written `:del-obj`. The message that promised a restorable map now says what the repair does: normalize the value to an empty map. AI-assisted-by: deepseek-v4.1-flash