mirror of
https://github.com/penpot/penpot.git
synced 2026-11-22 18:30:34 +00:00
Copy texts in files older than mid-2025 can hold :text-content-structure-same-attrs next to :text-content-structure, which marked a structure change of a text with one style. The text override migration recomputed the groups and dropped the structure flag but left this one in :touched, where nothing reads it, and validation did not report it. It is now one of the legacy text groups, so the migration and the :legacy-text-touched repair drop it too. Found in the copy A2 of the QA fixture text-components-propagation.penpot while re-running PENPOT-2261. convert-text-overrides-test: the flag goes with the structure flag and without it. repair-components-test/legacy-text-touched: a copy holding it is reported and repaired. AI-assisted-by: claude-opus-5-5
155 lines
7.4 KiB
Clojure
155 lines
7.4 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS SUBSIDIARY SL
|
|
|
|
(ns common-tests.files.convert-text-overrides-test
|
|
"The conversion of the text override groups of files older than the
|
|
feature components/text-overrides (`:text-content-attribute` and
|
|
`:text-content-structure`) to one group for the letters and one per
|
|
style. Texts are written in the notation of
|
|
`app.common.test-helpers.texts`."
|
|
(:require
|
|
[app.common.features :as cfeat]
|
|
[app.common.files.comp-processors :as cfcp]
|
|
[app.common.files.migrations :as fmg]
|
|
[app.common.test-helpers.components :as thc]
|
|
[app.common.test-helpers.files :as thf]
|
|
[app.common.test-helpers.ids-map :as thi]
|
|
[app.common.test-helpers.shapes :as ths]
|
|
[app.common.test-helpers.texts :as thtx]
|
|
[clojure.test :as t]))
|
|
|
|
(t/use-fixtures :each thi/test-fixture)
|
|
|
|
(def ^:private main [[["Price: "] ["$10" {:weight 700}]]])
|
|
|
|
(defn- old-copy
|
|
"A file whose copy text is written as `copy` and holds the old touched
|
|
groups `touched`."
|
|
[copy touched]
|
|
(-> (thf/sample-file :file1)
|
|
(thtx/add-text-component-with-copy main)
|
|
(ths/update-shape :copy-child :content (thtx/content copy))
|
|
(ths/update-shape :copy-child :touched touched)))
|
|
|
|
(defn- convert
|
|
([file] (convert file {}))
|
|
([file libraries]
|
|
(update file :data cfcp/convert-text-overrides libraries)))
|
|
|
|
(defn- touched
|
|
[file label]
|
|
(:touched (ths/get-shape file label)))
|
|
|
|
(t/deftest a-style-flag-becomes-the-styles-that-differ
|
|
(t/is (= #{:content-group :text-content-fills}
|
|
(-> (old-copy [[["Price: " {:color :red}] ["$10" {:weight 700 :color :red}]]]
|
|
#{:content-group :text-content-attribute})
|
|
(convert)
|
|
(touched :copy-child))))
|
|
(t/testing "letters that differ are not an override the old groups had"
|
|
(t/is (= #{:content-group :text-content-fills}
|
|
(-> (old-copy [[["Cost: " {:color :red}] ["$10" {:weight 700 :color :red}]]]
|
|
#{:content-group :text-content-attribute})
|
|
(convert)
|
|
(touched :copy-child))))))
|
|
|
|
(t/deftest a-structure-flag-becomes-the-letters-and-styles-that-differ
|
|
(t/is (= #{:content-group :text-content-text :text-content-weight}
|
|
(-> (old-copy [[["Price: " {:weight 700}] ["$10" {:weight 700}]] [["Ends Sunday"]]]
|
|
#{:content-group :text-content-structure})
|
|
(convert)
|
|
(touched :copy-child)))))
|
|
|
|
(t/deftest the-uniform-structure-flag-goes-with-the-others
|
|
;; older files mark a structure change of a uniform text with
|
|
;; `:text-content-structure-same-attrs` too
|
|
(t/is (= #{:content-group :text-content-text}
|
|
(-> (old-copy [[["Price:"] ["$10" {:weight 700}]]]
|
|
#{:content-group :text-content-structure :text-content-structure-same-attrs})
|
|
(convert)
|
|
(touched :copy-child))))
|
|
(t/testing "it goes without the structure flag as well"
|
|
(t/is (= #{:content-group :text-content-text}
|
|
(-> (old-copy [[["Price:"] ["$10" {:weight 700}]]]
|
|
#{:content-group :text-content-text :text-content-structure-same-attrs})
|
|
(convert)
|
|
(touched :copy-child))))))
|
|
|
|
(t/deftest an-old-flag-where-nothing-differs-sets-nothing
|
|
(t/is (= #{:fill-group}
|
|
(-> (old-copy main #{:content-group :text-content-attribute :fill-group})
|
|
(convert)
|
|
(touched :copy-child)))))
|
|
|
|
(t/deftest a-letters-flag-alone-stays
|
|
(let [file (old-copy [[["Price: "] ["$20" {:weight 700}]]] #{:content-group :text-content-text})]
|
|
(t/is (= (touched file :copy-child) (touched (convert file) :copy-child)))))
|
|
|
|
(t/deftest a-content-group-alone-becomes-the-letters-and-styles-that-differ
|
|
;; older files mark a copy text whose content changed with
|
|
;; `:content-group` alone
|
|
(t/is (= #{:content-group :text-content-text :text-content-fills}
|
|
(-> (old-copy [[["Cost: " {:color :red}] ["$10" {:weight 700 :color :red}]]]
|
|
#{:content-group})
|
|
(convert)
|
|
(touched :copy-child))))
|
|
(t/testing "where nothing differs it sets nothing"
|
|
(t/is (nil? (-> (old-copy main #{:content-group})
|
|
(convert)
|
|
(touched :copy-child)
|
|
(not-empty))))))
|
|
|
|
(defn- library-and-file
|
|
"A library with the text component :component1, and a file with a copy of
|
|
it whose text is red and holds the old style flag."
|
|
[]
|
|
(let [library (-> (thf/sample-file :library)
|
|
(thtx/add-text-component-with-copy main))
|
|
file (-> (thf/sample-file :file1)
|
|
(thc/instantiate-component :component1 :lib-copy
|
|
:library library
|
|
:children-labels [:lib-copy-text])
|
|
(ths/update-shape :lib-copy-text :content
|
|
(thtx/content [[["Price: " {:color :red}] ["$10" {:weight 700 :color :red}]]]))
|
|
(ths/update-shape :lib-copy-text :touched #{:content-group :text-content-attribute}))]
|
|
[library file]))
|
|
|
|
(t/deftest an-unreachable-near-main-keeps-every-group-the-old-flag-allowed
|
|
(let [[library file] (library-and-file)
|
|
all-styles #{:content-group :text-content-family :text-content-weight :text-content-size
|
|
:text-content-line-height :text-content-spacing :text-content-decoration
|
|
:text-content-case :text-content-fills :text-content-typography
|
|
:text-content-align :text-content-direction :text-content-valign}]
|
|
(t/is (= all-styles (touched (convert file) :lib-copy-text)))
|
|
(t/is (= #{:content-group :text-content-fills}
|
|
(touched (convert file {(:id library) library}) :lib-copy-text)))))
|
|
|
|
(t/deftest an-unreachable-near-main-can-be-left-for-later
|
|
(let [[library file] (library-and-file)
|
|
file' (binding [cfcp/*defer-unreachable* true]
|
|
(convert file))]
|
|
(t/is (= (touched file :lib-copy-text) (touched file' :lib-copy-text)))
|
|
(t/is (::cfcp/deferred-texts (meta (:data file'))))
|
|
(t/is (= #{:content-group :text-content-fills}
|
|
(touched (convert file' {(:id library) library}) :lib-copy-text)))))
|
|
|
|
(t/deftest migration-converts-and-adds-the-feature
|
|
(let [old (-> (old-copy [[["Price: " {:color :red}] ["$10" {:weight 700 :color :red}]]]
|
|
#{:content-group :text-content-attribute})
|
|
(update :features disj "components/text-overrides")
|
|
(assoc :migrations (disj fmg/available-migrations "0037-recompute-text-overrides")))
|
|
file (fmg/migrate-file old (delay {}))]
|
|
(t/is (contains? (:features file) "components/text-overrides"))
|
|
(t/is (contains? cfeat/default-features "components/text-overrides"))
|
|
(t/is (= #{:content-group :text-content-fills} (touched file :copy-child)))))
|
|
|
|
(t/deftest migration-converts-a-content-group-alone
|
|
(let [old (-> (old-copy [[["Cost: "] ["$10" {:weight 700}]]] #{:content-group})
|
|
(assoc :migrations (disj fmg/available-migrations "0038-recompute-content-group-alone")))
|
|
file (fmg/migrate-file old (delay {}))]
|
|
(t/is (= #{:content-group :text-content-text} (touched file :copy-child)))))
|
|
|