mirror of
https://github.com/penpot/penpot.git
synced 2026-11-18 16:12:24 +00:00
* 🐛 Show the error page for critical WASM errors Since #8651 the :wasm-error handler showed the error page for :panic only, so a :wasm-critical error (a WASM trap with no error code) fell through to a toast and the user kept working on a broken renderer. Only the codes in recoverable-wasm-codes now show a toast: :non-blocking from Rust, plus :wasm-reload-context-failure and :viewer-canvas-failed, raised by the frontend. Any other code shows the error page. This covers errors from the render loop, event handlers, promises and store events; errors thrown inside React effects still reach the error boundary. The h/call docstring now describes what it does: it always throws. Closes #12990 AI-assisted-by: claude-opus-5-5 * ✨ Add a guard for React effects that call WASM React sends any error thrown in an effect, or in its cleanup, to the error boundary at the app root, which replaces the whole workspace with the error page. That holds even for recoverable WASM errors, which should only show a toast. errors/wrap-wasm-effect runs an effect fn and the cleanup fn it returns. A recoverable WASM error goes to on-error (toast); any other error is rethrown, so it still reaches the boundary. The macro with-wasm-effect wraps mf/with-effect with it. The macro lives in its own namespace, app.main.ui.hooks.wasm-effect: app.main.ui.hooks cannot require app.main.errors, because the renderer loads it and that makes a circular dependency. AI-assisted-by: claude-opus-5-5 * 🐛 Show a toast for recoverable WASM errors in the viewport A recoverable WASM error thrown inside a viewport effect reached the React error boundary, which replaced the whole workspace with the error page. Every viewport effect that calls WASM in its body or cleanup now uses with-wasm-effect, so a recoverable error shows a toast and the workspace stays; panics and critical errors still show the error page. Effects that call WASM only from a listener, ts/asap or ts/raf keep mf/with-effect: those errors never reach React. AI-assisted-by: claude-opus-5-5 * 🐛 Show a toast for recoverable WASM errors in the text editor The WASM text editor calls WASM from two React effects: on mount (select all, render) and in the first caret blink. A recoverable error there reached the error boundary and replaced the workspace with the error page. Both effects now use with-wasm-effect. The mount effect also guards its select-all and render step on its own: it opens an undo transaction with no timeout first, and without that inner guard a recoverable error would stop the effect before it returned the cleanup that commits the transaction and disposes the WASM editor. AI-assisted-by: claude-opus-5-5