mirror of
https://github.com/penpot/penpot.git
synced 2026-09-19 02:16:14 +00:00
a56c3cb7ce
* 🐛 Pass the base branch and the project when opening a PR The create-pr skill resolves the target branch with scripts/detect-target-branch in step 1 and then never passes it, so gh opens the PR against the repository default. A branch cut from staging therefore targets develop. mem:workflow/creating-prs also requires --project "Main", which the skill's command omitted. Two checks were missing as well. A branch behind its base produces a verdict about a tree nobody will ship, because checks run against head merged into base. A draft PR runs no checks at all, since every test workflow is gated on the pull_request.draft flag, so the skill now asks before opening one and states that cost. Finally, the AI-assisted-by trailer belongs in the PR body: Penpot squash-merges, so the landed commit message comes from the PR title and body, and a trailer that lives only on branch commits disappears at merge. AI-assisted-by: claude-opus-5 Signed-off-by: Álvaro Tejero Cantero <alvorithm@teje.ro> * ♻️ Drop the behind-the-base check and fix the trailer note Review found both claims wrong. The behind-the-base check said the checks would report on a tree nobody ships, but every test workflow runs actions/checkout with no ref, so a pull_request event builds refs/pull/N/merge, which is head already merged into base. Being behind the base therefore changes nothing about the verdict, and the check only forced a rebase for no gain. The trailer note claimed a trailer on branch commits disappears at merge. It does not: GitHub's squash body lists the commit messages, and 91b433985a carries three AI-assisted-by lines from the two commits of #11677. The paragraph now asks for the trailer in the body as a courtesy to the reviewer, once per model, and says the commits keep theirs. AI-assisted-by: claude-opus-5 Signed-off-by: Álvaro Tejero Cantero <alvorithm@teje.ro> --------- Signed-off-by: Álvaro Tejero Cantero <alvorithm@teje.ro>