mirror of
https://github.com/penpot/penpot.git
synced 2026-11-17 07:30:35 +00:00
Migration 0158 created file_change with kind NOT NULL, which blocks any emergency rollback to the previous version: the old code inserts without kind and every save would fail. kind is still a reserve (reads use label IS NOT NULL), so it stays nullable until the rollback window closes; the NOT NULL comes in a later migration. The runbook keeps parity, the schema and migration tests cover the nullable column and the rollback insert, and the storage memory records the decision. AI-assisted-by: muse-spark-1.3-contributor
116 lines
5.3 KiB
Clojure
116 lines
5.3 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS INC Sucursal en España SL
|
|
|
|
(ns backend-tests.file-change-schema-test
|
|
(:require
|
|
[app.db :as db]
|
|
[backend-tests.helpers :as th]
|
|
[clojure.test :as t]))
|
|
|
|
(t/use-fixtures :once th/state-init)
|
|
(t/use-fixtures :each th/database-reset)
|
|
|
|
(defn- query
|
|
"Runs a query that returns a single value and returns it."
|
|
[sql & params]
|
|
(-> (db/exec! th/*pool* (into [sql] params))
|
|
first
|
|
(vals)
|
|
first))
|
|
|
|
(defn- partition-names
|
|
[]
|
|
(->> (db/exec! th/*pool* ["SELECT c.relname AS name
|
|
FROM pg_class c
|
|
JOIN pg_partition_tree('file_change') t ON t.relid = c.oid
|
|
WHERE t.isleaf
|
|
ORDER BY c.relname"])
|
|
(mapv :name)))
|
|
|
|
(t/deftest file-change-is-partitioned-in-sixteen-named-partitions
|
|
(t/is (= (mapv #(format "file_change_%02d" %) (range 16))
|
|
(partition-names))))
|
|
|
|
(t/deftest file-change-primary-key-is-file-id-and-id
|
|
(t/is (= "PRIMARY KEY (file_id, id)"
|
|
(query "SELECT pg_get_constraintdef(oid) AS def
|
|
FROM pg_constraint
|
|
WHERE conrelid = 'file_change'::regclass AND contype = 'p'"))))
|
|
|
|
(t/deftest file-change-has-three-foreign-keys-and-one-check
|
|
(t/is (= 3 (query "SELECT count(*) AS total
|
|
FROM pg_constraint
|
|
WHERE conrelid = 'file_change'::regclass AND contype = 'f'")))
|
|
(t/is (= 1 (query "SELECT count(*) AS total
|
|
FROM pg_constraint
|
|
WHERE conrelid = 'file_change'::regclass AND contype = 'c'")))
|
|
(t/is (re-find #"kind"
|
|
(query "SELECT pg_get_constraintdef(oid) AS def
|
|
FROM pg_constraint
|
|
WHERE conrelid = 'file_change'::regclass AND contype = 'c'"))))
|
|
|
|
(t/deftest file-change-has-the-six-canonical-indexes
|
|
(t/is (= ["file_change__deleted_at__idx"
|
|
"file_change__file_id__revn__idx"
|
|
"file_change__locked_by__idx"
|
|
"file_change__profile_id__idx"
|
|
"file_change__user_snapshots__idx"
|
|
"file_change_pkey"]
|
|
(->> (db/exec! th/*pool* ["SELECT indexname AS name
|
|
FROM pg_indexes
|
|
WHERE tablename = 'file_change'
|
|
AND schemaname = current_schema()
|
|
ORDER BY indexname"])
|
|
(mapv :name)))))
|
|
|
|
(t/deftest file-change-keeps-the-data-column-and-a-kind-column
|
|
;; The `data` column is kept: the `legacy-db` backend reads old payloads
|
|
;; from it (migration 0157 moved the existing blobs). The dead
|
|
;; `data_ref_id`/`data_backend` columns stay gone: no code read them since
|
|
;; the file storage refactor.
|
|
(t/is (= []
|
|
(->> (db/exec! th/*pool* ["SELECT attname AS name
|
|
FROM pg_attribute
|
|
WHERE attrelid = 'file_change'::regclass
|
|
AND attnum > 0 AND NOT attisdropped
|
|
AND attname IN ('data_ref_id', 'data_backend')"])
|
|
(mapv :name))))
|
|
(t/is (= ["bytea"]
|
|
(->> (db/exec! th/*pool* ["SELECT pg_catalog.format_type(atttypid, atttypmod) AS type
|
|
FROM pg_attribute
|
|
WHERE attrelid = 'file_change'::regclass
|
|
AND attname = 'data'"])
|
|
(mapv :type))))
|
|
;; Nullable on purpose: a rollback to the previous version inserts
|
|
;; without `kind` and has to keep writing (migration 0158).
|
|
(t/is (false? (query "SELECT attnotnull AS notnull
|
|
FROM pg_attribute
|
|
WHERE attrelid = 'file_change'::regclass
|
|
AND attname = 'kind'"))))
|
|
|
|
(t/deftest inserting-a-row-without-a-kind-succeeds
|
|
;; The column is nullable on purpose: the previous version inserts without
|
|
;; it, and a rollback to that version has to keep writing. The backfill of
|
|
;; a later NOT NULL migration turns these NULLs into 1/2.
|
|
(let [profile (th/create-profile* 1)
|
|
file (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)})]
|
|
(db/exec! th/*pool* ["INSERT INTO file_change (file_id, id)
|
|
VALUES (?, gen_random_uuid())"
|
|
(:id file)])
|
|
(t/is (nil? (query "SELECT kind AS k
|
|
FROM file_change
|
|
WHERE file_id = ?" (:id file))))))
|
|
|
|
(t/deftest inserting-a-row-with-an-unknown-kind-fails
|
|
(let [profile (th/create-profile* 1)
|
|
file (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)})]
|
|
(t/is (thrown? java.sql.SQLException
|
|
(db/exec! th/*pool* ["INSERT INTO file_change (file_id, id, kind)
|
|
VALUES (?, gen_random_uuid(), 3)"
|
|
(:id file)])))))
|