mirror of
https://github.com/penpot/penpot.git
synced 2026-08-20 03:38:52 +00:00
6d458c80a1
* 🐛 Fix dropdown shown Mixed Font Families for same family with different variant * 🐛 Fix variants dropdown appearing blank on mixed variants but same family * ✨ Add playwright test for mixed font families/variants
70 lines
2.8 KiB
JavaScript
70 lines
2.8 KiB
JavaScript
import { test, expect } from "@playwright/test";
|
|
import { WasmWorkspacePage } from "../pages/WasmWorkspacePage";
|
|
|
|
const FILE = {
|
|
id: "3b0d758a-8c9d-8013-8006-52c8337e5c72",
|
|
pageId: "3b0d758a-8c9d-8013-8006-52c8337e5c73",
|
|
};
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await WasmWorkspacePage.init(page);
|
|
// WASM_FLAGS already enables render-wasm; add the WASM text editor on top.
|
|
await WasmWorkspacePage.mockConfigFlags(page, ["enable-feature-text-editor-wasm"]);
|
|
});
|
|
|
|
async function openEditorAndSelectAll(workspace) {
|
|
await workspace.clickLeafLayer("this is a text");
|
|
// Enter edit mode (waits until the typography controls are ready) and then
|
|
// select every character so the sidebar reflects the combined styles of the
|
|
// whole text via the WASM editor path.
|
|
await workspace.textEditor.startEditing();
|
|
await workspace.page.keyboard.press("ControlOrMeta+a");
|
|
}
|
|
|
|
test.describe("BUG 10502 - Mixed families and variants", () => {
|
|
test("Multiple variants of the same font family", async ({
|
|
page,
|
|
}) => {
|
|
const workspace = new WasmWorkspacePage(page, { textEditor: true });
|
|
await workspace.setupEmptyFile();
|
|
await workspace.mockGetFile("text-editor/get-file-10502-mixed-variants.json");
|
|
|
|
await workspace.goToWorkspace(FILE);
|
|
await workspace.waitForFirstRender();
|
|
|
|
await openEditorAndSelectAll(workspace);
|
|
|
|
// The whole selection shares a single font family, so it must be shown even
|
|
// though the variants differ.
|
|
const fontFamily = workspace.rightSidebar.getByTitle("Font Family");
|
|
await expect(fontFamily).toContainText("Source Sans Pro");
|
|
|
|
// The variants differ across the selection, so the variant dropdown shows the
|
|
// "mixed" placeholder.
|
|
const fontVariant = workspace.rightSidebar
|
|
.getByTitle("Font Style")
|
|
.getByRole("combobox");
|
|
await expect(fontVariant).toHaveText("--");
|
|
});
|
|
|
|
test("Mixed font families appear as such in the dropdown", async ({ page }) => {
|
|
const workspace = new WasmWorkspacePage(page, { textEditor: true });
|
|
await workspace.setupEmptyFile();
|
|
await workspace.mockGetFile("text-editor/get-file-10502-mixed-families.json");
|
|
// Serve a stand-in TTF for Sora so the render doesn't wait on a real fetch.
|
|
// Glyphs are irrelevant here: the assertion only inspects the sidebar.
|
|
await workspace.mockGoogleFont("sora", "render-wasm/assets/ebgaramond.ttf");
|
|
|
|
await workspace.goToWorkspace(FILE);
|
|
await workspace.waitForFirstRender();
|
|
|
|
await openEditorAndSelectAll(workspace);
|
|
|
|
// The selection mixes two different font families (Source Sans Pro and Sora),
|
|
// so the font family dropdown reports it as mixed.
|
|
const fontFamily = workspace.rightSidebar.getByTitle("Font Family");
|
|
await expect(fontFamily).toContainText("Mixed Font Families");
|
|
});
|
|
});
|
|
|