mirror of
https://github.com/penpot/penpot.git
synced 2026-10-03 01:06:14 +00:00
b5fbc4fd8c
* ✨ Add size limits to profile props and plugin registry Bound the total serialized size of profile settings to 2 MiB (:profile-props-max-size), checked on the merged result before persisting, with a controlled :props-too-large error. Profiles that already exceed the limit can still shrink but cannot grow. Cap plugin registry entries in the shared schema (code 1 MiB, 50 plugins max, bounded name/host/description/icon) and restore rate limiting on the plugin RPCs (profile-mutations bucket, one write at a time per profile). The plugin manager now asks for confirmation before removal and ignores repeated clicks while a persist request is in flight. Closes #11592 AI-assisted-by: muse-spark-1.3-contributor * 🐛 Enforce plugin count cap, byte sizes and removal guard Enforce the declared 50-plugin cap in add-profile-plugin with a specific :too-many-plugins error (updates of existing entries still pass); the cap lives in a shared max-plugins constant. Measure profile props size in UTF-8 bytes instead of chars so multibyte content cannot slip past the limit. Cover install/remove persist logic with mocked-RPC frontend tests (release semantics, in-flight dedupe, validation vs rollback split) and add the missing boundary tests in common. Expose the in-flight persist set from the plugin registry and disable the remove button of entries being saved. Closes #11592 AI-assisted-by: muse-spark-1.3-contributor * 🐛 Fix rollback loops and restore paths in plugin registry Restore the previous plugin version instead of dropping the entry when a validation error rejects an update of an installed plugin. Make compensating writes one-shot with terminal callbacks so a persistent failure cannot ping-pong between install and remove. Restores keep the original list position; the unused public plugin-persisting? predicate is removed. Pin count-before-size precedence with a dedicated test and fix translation source refs to their canonical lines. Closes #11592 AI-assisted-by: muse-spark-1.3-contributor * 🐛 Guard notifications write and fix restore ordering Route update-profile-notifications through check-props-size! so oversized profiles cannot grow through that path; document the exempt system writers. Remove the duplicated stale entries in en.po, keeping the canonical translation refs. Restore rejected plugin updates at their original list position instead of leaving the optimistic move in place. Closes #11592 AI-assisted-by: muse-spark-1.3-contributor * 🐛 Skip no-op plugin removal and clarify size comments Return early from remove-profile-plugin when the id is absent: no wasted write, no size check, and no manufactured :plugins key that could spuriously fail on oversized profiles. Clarify that per-field string caps count chars while the byte budget is enforced by profile-props-max-size. Closes #11592 AI-assisted-by: muse-spark-1.3-contributor * 📎 Fix formatting in rlimit.edn for profile operations Signed-off-by: Andrey Antukh <niwi@niwi.nz> * 📎 Fix formatting of import-binfile/global entry Signed-off-by: Andrey Antukh <niwi@niwi.nz> * ♻️ Simplify props size check and tighten plugin entry caps Measure props with transit bytes directly instead of the PGobject string roundtrip. Rename check-props-size! to check-props-size: single hard limit on the merged props, no growth comparison, and return props so writers thread the check into the update. Move the 2 MiB default into default-props-max-size on the profile namespace, still overridable with the optional :profile-props-max-size config entry. Tighten registry-entry :code and :icon to 500 chars: they hold manifest paths, not content. Closes #11592 AI-assisted-by: muse-spark-1.3-contributor * 🐛 Fix compatibility problems --------- Signed-off-by: Andrey Antukh <niwi@niwi.nz> Co-authored-by: alonso.torres <alonso.torres@kaleidos.net>
323 lines
12 KiB
Clojure
323 lines
12 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS SUBSIDIARY SL
|
|
|
|
(ns frontend-tests.plugins.register-test
|
|
(:require
|
|
[app.main.repo :as rp]
|
|
[app.plugins.register :as preg]
|
|
[beicon.v2.core :as rx]
|
|
[cljs.test :as t :include-macros true]
|
|
[frontend-tests.helpers.mock :as mock]))
|
|
|
|
(defn- record-cmd-mock
|
|
"Mock rp/cmd! that records calls in mock/rpc-calls and answers
|
|
with (response-fn cmd params)."
|
|
[response-fn]
|
|
(mock/stub
|
|
(fn [cmd params]
|
|
(swap! mock/rpc-calls conj {:cmd cmd :params params})
|
|
(response-fn cmd params))))
|
|
|
|
(defn- cmds
|
|
[]
|
|
(mapv :cmd @mock/rpc-calls))
|
|
|
|
;; --- install-plugin! ---
|
|
|
|
(t/deftest install-success-releases-id
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock (fn [_ _] (rx/of {:ok true})))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-install-ok"}]
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin] (cmds)))
|
|
(t/is (= plugin (preg/get-plugin "reg-install-ok")))
|
|
;; id released: a second install issues a second RPC
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= 2 (count @mock/rpc-calls)))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest install-while-in-flight-issues-no-second-rpc
|
|
(t/async done
|
|
(let [subjects (atom [])]
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ _]
|
|
(let [sb (rx/subject)]
|
|
(swap! subjects conj sb)
|
|
sb)))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-install-dedupe"}]
|
|
(preg/install-plugin! plugin)
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= 1 (count @mock/rpc-calls)) "second install while in flight is skipped")
|
|
;; complete the pending call; the id is released afterwards
|
|
(rx/push! (first @subjects) {:ok true})
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= 2 (count @mock/rpc-calls)))
|
|
(done')))
|
|
done))))
|
|
|
|
(t/deftest install-validation-error-cleans-local-only
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ _] (rx/throw (ex-info "rejected" {:type :validation :code :props-too-large}))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-install-validation"}]
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= 1 (count @mock/rpc-calls)) "no rollback write after validation rejection")
|
|
(t/is (nil? (preg/get-plugin "reg-install-validation")))
|
|
;; id released: the next install retries the RPC
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= 2 (count @mock/rpc-calls)))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest install-validation-error-restores-previous-version
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ params]
|
|
(if (= "v2" (get-in params [:plugin :name]))
|
|
(rx/throw (ex-info "rejected" {:type :validation}))
|
|
(rx/of {:ok true}))))}
|
|
(fn [done']
|
|
(let [v1 {:plugin-id "reg-install-prev" :name "v1"}
|
|
v2 {:plugin-id "reg-install-prev" :name "v2"}]
|
|
(preg/install-plugin! v1)
|
|
(preg/install-plugin! v2)
|
|
(t/is (= 2 (count @mock/rpc-calls)))
|
|
(t/is (= v1 (preg/get-plugin "reg-install-prev"))
|
|
"the server-kept version is restored, not dropped")
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest install-validation-error-keeps-original-position
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ params]
|
|
(if (= "v2" (get-in params [:plugin :name]))
|
|
(rx/throw (ex-info "rejected" {:type :validation}))
|
|
(rx/of {:ok true}))))}
|
|
(fn [done']
|
|
(let [own #{"reg-pos-a" "reg-pos-b" "reg-pos-c"}
|
|
v1 {:plugin-id "reg-pos-b" :name "v1"}
|
|
v2 {:plugin-id "reg-pos-b" :name "v2"}]
|
|
(preg/install-plugin! {:plugin-id "reg-pos-a"})
|
|
(preg/install-plugin! v1)
|
|
(preg/install-plugin! {:plugin-id "reg-pos-c"})
|
|
(preg/install-plugin! v2)
|
|
;; installs prepend, so newest-first; the rejected update
|
|
;; must preserve order and restore v1
|
|
(t/is (= ["reg-pos-c" "reg-pos-b" "reg-pos-a"]
|
|
(filterv own (mapv :plugin-id (preg/plugins-list)))))
|
|
(t/is (= v1 (preg/get-plugin "reg-pos-b")))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest install-persistent-failure-terminates
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ _] (rx/throw (ex-info "boom" {:type :other}))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-install-hang"}]
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin :remove-profile-plugin] (cmds))
|
|
"one-shot rollback: no further calls")
|
|
(t/is (nil? (preg/get-plugin "reg-install-hang")))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest install-non-validation-error-rolls-back-via-rpc
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [cmd _]
|
|
(if (= cmd :add-profile-plugin)
|
|
(rx/throw (ex-info "boom" {:type :other}))
|
|
(rx/of nil))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-install-rollback"}]
|
|
(preg/install-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin :remove-profile-plugin] (cmds)))
|
|
(t/is (nil? (preg/get-plugin "reg-install-rollback")))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest install-non-validation-error-on-update-resaves-previous
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ params]
|
|
(if (= "v2" (get-in params [:plugin :name]))
|
|
(rx/throw (ex-info "busy" {:type :concurrency-limit}))
|
|
(rx/of {:ok true}))))}
|
|
(fn [done']
|
|
(let [own #{"reg-upd-a" "reg-upd-b" "reg-upd-c"}
|
|
v1 {:plugin-id "reg-upd-b" :name "v1"}
|
|
v2 {:plugin-id "reg-upd-b" :name "v2"}]
|
|
(preg/install-plugin! {:plugin-id "reg-upd-a"})
|
|
(preg/install-plugin! v1)
|
|
(preg/install-plugin! {:plugin-id "reg-upd-c"})
|
|
(reset! mock/rpc-calls [])
|
|
(preg/install-plugin! v2)
|
|
(t/is (= [:add-profile-plugin :add-profile-plugin] (cmds))
|
|
"the compensating write re-saves v1, never removes it")
|
|
(t/is (= v1 (get-in (second @mock/rpc-calls) [:params :plugin])))
|
|
(t/is (= v1 (preg/get-plugin "reg-upd-b")))
|
|
(t/is (= ["reg-upd-c" "reg-upd-b" "reg-upd-a"]
|
|
(filterv own (mapv :plugin-id (preg/plugins-list)))))
|
|
(done')))
|
|
done)))
|
|
|
|
;; --- remove-plugin! ---
|
|
|
|
(t/deftest remove-success-releases-id
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock (fn [_ _] (rx/of {:ok true})))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-remove-ok"}]
|
|
(preg/install-plugin! plugin)
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin :remove-profile-plugin] (cmds)))
|
|
(t/is (nil? (preg/get-plugin "reg-remove-ok")))
|
|
;; id released: a second remove issues another RPC
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= 3 (count @mock/rpc-calls)))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest remove-while-in-flight-issues-no-second-rpc
|
|
(t/async done
|
|
(let [subjects (atom [])]
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [cmd _]
|
|
(if (= cmd :add-profile-plugin)
|
|
(rx/of {:ok true})
|
|
(let [sb (rx/subject)]
|
|
(swap! subjects conj sb)
|
|
sb))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-remove-dedupe"}]
|
|
(preg/install-plugin! plugin)
|
|
(preg/remove-plugin! plugin)
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= 2 (count @mock/rpc-calls)) "second remove while in flight is skipped")
|
|
;; complete the pending call; the id is released afterwards
|
|
(rx/push! (first @subjects) nil)
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= 3 (count @mock/rpc-calls)))
|
|
(done')))
|
|
done))))
|
|
|
|
(t/deftest remove-validation-error-restores-local-only
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [cmd _]
|
|
(if (= cmd :add-profile-plugin)
|
|
(rx/of {:ok true})
|
|
(rx/throw (ex-info "rejected" {:type :validation})))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-remove-validation"}]
|
|
(preg/install-plugin! plugin)
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin :remove-profile-plugin] (cmds))
|
|
"no reinstall write after validation rejection")
|
|
(t/is (= plugin (preg/get-plugin "reg-remove-validation"))
|
|
"local entry is restored")
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest remove-non-validation-error-reinstalls-via-rpc
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [cmd _]
|
|
(if (= cmd :remove-profile-plugin)
|
|
(rx/throw (ex-info "boom" {:type :other}))
|
|
(rx/of {:ok true}))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-remove-rollback"}]
|
|
(preg/install-plugin! plugin)
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin :remove-profile-plugin :add-profile-plugin] (cmds)))
|
|
(t/is (= plugin (preg/get-plugin "reg-remove-rollback")))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest remove-persistent-failure-terminates
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [cmd _]
|
|
(if (= cmd :add-profile-plugin)
|
|
(rx/of {:ok true})
|
|
(rx/throw (ex-info "boom" {:type :other})))))}
|
|
(fn [done']
|
|
(let [plugin {:plugin-id "reg-remove-hang"}]
|
|
(preg/install-plugin! plugin)
|
|
(preg/remove-plugin! plugin)
|
|
(t/is (= [:add-profile-plugin :remove-profile-plugin :add-profile-plugin] (cmds))
|
|
"one-shot rollback: no further calls")
|
|
(t/is (= plugin (preg/get-plugin "reg-remove-hang")))
|
|
(done')))
|
|
done)))
|
|
|
|
(t/deftest remove-validation-error-keeps-original-position
|
|
(t/async done
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [cmd _]
|
|
(if (= cmd :add-profile-plugin)
|
|
(rx/of {:ok true})
|
|
(rx/throw (ex-info "rejected" {:type :validation})))))}
|
|
(fn [done']
|
|
(let [own #{"reg-idx-a" "reg-idx-b" "reg-idx-c"}
|
|
plugin {:plugin-id "reg-idx-b"}]
|
|
(preg/install-plugin! {:plugin-id "reg-idx-a"})
|
|
(preg/install-plugin! plugin)
|
|
(preg/install-plugin! {:plugin-id "reg-idx-c"})
|
|
(preg/remove-plugin! plugin)
|
|
;; installs prepend, so the order is newest-first;
|
|
;; the failed removal must preserve it exactly
|
|
(t/is (= ["reg-idx-c" "reg-idx-b" "reg-idx-a"]
|
|
(filterv own (mapv :plugin-id (preg/plugins-list)))))
|
|
(done')))
|
|
done)))
|
|
|
|
;; --- subscribe-registry! ---
|
|
|
|
(t/deftest registry-subscriber-sees-rollback
|
|
(t/async done
|
|
(let [subjects (atom [])
|
|
seen (atom [])
|
|
listener (fn [] (swap! seen conj (some? (preg/get-plugin "reg-watch"))))]
|
|
(mock/with-mocks
|
|
{rp/cmd! (record-cmd-mock
|
|
(fn [_ _]
|
|
(let [sb (rx/subject)]
|
|
(swap! subjects conj sb)
|
|
sb)))}
|
|
(fn [done']
|
|
(preg/subscribe-registry! listener)
|
|
(preg/install-plugin! {:plugin-id "reg-watch"})
|
|
(rx/error! (first @subjects) (ex-info "rejected" {:type :validation}))
|
|
(t/is (= [true false] @seen)
|
|
"notified on the optimistic add and on the rollback")
|
|
(preg/unsubscribe-registry! listener)
|
|
(preg/install-plugin! {:plugin-id "reg-watch"})
|
|
(t/is (= [true false] @seen) "no calls after unsubscribing")
|
|
(done'))
|
|
done))))
|