mirror of
https://github.com/penpot/penpot.git
synced 2026-11-12 13:00:37 +00:00
c39e3e8301
* ✨ Strictly validate uploads against file bytes on disk Sniff the real content type of every upload with simplemagic magic bytes instead of trusting the client-supplied mtype header. Declared types outside the allowlist keep the not-allowed code; allowed declarations whose bytes differ are rejected as mismatch. Covers SVG by probing its root tag over leading bytes (magic never matches XML text), TTF/OTF by magic name and WOFF/WOFF2 by four-cc. Read the real file size from disk instead of trusting the declared :size. Files over the limit are rejected even when the declared size lies downwards, and small files pass even when it lies upwards. Run the path check first everywhere so forged server paths keep the params-validation code. Recheck from-url downloads after the write, with a declared-only fast fail at header time. Thread the assembled path through font validation. Refresh the affected tests around real and sparse fixture files, including a PNG-as-font chunked-upload rejection case. Closes #12796 AI-assisted-by: muse-spark-1.3-contributor * 🐛 Accept BOM-prefixed SVG uploads and cover WOFF/WOFF2/OTF/WEBP Address review comments on #12801: - SVG files saved with a UTF-8 BOM were rejected as :media-type-mismatch: read-head kept U+FEFF and the <svg probe never ran. A leading BOM is now stripped before the probe, and a generic XML sniff (application/xml, text/xml) is treated as "no magic evidence" for declared image/svg+xml, so the root-tag probe decides whether the file opens with an <svg root. - sniff-match?/svg-file? docstrings claimed the magic database never matches SVG; simplemagic 1.17 does match an SVG with an XML prolog as image/svg+xml. Reworded to match reality. - Added matching-pass tests for WOFF, WOFF2, OTF and WEBP (they hit the read-four-cc, magic-name and direct magic branches) and three BOM SVG regression cases. AI-assisted-by: inkling-2-small-free
753 lines
31 KiB
Clojure
753 lines
31 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS SUBSIDIARY SL
|
|
|
|
(ns backend-tests.rpc-management-test
|
|
(:require
|
|
[app.binfile.common :as bfc]
|
|
[app.common.features :as cfeat]
|
|
[app.common.pprint :as pp]
|
|
[app.common.time :as ct]
|
|
[app.common.types.shape :as cts]
|
|
[app.common.uuid :as uuid]
|
|
[app.config :as cf]
|
|
[app.db :as db]
|
|
[app.http :as http]
|
|
[app.rpc :as-alias rpc]
|
|
[app.storage :as sto]
|
|
[backend-tests.helpers :as th]
|
|
[backend-tests.storage-test :refer [configure-storage-backend]]
|
|
[buddy.core.bytes :as b]
|
|
[clojure.test :as t]
|
|
[cuerdas.core :as str]
|
|
[datoteka.fs :as fs]
|
|
[datoteka.io :as io]
|
|
[mockery.core :refer [with-mocks]]))
|
|
|
|
(t/use-fixtures :once th/state-init)
|
|
(t/use-fixtures :each th/database-reset)
|
|
|
|
(defn- update-file!
|
|
[& {:keys [profile-id file-id changes revn] :or {revn 0}}]
|
|
(let [params {::th/type :update-file
|
|
::rpc/profile-id profile-id
|
|
:id file-id
|
|
:session-id (uuid/random)
|
|
:revn revn
|
|
:vern 0
|
|
:features cfeat/supported-features
|
|
:changes changes}
|
|
out (th/command! params)]
|
|
;; (th/print-result! out)
|
|
(t/is (nil? (:error out)))
|
|
(:result out)))
|
|
|
|
(t/deftest upload-tempfile-returns-fresh-object-for-same-content
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
path (th/tempfile "backend_tests/test_files/sample.png")
|
|
params {::th/type :upload-tempfile
|
|
::rpc/profile-id (:id profile)
|
|
:content {:filename "export.png"
|
|
:path path
|
|
:mtype "image/png"
|
|
:size (fs/size path)}}
|
|
config (assoc cf/config :public-uri "https://example.com/penpot")
|
|
out1 (binding [cf/config config]
|
|
(th/multipart-management-command! params))
|
|
out2 (binding [cf/config config]
|
|
(th/multipart-management-command! params))]
|
|
(t/is (nil? (:error out1)))
|
|
(t/is (nil? (:error out2)))
|
|
(t/is (str/starts-with? (str (get-in out1 [:result :uri]))
|
|
"https://example.com/penpot/assets/by-id/"))
|
|
(t/is (not= (get-in out1 [:result :id])
|
|
(get-in out2 [:result :id])))))
|
|
|
|
(t/deftest upload-tempfile-rejects-html-content-type
|
|
;; N2-13: upload-tempfile must reject non-allowed content types
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
path (fs/create-tempfile :dir "/tmp/penpot" :prefix "test-upload-tempfile-")
|
|
_ (io/write* path "<script>alert(1)</script>")
|
|
params {::th/type :upload-tempfile
|
|
::rpc/profile-id (:id profile)
|
|
:content {:filename "evil.html"
|
|
:path path
|
|
:mtype "text/html"
|
|
:size 27}}
|
|
out (th/multipart-management-command! params)]
|
|
(t/is (some? (:error out)))
|
|
(t/is (= :validation (th/ex-type (:error out))))
|
|
(t/is (= :media-type-not-allowed (th/ex-code (:error out))))))
|
|
|
|
(t/deftest upload-tempfile-rejects-a-key-it-does-not-declare
|
|
(let [out (th/management-command! {::th/type :upload-tempfile
|
|
::rpc/auth-key-id :nexus})]
|
|
(t/is (some? (:error out)))
|
|
(t/is (= :authorization (th/ex-type (:error out))))
|
|
(t/is (= :shared-key-not-allowed (th/ex-code (:error out))))))
|
|
|
|
(t/deftest upload-tempfile-accepts-both-declared-keys
|
|
(let [profile (th/create-profile* 1 {:is-active true})]
|
|
(doseq [key-id [:exporter :media-processor]]
|
|
(let [path (th/tempfile "backend_tests/test_files/sample.png")
|
|
out (th/multipart-management-command!
|
|
{::th/type :upload-tempfile
|
|
::rpc/auth-key-id key-id
|
|
::rpc/profile-id (:id profile)
|
|
:content {:filename "export.png"
|
|
:path path
|
|
:mtype "image/png"
|
|
:size (fs/size path)}})]
|
|
(t/is (nil? (:error out)) (name key-id))))))
|
|
|
|
(t/deftest duplicate-file
|
|
(let [storage (-> (:app.storage/storage th/*system*)
|
|
(configure-storage-backend))
|
|
|
|
sobject (sto/put-object! storage {::sto/content (sto/content "content")
|
|
:content-type "text/plain"})
|
|
profile (th/create-profile* 1 {:is-active true})
|
|
project (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:is-shared true})
|
|
|
|
libl (th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
|
|
mobj (th/create-file-media-object* {:file-id (:id file1)
|
|
:is-local false
|
|
:media-id (:id sobject)})]
|
|
(update-file!
|
|
:file-id (:id file1)
|
|
:profile-id (:id profile)
|
|
:revn 0
|
|
:vern 0
|
|
:changes
|
|
[{:type :add-media
|
|
:object mobj}])
|
|
|
|
(let [data {::th/type :duplicate-file
|
|
::rpc/profile-id (:id profile)
|
|
:file-id (:id file1)
|
|
:name "file 1 (copy)"}
|
|
out (th/command! data)]
|
|
|
|
;; (th/print-result! out)
|
|
|
|
;; Check that result is correct
|
|
(t/is (nil? (:error out)))
|
|
(let [result (:result out)]
|
|
;; Check that the returned result is a file but has different id
|
|
;; and different name.
|
|
(t/is (= "file 1 (copy)" (:name result)))
|
|
(t/is (not= (:id file1) (:id result)))
|
|
|
|
;; Check that the new file has a correct file library relation
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id result)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:id file2) (:library-file-id item))))
|
|
|
|
;; Check that the new file has a correct file media objects
|
|
(let [[item :as rows] (th/db-query :file-media-object {:file-id (:id result)})]
|
|
(t/is (= 1 (count rows)))
|
|
|
|
;; Check that both items have different ids
|
|
(t/is (not= (:id item) (:id mobj)))
|
|
|
|
;; check that both file-media-objects points to the same storage object.
|
|
(t/is (= (:media-id item) (:media-id mobj)))
|
|
(t/is (= (:media-id item) (:id sobject)))
|
|
|
|
;; The response carries the file metadata only
|
|
(t/is (not (contains? result :data))))
|
|
|
|
;; Check the total number of files
|
|
(let [rows (th/db-query :file {:project-id (:id project)})]
|
|
(t/is (= 3 (count rows))))))))
|
|
|
|
(t/deftest duplicate-file-with-deleted-relations
|
|
(let [storage (-> (:app.storage/storage th/*system*)
|
|
(configure-storage-backend))
|
|
sobject (sto/put-object! storage {::sto/content (sto/content "content")
|
|
:content-type "text/plain"})
|
|
profile (th/create-profile* 1 {:is-active true})
|
|
|
|
project (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:is-shared true})
|
|
|
|
libl (th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
|
|
mobj (th/create-file-media-object* {:file-id (:id file1)
|
|
:is-local false
|
|
:media-id (:id sobject)})]
|
|
|
|
(th/mark-file-deleted* {:id (:id file2)})
|
|
(sto/del-object! storage (:id sobject))
|
|
|
|
(let [data {::th/type :duplicate-file
|
|
::rpc/profile-id (:id profile)
|
|
:file-id (:id file1)
|
|
:name "file 1 (copy)"}
|
|
out (th/command! data)]
|
|
|
|
;; (th/print-result! out)
|
|
|
|
;; Check that result is correct
|
|
(t/is (nil? (:error out)))
|
|
(let [result (:result out)]
|
|
|
|
;; Check that the returned result is a file but has different id
|
|
;; and different name.
|
|
(t/is (= "file 1 (copy)" (:name result)))
|
|
(t/is (not= (:id file1) (:id result)))
|
|
|
|
;; Check that there are no relation to a deleted library
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id result)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; Check that the new file has no media objects
|
|
(let [[item :as rows] (th/db-query :file-media-object {:file-id (:id result)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; Check the total number of files
|
|
(let [rows (th/db-query :file {:project-id (:id project)})]
|
|
(t/is (= 3 (count rows))))))))
|
|
|
|
(t/deftest duplicate-project
|
|
(let [storage (-> (:app.storage/storage th/*system*)
|
|
(configure-storage-backend))
|
|
|
|
sobject (sto/put-object! storage {::sto/content (sto/content "content")
|
|
:content-type "text/plain"})
|
|
|
|
profile (th/create-profile* 1 {:is-active true})
|
|
project (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:is-shared true})
|
|
|
|
libl (th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
mobj (th/create-file-media-object* {:file-id (:id file1)
|
|
:is-local false
|
|
:media-id (:id sobject)})]
|
|
|
|
(update-file!
|
|
:file-id (:id file1)
|
|
:profile-id (:id profile)
|
|
:revn 0
|
|
:vern 0
|
|
:changes
|
|
[{:type :add-media
|
|
:object mobj}])
|
|
|
|
(let [data {::th/type :duplicate-project
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:name "project 1 (copy)"}
|
|
out (th/command! data)]
|
|
|
|
;; Check that result is correct
|
|
(t/is (nil? (:error out)))
|
|
|
|
(let [result (:result out)]
|
|
;; Check that they are the same project but different id and name
|
|
(t/is (= "project 1 (copy)" (:name result)))
|
|
(t/is (not= (:id project) (:id result)))
|
|
|
|
;; Check the total number of projects (previously is 2, now is 3)
|
|
(let [rows (th/db-query :project {:team-id (:default-team-id profile)})]
|
|
(t/is (= 3 (count rows))))
|
|
|
|
;; Check that the new project has the same files
|
|
(let [p1-files (th/db-query :file
|
|
{:project-id (:id project)}
|
|
{:order-by [:name]})
|
|
p2-files (th/db-query :file
|
|
{:project-id (:id result)}
|
|
{:order-by [:name]})]
|
|
(t/is (= (count p1-files)
|
|
(count p2-files)))
|
|
|
|
;; check that the both files are equivalent
|
|
(doseq [[fa fb] (map vector p1-files p2-files)]
|
|
(t/is (not= (:id fa) (:id fb)))
|
|
(t/is (= (:name fa) (:name fb)))))))))
|
|
|
|
(t/deftest duplicate-project-with-deleted-files
|
|
(let [storage (-> (:app.storage/storage th/*system*)
|
|
(configure-storage-backend))
|
|
sobject (sto/put-object! storage {::sto/content (sto/content "content")
|
|
:content-type "text/plain"})
|
|
profile (th/create-profile* 1 {:is-active true})
|
|
project (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:is-shared true})
|
|
|
|
libl (th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
mobj (th/create-file-media-object* {:file-id (:id file1)
|
|
:is-local false
|
|
:media-id (:id sobject)})]
|
|
|
|
(th/mark-file-deleted* {:id (:id file1)})
|
|
|
|
(let [data {::th/type :duplicate-project
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:name "project 1 (copy)"}
|
|
out (th/command! data)]
|
|
|
|
;; Check that result is correct
|
|
(t/is (nil? (:error out)))
|
|
|
|
(let [result (:result out)]
|
|
;; Check that they are the same project but different id and name
|
|
(t/is (= "project 1 (copy)" (:name result)))
|
|
(t/is (not= (:id project) (:id result)))
|
|
|
|
;; Check the total number of projects (previously is 2, now is 3)
|
|
(let [rows (th/db-query :project {:team-id (:default-team-id profile)})]
|
|
(t/is (= 3 (count rows))))
|
|
|
|
;; Check that the new project has only the second file
|
|
(let [p1-files (th/db-query :file
|
|
{:project-id (:id project)}
|
|
{:order-by [:name]})
|
|
p2-files (th/db-query :file
|
|
{:project-id (:id result)}
|
|
{:order-by [:name]})]
|
|
(t/is (= (count (rest p1-files))
|
|
(count p2-files)))
|
|
|
|
;; check that the both files are equivalent
|
|
(doseq [[fa fb] (map vector (rest p1-files) p2-files)]
|
|
(t/is (not= (:id fa) (:id fb)))
|
|
(t/is (= (:name fa) (:name fb)))))))))
|
|
|
|
(t/deftest move-file-on-same-team
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
team (th/create-team* 1 {:profile-id (:id profile)})
|
|
|
|
project1 (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
project2 (th/create-project* 2 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project1)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:is-shared true})]
|
|
|
|
(th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
|
|
;; Try to move to same project
|
|
(let [data {::th/type :move-files
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:ids #{(:id file1)}}
|
|
|
|
out (th/command! data)
|
|
error (:error out)]
|
|
(t/is (th/ex-info? error))
|
|
(t/is (th/ex-of-type? error :validation))
|
|
(t/is (th/ex-of-code? error :cant-move-to-same-project)))
|
|
|
|
;; initially project1 should have 2 files
|
|
(let [rows (th/db-query :file {:project-id (:id project1)})]
|
|
(t/is (= 2 (count rows))))
|
|
|
|
;; initially project2 should be empty
|
|
(let [rows (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; move a file1 to project2 (in the same team)
|
|
(let [data {::th/type :move-files
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project2)
|
|
:ids #{(:id file1)}}
|
|
|
|
out (th/command! data)]
|
|
|
|
(t/is (nil? (:error out)))
|
|
(t/is (nil? (:result out)))
|
|
|
|
;; project1 now should contain 1 file
|
|
(let [rows (th/db-query :file {:project-id (:id project1)})]
|
|
(t/is (= 1 (count rows))))
|
|
|
|
;; project2 now should contain 1 file
|
|
(let [rows (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 1 (count rows))))
|
|
|
|
;; file1 should be still linked to file2
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id file1)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:file-id item) (:id file1)))
|
|
(t/is (= (:library-file-id item) (:id file2))))
|
|
|
|
;; should be no libraries on file2
|
|
(let [rows (th/db-query :file-library-rel {:file-id (:id file2)})]
|
|
(t/is (= 0 (count rows)))))))
|
|
|
|
|
|
;; TODO: move a library to other team
|
|
(t/deftest move-file-to-other-team
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
team (th/create-team* 1 {:profile-id (:id profile)})
|
|
|
|
project1 (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
project2 (th/create-project* 2 {:team-id (:id team)
|
|
:profile-id (:id profile)})
|
|
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project1)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:is-shared true})
|
|
file3 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:is-shared true})]
|
|
|
|
(th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
|
|
(th/link-file-to-library* {:file-id (:id file2)
|
|
:library-id (:id file3)})
|
|
|
|
;; --- initial data checks
|
|
|
|
;; the project1 should have 3 files
|
|
(let [rows (th/db-query :file {:project-id (:id project1)})]
|
|
(t/is (= 3 (count rows))))
|
|
|
|
;; should be no files on project2
|
|
(let [rows (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; the file1 should be linked to file2
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id file1)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:file-id item) (:id file1)))
|
|
(t/is (= (:library-file-id item) (:id file2))))
|
|
|
|
;; the file2 should be linked to file3
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id file2)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:file-id item) (:id file2)))
|
|
(t/is (= (:library-file-id item) (:id file3))))
|
|
|
|
;; should be no libraries on file3
|
|
(let [rows (th/db-query :file-library-rel {:file-id (:id file3)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; move to other project in other team
|
|
(let [data {::th/type :move-files
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project2)
|
|
:ids #{(:id file1)}}
|
|
out (th/command! data)]
|
|
|
|
(t/is (nil? (:error out)))
|
|
(t/is (nil? (:result out)))
|
|
|
|
;; project1 now should have 2 file
|
|
(let [[item1 item2 :as rows] (th/db-query :file {:project-id (:id project1)}
|
|
{:order-by [:created-at]})]
|
|
;; (clojure.pprint/pprint rows)
|
|
(t/is (= 2 (count rows)))
|
|
(t/is (= (:id item1) (:id file2))))
|
|
|
|
;; project2 now should have 1 file
|
|
(let [[item :as rows] (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:id item) (:id file1))))
|
|
|
|
;; the moved file1 should not have any link to libraries
|
|
(let [rows (th/db-query :file-library-rel {:file-id (:id file1)})]
|
|
(t/is (zero? (count rows))))
|
|
|
|
;; the file2 should still be linked to file3
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id file2)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:file-id item) (:id file2)))
|
|
(t/is (= (:library-file-id item) (:id file3)))))))
|
|
|
|
|
|
(t/deftest move-library-to-other-team
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
team (th/create-team* 1 {:profile-id (:id profile)})
|
|
|
|
project1 (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
project2 (th/create-project* 2 {:team-id (:id team)
|
|
:profile-id (:id profile)})
|
|
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project1)})
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:is-shared true})]
|
|
|
|
(th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
|
|
;; --- initial data checks
|
|
|
|
;; the project1 should have 2 files
|
|
(let [rows (th/db-query :file {:project-id (:id project1)})]
|
|
(t/is (= 2 (count rows))))
|
|
|
|
;; should be no files on project2
|
|
(let [rows (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; the file1 should be linked to file2
|
|
(let [[item :as rows] (th/db-query :file-library-rel {:file-id (:id file1)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:file-id item) (:id file1)))
|
|
(t/is (= (:library-file-id item) (:id file2))))
|
|
|
|
;; should be no libraries on file2
|
|
(let [rows (th/db-query :file-library-rel {:file-id (:id file2)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; move the library to other project
|
|
(let [data {::th/type :move-files
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project2)
|
|
:ids #{(:id file2)}}
|
|
out (th/command! data)]
|
|
|
|
(t/is (nil? (:error out)))
|
|
(t/is (nil? (:result out)))
|
|
|
|
;; project1 now should have 1 file
|
|
(let [[item :as rows] (th/db-query :file {:project-id (:id project1)}
|
|
{:order-by [:created-at]})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:id item) (:id file1))))
|
|
|
|
;; project2 now should have 1 file
|
|
(let [[item :as rows] (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:id item) (:id file2))))
|
|
|
|
;; the file1 should not have any link to libraries
|
|
(let [rows (th/db-query :file-library-rel {:file-id (:id file1)})]
|
|
(t/is (zero? (count rows))))
|
|
|
|
;; the file2 should not have any link to libraries
|
|
(let [rows (th/db-query :file-library-rel {:file-id (:id file2)})]
|
|
(t/is (zero? (count rows)))))))
|
|
|
|
(t/deftest move-project
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
team (th/create-team* 1 {:profile-id (:id profile)})
|
|
|
|
project1 (th/create-project* 1 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
project2 (th/create-project* 2 {:team-id (:default-team-id profile)
|
|
:profile-id (:id profile)})
|
|
|
|
file1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:id project1)})
|
|
|
|
file2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:is-shared true})
|
|
|
|
file3 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:id project2)
|
|
:is-shared true})]
|
|
|
|
(th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file2)})
|
|
|
|
(th/link-file-to-library* {:file-id (:id file1)
|
|
:library-id (:id file3)})
|
|
|
|
;; --- initial data checks
|
|
|
|
;; the project1 should have 2 files
|
|
(let [rows (th/db-query :file {:project-id (:id project1)})]
|
|
(t/is (= 2 (count rows))))
|
|
|
|
;; the project2 should have 1 file
|
|
(let [rows (th/db-query :file {:project-id (:id project2)})]
|
|
(t/is (= 1 (count rows))))
|
|
|
|
;; the file1 should be linked to file2 and file3
|
|
(let [[item1 item2 :as rows] (th/db-query :file-library-rel
|
|
{:file-id (:id file1)}
|
|
{:order-by [:created-at]})]
|
|
(t/is (= 2 (count rows)))
|
|
(t/is (= (:file-id item1) (:id file1)))
|
|
(t/is (= (:library-file-id item1) (:id file2)))
|
|
(t/is (= (:file-id item2) (:id file1)))
|
|
(t/is (= (:library-file-id item2) (:id file3))))
|
|
|
|
;; the file2 should not be linked to any file
|
|
(let [[rows] (th/db-query :file-library-rel {:file-id (:id file2)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; the file3 should not be linked to any file
|
|
(let [[rows] (th/db-query :file-library-rel {:file-id (:id file3)})]
|
|
(t/is (= 0 (count rows))))
|
|
|
|
;; move project1 to other team
|
|
(let [data {::th/type :move-project
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project1)
|
|
:team-id (:id team)}
|
|
out (th/command! data)]
|
|
|
|
(t/is (nil? (:error out)))
|
|
(t/is (nil? (:result out)))
|
|
|
|
;; project1 now should still have 2 files
|
|
(let [[item1 item2 :as rows] (th/db-query :file
|
|
{:project-id (:id project1)}
|
|
{:order-by [:created-at]})]
|
|
;; (clojure.pprint/pprint rows)
|
|
(t/is (= 2 (count rows)))
|
|
(t/is (= (:id item1) (:id file1)))
|
|
(t/is (= (:id item2) (:id file2))))
|
|
|
|
;; project2 now should still have 1 file
|
|
(let [[item :as rows] (th/db-query :file {:project-id (:id project2)})]
|
|
;; (pp/pprint rows)
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:id item) (:id file3))))
|
|
|
|
;; the file1 should be linked to file2 but not file3
|
|
(let [[item1 :as rows] (th/db-query :file-library-rel
|
|
{:file-id (:id file1)}
|
|
{:order-by [:created-at]})]
|
|
|
|
(t/is (= 1 (count rows)))
|
|
(t/is (= (:file-id item1) (:id file1)))
|
|
(t/is (= (:library-file-id item1) (:id file2)))))))
|
|
|
|
(t/deftest clone-template
|
|
(let [prof (th/create-profile* 1 {:is-active true})
|
|
data {::th/type :clone-template
|
|
::rpc/profile-id (:id prof)
|
|
:project-id (:default-project-id prof)
|
|
:template-id "test"}
|
|
|
|
out (th/command! data)]
|
|
;; (th/print-result! out)
|
|
|
|
(t/is (nil? (:error out)))
|
|
(let [result (:result out)]
|
|
(t/is (fn? result))
|
|
|
|
(let [events (th/consume-sse result)]
|
|
(t/is (= 5 (count events)))
|
|
(t/is (= :end (first (last events))))))))
|
|
|
|
(t/deftest get-list-of-buitin-templates
|
|
(let [prof (th/create-profile* 1 {:is-active true})
|
|
data {::th/type :get-builtin-templates
|
|
::rpc/profile-id (:id prof)}
|
|
out (th/command! data)]
|
|
;; (th/print-result! out)
|
|
(t/is (nil? (:error out)))
|
|
(let [result (:result out)]
|
|
(t/is (vector? result))
|
|
(t/is (= 1 (count result)))
|
|
(t/is (= "test" (:id (first result)))))))
|
|
|
|
(t/deftest clone-template-audit-events-carry-team-id
|
|
;; The per-file `create-file` events are built by hand, so they do not pass
|
|
;; through the generic resolver: the command must copy the team id itself.
|
|
(with-mocks [audit-mock {:target 'app.loggers.audit/submit :return nil}]
|
|
(with-redefs [cf/flags (conj cf/flags :audit-log)]
|
|
(let [prof (th/create-profile* 1 {:is-active true})
|
|
team (th/create-team* 1 {:profile-id (:id prof)})
|
|
project (th/create-project* 1 {:profile-id (:id prof)
|
|
:team-id (:id team)})
|
|
out (th/command! {::th/type :clone-template
|
|
::rpc/profile-id (:id prof)
|
|
:project-id (:id project)
|
|
:template-id "test"})]
|
|
(t/is (th/success? out))
|
|
(th/consume-sse (:result out))
|
|
(let [events (->> (:call-args-list @audit-mock)
|
|
(map second)
|
|
(filter #(= "create-file" (:name %))))]
|
|
(t/is (seq events))
|
|
(t/is (every? #(= (:id team) (get-in % [:props :team-id])) events)))))))
|
|
|
|
(t/deftest duplicate-project-audit-events-carry-entity-ids
|
|
;; The duplicated project and files are created by internal calls, so the
|
|
;; command emits one create event per entity for a local projection.
|
|
(with-mocks [audit-mock {:target 'app.loggers.audit/submit :return nil}]
|
|
(with-redefs [cf/flags (conj cf/flags :audit-log)]
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
team (th/create-team* 52 {:profile-id (:id profile)})
|
|
project (th/create-project* 52 {:profile-id (:id profile)
|
|
:team-id (:id team)})
|
|
_file (th/create-file* 52 {:profile-id (:id profile)
|
|
:project-id (:id project)})
|
|
out (th/command! {::th/type :duplicate-project
|
|
::rpc/profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:name "copy"})
|
|
events (->> (:call-args-list @audit-mock)
|
|
(map second)
|
|
(filter #(contains? #{"create-project" "create-file"} (:name %))))]
|
|
(t/is (th/success? out))
|
|
(t/is (some #(and (= "create-project" (:name %))
|
|
(= (get-in out [:result :id]) (get-in % [:props :id]))
|
|
(= (:id team) (get-in % [:props :team-id]))
|
|
(= "copy" (get-in % [:props :name])))
|
|
events))
|
|
(t/is (some #(and (= "create-file" (:name %))
|
|
(string? (get-in % [:props :name]))
|
|
(int? (get-in % [:props :revn]))
|
|
(ct/inst? (get-in % [:props :modified-at])))
|
|
events))
|
|
(t/is (every? #(= (:id team) (get-in % [:props :team-id])) events))))))
|
|
|
|
(t/deftest upload-tempfile-rejects-forged-content
|
|
;; Same transit-forgery vector through the management API: without a
|
|
;; multipart request the wrapper must reject it at params validation.
|
|
(let [profile (th/create-profile* 1 {:is-active true})
|
|
params {::th/type :upload-tempfile
|
|
::rpc/profile-id (:id profile)
|
|
:content {:filename "evil.png"
|
|
:path (fs/path "/etc/passwd")
|
|
:mtype "image/png"
|
|
:size 123}}
|
|
out (th/management-command! params)]
|
|
(t/is (th/ex-of-code? (:error out) :params-validation))))
|