alonso.torres a64ea2121c ✨ Generate group, mask, bool and path edits inside mains
The random histories never changed the structure of the shapes a main
holds. The shape structure programs add a structure edit on a shape a
main holds, and its next sibling: group, mask, unmask, combine into a
bool of each type, or convert to a path, through the changes of
app.common.logic.groups and app.common.logic.bool the workspace events
commit, and the frontend's path conversion without the WASM renderer.
Ungrouping, and grouping that takes every child out of a group, stay out
until copies follow the removal of a shape their main holds.

The oracle and the model learn the shapes these edits make:
- bools and paths keep their bounds in their selrect only, which the
  geometry checks read when a shape has no box of its own;
- path segments compare within the geometry tolerance, and the design
  snapshot leaves out a bool's segments, which it computes from its
  children in an order that depends on how it was computed;
- children of groups and bools measure from, and anchor authored places
  to, the board around them, as a group's bounds come from its children;
- differing flip flags count only when the ordered corners differ too;
- undo and redo compare geometry within 1e-10, and bool and path
  geometry within 1e-4, as a group computes its geometry again from its
  children and a path stores its segments in single precision.
Transforms of copy shapes inside groups and bools stay out until the
oracle places them.

Test: random-shape-structure-compositions.
Focused only; the full common suite runs at the end of this series.

Harness only; the benchmark is not run.

Also in this commit:

- Count differing flip flags unless they decompose the same corners. The shape
  structure gates ignored differing flip flags whenever the ordered corners
  matched, so a shape whose flags disagree with its own transform passed as well
  (both-flags-and-a-half-turn-equal-neither). Flags count now unless the corners
  match and the shape's flags and rotation decompose its transform, so they
  store the same transform otherwise.
- Resize the groups around a shape the harness transforms. The frontend's
  transform resizes the groups around the shapes it changes (reg-objects,
  pcb/resize-parents); the harness transform did not, so a main's group kept the
  bounds of a child it moved while sync gave its copies' groups bounds from
  their children, and the oracle found them apart. The harness transform resizes
  the parents too.
- Reflow layouts only after the structure edits whose events do. The structure
  node reflowed the layouts of the parents after every edit, but the workspace
  events update layouts only after grouping, masking and ungrouping; unmasking,
  creating a bool and converting to a path do not. The extra reflow left an undo
  that did not give back the place of the children of a mask unmasked in a flex
  main. The node reflows as the events do.
- Compare the corners of a bool in any order. A bool computes its points from
  its segments, so their order follows the path, not the transform: a flipped
  main gave its copies' bools the same corners in another order, which the
  geometry check and the design snapshot read as another place. Both compare a
  bool's corners in a sorted order.
- Check only the first corner of a place whose size a layout gives. The model
  checks an authored place by the corners of the shape placed in its parent, but
  leaves out the dimensions a layout gives it. A moved copy whose main came to
  hug its grid took the hugged width from its layout and kept its first corner,
  yet the corner check compared all four corners with the authored width. With a
  size the layout gives, only the first corner is checked, which a layout resize
  keeps.
- Sort the corners of a bool by their rounded position. Sorting a bool's corners
  by their raw coordinates swapped two corners whose x differed only by noise,
  so two equal bools compared apart. The corners sort by position rounded to the
  hundredth of a pixel.
- The harness changes that check the next commit, "Keep the layout's place and
  sizes out of a detach's kept geometry".

AI-assisted-by: claude-opus-5-5
2026-11-18 10:29:48 +01:00
..
2022-11-08 13:02:14 +01:00