mirror of
https://github.com/penpot/penpot.git
synced 2026-08-07 13:29:07 +00:00
Address critical code review findings: - Remove 'Signature' field from string-to-sign (it's the output, not input) - Differentiate V1 vs V2 field sets per AWS SNS documentation: - V1 Notification: Message, MessageId, Subject, Timestamp, TopicArn, Type - V1 SubscriptionConfirmation: adds Token, SubscribeURL (excludes SigningCertURL, SignatureVersion) - V2 Notification/Subscription: all fields except Signature - Add 'Token' field to SubscriptionConfirmation (required by AWS spec) - Add AWS documentation URL comments for future reference - Improve error handling in fetch-certificate and verify-signature - Add end-to-end signature verification tests with real key pairs - Add test resources (certificate and private key) for signature tests See: https://docs.aws.amazon.com/sns/latest/dg/sns-verify-signature-of-message.html Closes #11092 AI-assisted-by: qwen3.7-plus