mirror of
https://github.com/penpot/penpot.git
synced 2026-10-29 14:00:37 +00:00
317a731dda
* 🐛 Detect and repair children missing from their parent's list A shape could point to an existing parent that did not list it in its :shapes. The validator missed it, since it only walks the tree from the root plus the shapes whose parent does not exist. Operations that walk :shapes missed it too: deleting a variant also deleted its container, which looked empty, and left the other variants without a parent, so the backend rejected the change and the file stopped saving. - get-orphan-shapes also returns shapes not listed by their parent, so :child-not-in-parent is reported. - The :child-not-in-parent repair adds every unlisted child of the parent. All repairs share the same file data and each one sets the whole :shapes, so with several children only the last one was kept. - New migration 0032-fix-children-not-in-parent repairs the affected files when they are opened. Closes #11758 AI-assisted-by: claude-opus-5-5 * 🐛 List shapes moved to root by the parent-not-found repair The :parent-not-found repair set the shape's parent to the root but did not add it to the root's :shapes, so it left the shape in the child-not-in-parent state that the validator now reports. It now adds every shape without parent to the root at once, since all repairs are built from the same file data and each one sets the whole :shapes. Also cover the missing parent case in the repair tests. AI-assisted-by: claude-opus-5-5 * ♻️ Simplify unlisted children validation and repair Address review comments on the validation and repair of shapes that their parent does not list. - get-orphan-shapes no longer rebuilds *children-sets*: both callers bind it. The lookup moves to a listed-in-parent? helper shared with check-parent-children, which scans :shapes when the var is unbound. - The :child-not-in-parent and :parent-not-found repairs no longer walk every shape of the page. Each one moves only its own shape with pcb/change-parent. The :mov-objects change adds the shape to the parent's :shapes when applied, so several repairs on one parent no longer overwrite each other. - The :child-not-in-parent repair test uses plain shapes instead of variants. AI-assisted-by: claude-opus-5-5