mirror of
https://github.com/penpot/penpot.git
synced 2026-11-17 07:30:35 +00:00
This PR moves component thumbnail rendering off the main thread and onto the worker, which avoids the freezes. The main thread will send the worker over a request containing the component's shape data, and the worker will render it in batches. Once finished it will both persist the thumbnails to the server if requested and send back the PNG data to the main thread. AI-assisted-by: claude-opus-5-5
96 lines
3.7 KiB
Clojure
96 lines
3.7 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS SUBSIDIARY SL
|
|
|
|
(ns frontend-tests.worker.component-thumbnails-test
|
|
"The worker batches the component thumbnails the main thread asks for,
|
|
renders the batches one at a time, sends each render back and uploads
|
|
the ones asked for."
|
|
(:require
|
|
[app.common.thumbnails :as thc]
|
|
[app.common.uuid :as uuid]
|
|
[app.util.http :as http]
|
|
[app.util.webapi :as wapi]
|
|
[app.worker.component-thumbnails :as wct]
|
|
[app.worker.impl :as impl]
|
|
[app.worker.wasm :as wwasm]
|
|
[beicon.v2.core :as rx]
|
|
[cljs.test :as t :include-macros true]
|
|
[frontend-tests.helpers.async :as async]
|
|
[frontend-tests.helpers.mock :as mock]))
|
|
|
|
(def ^:private file-id (uuid/next))
|
|
(def ^:private page-id (uuid/next))
|
|
|
|
(defn- request-render
|
|
[root-id]
|
|
(impl/handler {:cmd :thumbnails/render-component
|
|
:file-id file-id
|
|
:page-id page-id
|
|
:root-id root-id
|
|
:objects {}}
|
|
nil))
|
|
|
|
(defn- sleep
|
|
[ms]
|
|
(js/Promise. (fn [resolve] (js/setTimeout resolve ms))))
|
|
|
|
(t/deftest ^:async a-burst-of-requests-renders-as-one-batch
|
|
(let [jobs (atom 0)]
|
|
(await
|
|
(mock/with-mocks*
|
|
{wwasm/submit (mock/stub (fn [_] (swap! jobs inc) (rx/empty)))}
|
|
(run! request-render (repeatedly 30 uuid/next))
|
|
(await (async/wait-for #(pos? @jobs) "the batch"))
|
|
;; Longer than the pause that would start a second batch
|
|
(await (sleep 400))))
|
|
(t/is (= 1 @jobs))))
|
|
|
|
(defn- ^:async render-with-module
|
|
"Renders a batch of one main with the WASM module mocked as `module`.
|
|
Returns what came out and whether it ended."
|
|
[module]
|
|
(let [out (atom {:values [] :ended? false :error nil})]
|
|
(await
|
|
(mock/with-mocks*
|
|
{wwasm/module module}
|
|
(await (async/observe (#'wct/render-batch [{:root-id (uuid/next) :objects {}}])
|
|
:on-next #(swap! out update :values conj %)
|
|
:on-error #(swap! out assoc :error %)
|
|
:on-complete #(swap! out assoc :ended? true)))))
|
|
@out))
|
|
|
|
(t/deftest ^:async a-failed-render-ends-its-batch-quietly
|
|
;; A failed module load, and a failed job: the tests have no WASM render
|
|
(doseq [module [(delay (js/Promise.reject (ex-info "no module" {})))
|
|
(delay (js/Promise.resolve nil))]]
|
|
(t/is (= {:values [] :ended? true :error nil}
|
|
(await (render-with-module module))))))
|
|
|
|
(t/deftest ^:async a-render-is-shown-and-uploaded-when-asked
|
|
(let [output (rx/subject)
|
|
shown (atom [])
|
|
requests (atom [])
|
|
file-id (uuid/next)
|
|
page-id (uuid/next)
|
|
edited (uuid/next)
|
|
undone (uuid/next)
|
|
blob (wapi/create-blob "png" "image/png")]
|
|
(rx/sub! output #(swap! shown conj %))
|
|
(reset! @#'wct/output* output)
|
|
(await
|
|
(mock/with-mocks*
|
|
{http/send! (mock/stub (fn [request] (swap! requests conj request) (rx/of {:status 200})))}
|
|
(#'wct/add-render {:file-id file-id :page-id page-id :root-id edited :blob blob :persist? true})
|
|
(#'wct/add-render {:file-id file-id :page-id page-id :root-id undone :blob blob :persist? false})))
|
|
(reset! @#'wct/output* nil)
|
|
(t/is (= [{:object-id (thc/fmt-object-id file-id page-id edited "component") :blob blob}
|
|
{:object-id (thc/fmt-object-id file-id page-id undone "component") :blob blob}]
|
|
@shown))
|
|
(t/is (= [{:file-id file-id
|
|
:object-id (thc/fmt-object-id file-id page-id edited "component")
|
|
:tag "component"}]
|
|
(mapv :query @requests)))))
|