mirror of
https://github.com/penpot/penpot.git
synced 2026-06-10 01:12:06 +00:00
addb392ecc
The main objective is prevent deletion of objects that can leave unreachable orphan objects which we are unable to correctly track. Additionally, this commit includes: 1. Properly implement safe cascade deletion of all participating tables on soft deletion in the objects-gc task; 2. Make the file thumbnail related tables also participate in the touch/refcount mechanism applyign to the same safety checks; 3. Add helper for db query lazy iteration using PostgreSQL support for server side cursors; 4. Fix efficiency issues on gc related task using server side cursors instead of custom chunked iteration for processing data. The problem resided when a large chunk of rows that has identical value on the deleted_at column and the chunk size is small (the default); when the custom chunked iteration only reads a first N items and skip the rest of the set to the next run. This has caused many objects to remain pending to be eliminated, taking up space for longer than expected. The server side cursor based iteration does not has this problem and iterates correctly over all objects. 5. Fix refcount issues on font variant deletion RPC methods
26 lines
1.1 KiB
SQL
26 lines
1.1 KiB
SQL
--- Add missing index for deleted_at column, we include all related
|
|
--- columns because we expect the index to be small and expect use
|
|
--- index-only scans.
|
|
CREATE INDEX IF NOT EXISTS file_thumbnail__deleted_at__idx
|
|
ON file_thumbnail (deleted_at, file_id, revn, media_id)
|
|
WHERE deleted_at IS NOT NULL;
|
|
|
|
--- Add missing for media_id column, used mainly for refs checking
|
|
CREATE INDEX IF NOT EXISTS file_thumbnail__media_id__idx ON file_thumbnail (media_id);
|
|
|
|
--- Remove CASCADE from media_id and file_id foreign constraint
|
|
ALTER TABLE file_thumbnail
|
|
DROP CONSTRAINT file_thumbnail_file_id_fkey,
|
|
ADD FOREIGN KEY (file_id) REFERENCES file(id) DEFERRABLE;
|
|
|
|
ALTER TABLE file_thumbnail
|
|
DROP CONSTRAINT file_thumbnail_media_id_fkey,
|
|
ADD FOREIGN KEY (media_id) REFERENCES storage_object(id) DEFERRABLE;
|
|
|
|
--- Add deletion protection
|
|
CREATE OR REPLACE TRIGGER deletion_protection__tgr
|
|
BEFORE DELETE ON file_thumbnail FOR EACH STATEMENT
|
|
WHEN ((current_setting('rules.deletion_protection', true) IN ('on', '')) OR
|
|
(current_setting('rules.deletion_protection', true) IS NULL))
|
|
EXECUTE PROCEDURE raise_deletion_protection();
|