mirror of
https://github.com/penpot/penpot.git
synced 2026-08-15 17:29:00 +00:00
fffafdab93
* 🐛 Fix library updates reappear after file is reloaded Summary Migrate synced_at timestamps to a standalone file_library_sync table to ensure sync state is tracked for both direct and transitive libraries. Problem Transitive libraries (libraries imported by other libraries) are not stored as direct rows in file_library_rel. Because the system previously coupled synced_at directly to the file_library_rel schema, transitive libraries lacked a persistent location for their sync timestamps. This caused sync states to be lost or incorrectly reported for nested dependencies. Changes Schema Migration: Created file_library_sync and migrated existing synced_at values from file_library_rel. Decoupling: Removed tight Foreign Key coupling to allow sync rows to exist independently of specific relationship records. Persistent Writes: Added upsert-file-library-sync! helper. Updated all import, duplication, and RPC write paths (v1/v2/v3 importers, link-file-library) to ensure every write persists a sync row. Unified Reads: Updated both direct and recursive/transitive library queries to fetch synced_at from the new table. Testing: Added regression tests to verify that sync rows are correctly created/updated even when a transitive relation is absent in file_library_rel. Impact This fix ensures that the system accurately records and retrieves sync states for the entire library dependency tree, resolving the bug where nested libraries appeared out of sync. * ✨ MR review
20 lines
703 B
SQL
20 lines
703 B
SQL
CREATE TABLE file_library_sync (
|
|
file_id uuid NOT NULL,
|
|
library_file_id uuid NOT NULL,
|
|
synced_at timestamptz NOT NULL DEFAULT clock_timestamp(),
|
|
|
|
PRIMARY KEY (file_id, library_file_id)
|
|
);
|
|
|
|
INSERT INTO file_library_sync (file_id, library_file_id, synced_at)
|
|
SELECT file_id, library_file_id, synced_at
|
|
FROM file_library_rel;
|
|
|
|
-- DEPRECATED: the `synced_at` column on `file_library_rel` is deprecated
|
|
-- and will be removed in a future migration. It's kept temporarily
|
|
-- for backward compatibility while data is migrated to `file_library_sync`.
|
|
COMMENT ON COLUMN file_library_rel.synced_at IS
|
|
'DEPRECATED: will be removed in a future migration; kept temporarily for backward compatibility';
|
|
|
|
|