mirror of
https://github.com/penpot/penpot.git
synced 2026-11-20 17:11:15 +00:00
* ♻️ Cut shortcuts and inspect e2e specs and harden their assertions Shortcuts spec: drop the enable-custom-shortcuts mock, since no frontend, common or backend code reads the flag, and cut 18 tests to 6. A header comment records where the removed rules went: named steps here and the 77 unit tests of settings_shortcuts_test.cljs. The six keep only what a browser proves: the file input and diff modal, the alert for a file with nothing to apply, the download of a bound and an empty entry, the RPC write with reload, the conflict that disables the previous binding, and both reset flows. Fix the shortcuts review findings: the invalid-file step dismisses the timeout-free toast before the next import and covers both removed payloads in one import. The conflict test records a default-bound and a custom-bound key on one page load, then resets and imports a key a default binding holds, so the diff modal's apply path runs with a default in the way, and checks the alert, the disabled row and the exported payload; the export test resets and imports the file it just downloaded. Inspect tab spec: cut 27 tests to 8 with 25 named steps, from 622.9 to 181.5 worker-seconds and 162.5 to 46.7 seconds of wall time. Layout, shadow and blur, fill, stroke, typography and clipboard cases run as steps in one page load per group; the two cases that mutate the shape with Design-tab controls keep their own. Replace 500 ms sleeps with waits on rendered state, make layer expansion idempotent, match layer names exactly, poll row counts and await every matcher. Drop the false comment about name capitalisation, the three unused shapeToLayerName entries and the skip the "Layer info" assertion now covers. Move layerRow and selectLayer into WorkspacePage with the helpers the next PR in the stack needs: layerRow matches an anchored name on the layer-row test id, because a selected row's hide and lock button titles join its accessible name, and selectLayer waits for aria-checked instead of the shape name. waitForSelectedShapeName takes options. The inspect spec drops its escapeRegExp, getLayerRow and inline selection. Rename the fixture token to radius-md so the radius assertion is not satisfied by the row label. Closes #13009 AI-assisted-by: deepseek-v4.1-flash * 🐛 Pass the translation flag in the sync text undo test The merge of staging into develop brought back the required :translation key of an undo entry, and the test added in ef0333eafe calls append-undo without it. check-undo-entry throws, the exception escapes the promise and the whole frontend run exits before printing the summary. The entry stands for the commit of a component sync, which is not a translation, so it carries :translation false, the value the production watcher derives from the commit. AI-assisted-by: deepseek-v4.1-flash