mirror of
https://github.com/penpot/penpot.git
synced 2026-11-06 18:10:39 +00:00
* 🐛 Fail MCP tasks at once when their plugin connection closes A response only counts when it comes from the connection the task went to, so a task sent over a connection that then closes can never finish. It used to wait for its full timeout. The plugin bridge now fails such tasks as soon as their connection closes. Connections also log their close code and reason, to tell a page closing its socket from a browser or network failure. * ✨ Announce the MCP session to a browser extension Let a browser extension learn which tab holds an MCP session, so it can keep the browser from discarding that tab. While the MCP plugin runs, the page listens for the extension's hello message, and says it is ready once it listens, so that a content script that said hello too early says it again. After a hello, the page posts its session ID and connection status, and posts them again on every status change. When the plugin stops, it reports the session as disconnected. The plugin also reports "disconnected" while it reconnects on its own, for instance after a page resume, so the page announces "connecting" then and "disconnected" only once the user has stopped the connection. Otherwise the extension would forget the session at every reconnect. The page only accepts messages posted on its own window by its own origin, posts to its own origin only, and sends nothing before the extension asks. It reaches the window through app.util.globals, whose stand-in for the unit tests accepts postMessage. * ✨ Keep Penpot tabs connected to MCP from being frozen Chrome freezes some background tabs, for instance busy ones while Battery Saver is on, and a frozen page cannot run the MCP plugin. Chrome does not freeze a page that holds a Web Lock, so the page holds a lock named penpot-mcp-session from the moment the user asks to connect until the connection stops: on disconnect, logout, MCP being turned off or the MCP runtime starting again. The lock is shared, so several tabs can hold it at once. Browsers without Web Locks skip it, and when the lock request fails, the next connection request tries again. Firefox does not freeze background pages, so the lock changes nothing there. * ✨ Add a browser extension that keeps MCP tabs from being discarded A browser may discard a background tab to save memory. A discarded Penpot tab reloads when the user returns to it and loses its MCP session. Add mcp/packages/browser-extension, a Manifest V3 extension for Chrome and Firefox, built from one source into dist/chrome and dist/firefox. It is written in TypeScript, bundled with esbuild and imports the protocol types from mcp-common. The package joins the mcp workspace, so the build, test and fmt scripts of mcp/ cover it; the server release build skips it. Its content script runs on design.penpot.app, on the test environments under penpot.dev and on local development instances. It asks the page for its MCP session on load, again when the page says it is ready and when the page returns from the back/forward cache, and forwards each valid session announcement to the background. It accepts only messages the page posted on its own window from its own origin, and posts its hello to that origin only. It also tells the background when the page is hidden. The background records which tab holds each MCP session. A tab holds the session it last announced as connected, until its page announces a disconnect, is hidden, or the tab is closed or replaced. The map lives in chrome.storage.session, so it survives restarts of the background and clears when the browser closes. While a tab holds a session, the browser may not discard it automatically. The extension asks only for the storage permission. Chrome runs the background as a service worker; Firefox runs it as an event page and needs the add-on ID, mcp-extension@penpot.app, and Firefox 140. The toolbar popup lists the connected tabs. The icon is the Penpot logo, white on a black rounded square, with the SVG source next to the PNGs. A README explains how the extension works and how to build and load it. * 🐛 Ask MCP plugins for heartbeats so hidden tabs do not look frozen The server refuses to send a task to a plugin whose last heartbeat is older than 30 s, taking its tab for frozen. The plugin sent heartbeats only from a 10 s timer, and Chrome runs the timers of a hidden page as rarely as once a minute: without Energy Saver after about a minute hidden, and at once with it. A Penpot tab hidden for a minute therefore failed that check about half the time, although it could run tasks. Chrome handles socket messages of a hidden page at once, and a frozen page cannot handle them at all. The server now sends each plugin a heartbeat request every 10 s, and the plugin answers it with a heartbeat, so the heartbeat age again tells a frozen tab from a hidden one. The plugin keeps its timer, so it still sends heartbeats to a server that does not ask. A plugin that does not know the request passes it to the plugin code, which ignores it.
450 lines
16 KiB
TypeScript
450 lines
16 KiB
TypeScript
import "./style.css";
|
|
import { shouldReconnectAfterClose } from "./ReconnectPolicy";
|
|
import { SessionId } from "./SessionId";
|
|
import { SessionIdDisplay } from "./SessionIdDisplay";
|
|
import type { PluginConnectionInit } from "../../common/src";
|
|
|
|
/**
|
|
* the maximum allowed size for task responses sent back to the MCP server in the integrated remote MCP mode.
|
|
* This bounds the JSON response size.
|
|
* Note that in the remote MCP case, responses are transferred to LLMs (not the file system) and LLMs have
|
|
* size limitations. This serves to bound the size of returned images in particular.
|
|
* Too many overly large simultaneous responses can cause OOM issues in the MCP server, so this contributes
|
|
* to bounding memory usage in the centrally provided MCP server.
|
|
*/
|
|
const MAX_TASK_RESPONSE_SIZE_REMOTE_MCP = 15_000_000;
|
|
|
|
// get the current theme from the URL
|
|
const searchParams = new URLSearchParams(window.location.hash.split("?")[1]);
|
|
document.body.dataset.theme = searchParams.get("theme") ?? "light";
|
|
|
|
// WebSocket connection to the MCP server
|
|
let ws: WebSocket | null = null;
|
|
let connectionSessionId: string | null = null;
|
|
let connectionRequestId: string | null = null;
|
|
let connectionReady = false;
|
|
|
|
const HEARTBEAT_INTERVAL_MS = 10_000;
|
|
const RECONNECT_BASE_DELAY_MS = 1_000;
|
|
const RECONNECT_MAX_DELAY_MS = 30_000;
|
|
|
|
// transport-level reconnect state for the plugin WebSocket
|
|
let shouldReconnect = false;
|
|
let lastConnectionUrl: string | undefined;
|
|
let lastConnectionToken: string | undefined;
|
|
let reconnectAttempts = 0;
|
|
let reconnectTimer: ReturnType<typeof setTimeout> | null = null;
|
|
let heartbeatTimer: ReturnType<typeof setInterval> | null = null;
|
|
|
|
/**
|
|
* indicates whether the plugin is running with the Penpot-integrated remote MCP server enabled
|
|
* (as opposed to a local server used with the explicitly loaded plugin);
|
|
* set via the "mcp-mode" message sent by plugin.ts on initialization
|
|
*/
|
|
let isIntegratedRemoteMcp = false;
|
|
|
|
const statusPill = document.getElementById("connection-status") as HTMLElement;
|
|
const statusText = document.getElementById("status-text") as HTMLElement;
|
|
const currentTaskEl = document.getElementById("current-task") as HTMLElement;
|
|
const executedCodeEl = document.getElementById("executed-code") as HTMLTextAreaElement;
|
|
const copyCodeBtn = document.getElementById("copy-code-btn") as HTMLButtonElement;
|
|
const connectBtn = document.getElementById("connect-btn") as HTMLButtonElement;
|
|
const disconnectBtn = document.getElementById("disconnect-btn") as HTMLButtonElement;
|
|
const versionWarningEl = document.getElementById("version-warning") as HTMLElement;
|
|
const versionWarningTextEl = document.getElementById("version-warning-text") as HTMLElement;
|
|
const sessionIdEl = document.getElementById("session-id");
|
|
const sessionIdDisplay = sessionIdEl ? new SessionIdDisplay(sessionIdEl, navigator.clipboard) : null;
|
|
|
|
/**
|
|
* Updates the status pill and button visibility based on connection state.
|
|
*
|
|
* @param code - the connection state code ("idle" | "connecting" | "connected" | "disconnected" | "error")
|
|
* @param label - human-readable label to display inside the pill
|
|
*/
|
|
function updateConnectionStatus(code: string, label: string): void {
|
|
if (statusPill) {
|
|
statusPill.dataset.status = code;
|
|
}
|
|
if (statusText) {
|
|
statusText.textContent = label;
|
|
}
|
|
|
|
const isConnected = code === "connected";
|
|
sessionIdDisplay?.setSessionId(isConnected ? connectionSessionId : null);
|
|
if (connectBtn) connectBtn.hidden = isConnected;
|
|
if (disconnectBtn) disconnectBtn.hidden = !isConnected;
|
|
|
|
parent.postMessage(
|
|
{
|
|
type: "update-connection-status",
|
|
status: code,
|
|
sessionId: connectionSessionId,
|
|
},
|
|
"*"
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Updates the "Current task" display with the currently executing task name.
|
|
*
|
|
* @param taskName - the task name to display, or null to reset to "---"
|
|
*/
|
|
function updateCurrentTask(taskName: string | null): void {
|
|
if (currentTaskEl) {
|
|
currentTaskEl.textContent = taskName ?? "---";
|
|
}
|
|
if (taskName === null) {
|
|
updateExecutedCode(null);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Updates the executed code textarea with the last code run during task execution.
|
|
*
|
|
* @param code - the code string to display, or null to clear
|
|
*/
|
|
function updateExecutedCode(code: string | null): void {
|
|
if (executedCodeEl) {
|
|
executedCodeEl.value = code ?? "";
|
|
}
|
|
if (copyCodeBtn) {
|
|
copyCodeBtn.disabled = !code;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Sends a task response back to the MCP server via WebSocket.
|
|
*
|
|
* @param response - The response containing task ID and result
|
|
*/
|
|
function sendTaskResponse(response: any): void {
|
|
if (ws && ws.readyState === WebSocket.OPEN) {
|
|
let responseString = JSON.stringify(response);
|
|
if (isIntegratedRemoteMcp && responseString.length > MAX_TASK_RESPONSE_SIZE_REMOTE_MCP) {
|
|
const errorMessage = `Serialised response size (${responseString.length}) exceeds maximum of ${MAX_TASK_RESPONSE_SIZE_REMOTE_MCP}.`;
|
|
console.warn(
|
|
errorMessage +
|
|
" [integrated remote MCP mode restriction]; sending error response instead; original response:",
|
|
response
|
|
);
|
|
response = {
|
|
id: response.id,
|
|
success: false,
|
|
error: errorMessage,
|
|
};
|
|
responseString = JSON.stringify(response);
|
|
}
|
|
ws.send(responseString);
|
|
console.log("Sent response to MCP server:", response);
|
|
} else {
|
|
console.error("WebSocket not connected, cannot send response");
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Emits a liveness signal from the plugin event loop.
|
|
*
|
|
* WebSocket ping/pong is not enough here: browsers can answer protocol pings while
|
|
* page JavaScript is frozen and unable to run MCP tasks. The plugin sends one on a timer and
|
|
* in answer to each heartbeat request of the server, since a browser runs the timers of a
|
|
* hidden page as rarely as once a minute but handles socket messages at once.
|
|
*/
|
|
function sendHeartbeat(): boolean {
|
|
if (connectionReady && ws?.readyState === WebSocket.OPEN) {
|
|
ws.send(JSON.stringify({ type: "heartbeat" }));
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/** Starts heartbeat emission for the active WebSocket. */
|
|
function startHeartbeat(): void {
|
|
stopHeartbeat();
|
|
heartbeatTimer = setInterval(sendHeartbeat, HEARTBEAT_INTERVAL_MS);
|
|
}
|
|
|
|
/** Stops heartbeat emission for the active WebSocket. */
|
|
function stopHeartbeat(): void {
|
|
if (heartbeatTimer !== null) {
|
|
clearInterval(heartbeatTimer);
|
|
heartbeatTimer = null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Delay before the next reconnect, using capped exponential backoff.
|
|
*
|
|
* Keeps recovery fast for short drops without hammering an unavailable server.
|
|
*/
|
|
function computeReconnectDelay(attempts: number): number {
|
|
return Math.min(RECONNECT_BASE_DELAY_MS * 2 ** attempts, RECONNECT_MAX_DELAY_MS);
|
|
}
|
|
|
|
/** Schedules one WebSocket reconnect attempt with backoff. */
|
|
function scheduleReconnect(): void {
|
|
if (!shouldReconnect || reconnectTimer !== null) {
|
|
return;
|
|
}
|
|
const delay = computeReconnectDelay(reconnectAttempts);
|
|
reconnectAttempts++;
|
|
reconnectTimer = setTimeout(() => {
|
|
reconnectTimer = null;
|
|
if (shouldReconnect && ws?.readyState !== WebSocket.OPEN && ws?.readyState !== WebSocket.CONNECTING) {
|
|
connectToMcpServer(lastConnectionUrl, lastConnectionToken);
|
|
}
|
|
}, delay);
|
|
}
|
|
|
|
/** Cancels pending reconnection and resets backoff. */
|
|
function cancelReconnect(): void {
|
|
if (reconnectTimer !== null) {
|
|
clearTimeout(reconnectTimer);
|
|
reconnectTimer = null;
|
|
}
|
|
reconnectAttempts = 0;
|
|
}
|
|
|
|
/**
|
|
* Establishes a WebSocket connection to the MCP server.
|
|
*/
|
|
function connectToMcpServer(baseUrl?: string, token?: string): void {
|
|
shouldReconnect = true;
|
|
lastConnectionUrl = baseUrl;
|
|
lastConnectionToken = token;
|
|
|
|
if (ws?.readyState === WebSocket.OPEN) {
|
|
if (connectionReady) updateConnectionStatus("connected", "Connected");
|
|
return;
|
|
}
|
|
if (ws?.readyState === WebSocket.CONNECTING) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
let wsUrl = baseUrl || PENPOT_MCP_WEBSOCKET_URL;
|
|
let wsError: unknown | undefined;
|
|
|
|
if (token) {
|
|
wsUrl += `?userToken=${encodeURIComponent(token)}`;
|
|
}
|
|
|
|
ws = new WebSocket(wsUrl);
|
|
const socket = ws;
|
|
connectionRequestId = crypto.randomUUID();
|
|
connectionSessionId = null;
|
|
connectionReady = false;
|
|
updateConnectionStatus("connecting", "Connecting...");
|
|
|
|
ws.onopen = () => {
|
|
if (ws !== socket) return;
|
|
parent.postMessage({ type: "connection-metadata-request", sessionId: connectionRequestId }, "*");
|
|
};
|
|
|
|
ws.onmessage = (event) => {
|
|
if (ws !== socket) return;
|
|
try {
|
|
console.log("Received from MCP server:", event.data);
|
|
const request = JSON.parse(event.data);
|
|
if (request.type === "initialized") {
|
|
if (ws !== socket) return;
|
|
connectionReady = true;
|
|
cancelReconnect();
|
|
startHeartbeat();
|
|
updateConnectionStatus("connected", "Connected");
|
|
parent.postMessage({ type: "context-request" }, "*");
|
|
return;
|
|
}
|
|
if (request.type === "heartbeat-request") {
|
|
sendHeartbeat();
|
|
return;
|
|
}
|
|
// Track the current task received from the MCP server
|
|
if (request.task) {
|
|
updateCurrentTask(request.task);
|
|
updateExecutedCode(request.params?.code ?? null);
|
|
}
|
|
// Forward the task request to the plugin for execution
|
|
parent.postMessage(request, "*");
|
|
} catch (error) {
|
|
console.error("Failed to parse WebSocket message:", error);
|
|
}
|
|
};
|
|
|
|
ws.onclose = (event: CloseEvent) => {
|
|
if (ws !== socket) return;
|
|
stopHeartbeat();
|
|
// keep the explicit error state if one was already shown
|
|
if (!wsError) {
|
|
console.log("Disconnected from MCP server");
|
|
const label = event.reason ? `Disconnected: ${event.reason}` : "Disconnected";
|
|
updateConnectionStatus("disconnected", label);
|
|
updateCurrentTask(null);
|
|
}
|
|
ws = null;
|
|
connectionSessionId = null;
|
|
connectionReady = false;
|
|
if (!shouldReconnectAfterClose(event.code)) {
|
|
// a policy violation requires the user to correct the connection settings
|
|
shouldReconnect = false;
|
|
cancelReconnect();
|
|
return;
|
|
}
|
|
scheduleReconnect();
|
|
};
|
|
|
|
ws.onerror = (error) => {
|
|
console.error("WebSocket error:", error);
|
|
wsError = error;
|
|
// note: WebSocket error events typically don't contain detailed error messages
|
|
updateConnectionStatus("error", "Connection error");
|
|
};
|
|
} catch (error) {
|
|
console.error("Failed to connect to MCP server:", error);
|
|
const reason = error instanceof Error ? error.message : undefined;
|
|
const label = reason ? `Connection failed: ${reason}` : "Connection failed";
|
|
updateConnectionStatus("error", label);
|
|
}
|
|
}
|
|
|
|
/** Closes the socket without reconnecting. */
|
|
function disconnectFromMcpServer(): void {
|
|
shouldReconnect = false;
|
|
cancelReconnect();
|
|
stopHeartbeat();
|
|
const socket = ws;
|
|
ws = null;
|
|
connectionRequestId = null;
|
|
connectionSessionId = null;
|
|
connectionReady = false;
|
|
socket?.close();
|
|
updateConnectionStatus("disconnected", "Disconnected");
|
|
updateCurrentTask(null);
|
|
}
|
|
|
|
copyCodeBtn?.addEventListener("click", () => {
|
|
const code = executedCodeEl?.value;
|
|
if (!code) return;
|
|
|
|
navigator.clipboard.writeText(code).then(() => {
|
|
copyCodeBtn.classList.add("copied");
|
|
setTimeout(() => copyCodeBtn.classList.remove("copied"), 1500);
|
|
});
|
|
});
|
|
|
|
connectBtn?.addEventListener("click", () => {
|
|
connectToMcpServer();
|
|
});
|
|
|
|
disconnectBtn?.addEventListener("click", () => {
|
|
disconnectFromMcpServer();
|
|
});
|
|
|
|
// Listen plugin.ts messages
|
|
window.addEventListener("message", async (event) => {
|
|
if (event.data.type === "initialize") {
|
|
const initialization = event.data as PluginConnectionInit & { penpotUserSessionId?: string };
|
|
const socket = ws;
|
|
const requestId = connectionRequestId;
|
|
if (
|
|
!shouldReconnect ||
|
|
socket?.readyState !== WebSocket.OPEN ||
|
|
initialization.session.sessionId !== requestId
|
|
) {
|
|
return;
|
|
}
|
|
try {
|
|
if (!initialization.penpotUserSessionId) {
|
|
throw new Error("Missing Penpot user session ID");
|
|
}
|
|
const sessionId = await SessionId.forSession(initialization.penpotUserSessionId);
|
|
if (
|
|
!shouldReconnect ||
|
|
ws !== socket ||
|
|
connectionRequestId !== requestId ||
|
|
socket.readyState !== WebSocket.OPEN
|
|
) {
|
|
return;
|
|
}
|
|
connectionSessionId = sessionId;
|
|
socket.send(
|
|
JSON.stringify({
|
|
type: "initialize",
|
|
session: { ...initialization.session, sessionId },
|
|
})
|
|
);
|
|
} catch (error) {
|
|
console.error("Failed to initialize MCP session:", error);
|
|
if (ws === socket) {
|
|
disconnectFromMcpServer();
|
|
updateConnectionStatus("error", "Failed to initialize MCP session");
|
|
}
|
|
}
|
|
return;
|
|
}
|
|
if (event.data.type === "context-update") {
|
|
if (connectionReady && ws?.readyState === WebSocket.OPEN) {
|
|
ws.send(JSON.stringify(event.data));
|
|
}
|
|
return;
|
|
}
|
|
if (event.data.type === "mcp-mode") {
|
|
isIntegratedRemoteMcp = event.data.integratedRemoteMcp;
|
|
}
|
|
if (event.data.type === "start-server") {
|
|
connectToMcpServer(event.data.url, event.data.token);
|
|
}
|
|
if (event.data.type === "version-mismatch") {
|
|
if (versionWarningEl && versionWarningTextEl) {
|
|
versionWarningTextEl.innerHTML =
|
|
`<b>Version mismatch detected</b>: This version of the MCP server is intended for Penpot ` +
|
|
`${event.data.mcpVersion} while the current version is ${event.data.penpotVersion}. ` +
|
|
`Executions may not work or produce suboptimal results.`;
|
|
versionWarningEl.hidden = false;
|
|
}
|
|
}
|
|
if (event.data.type === "stop-server") {
|
|
disconnectFromMcpServer();
|
|
} else if (event.data.source === "penpot") {
|
|
document.body.dataset.theme = event.data.theme;
|
|
} else if (event.data.type === "task-response") {
|
|
// Forward task response back to MCP server
|
|
sendTaskResponse(event.data.response);
|
|
}
|
|
});
|
|
|
|
/** Sends a heartbeat or reconnects after the tab becomes active again. */
|
|
function handleTabResumed(): void {
|
|
if (!shouldReconnect) {
|
|
return;
|
|
}
|
|
if (ws?.readyState === WebSocket.OPEN) {
|
|
sendHeartbeat();
|
|
} else if (ws?.readyState !== WebSocket.CONNECTING) {
|
|
cancelReconnect();
|
|
connectToMcpServer(lastConnectionUrl, lastConnectionToken);
|
|
}
|
|
}
|
|
|
|
// Chrome supports freeze/resume; Firefox does not. That is acceptable because
|
|
// Firefox still supports visibilitychange, and stale heartbeats detect any tab
|
|
// suspension that prevents plugin JavaScript from running tasks.
|
|
|
|
// Chrome: about to pause page JavaScript.
|
|
document.addEventListener("freeze", () => {
|
|
if (connectionReady && ws?.readyState === WebSocket.OPEN) {
|
|
ws.send(JSON.stringify({ type: "freeze" }));
|
|
}
|
|
});
|
|
|
|
// Chrome: frozen page resumed.
|
|
document.addEventListener("resume", handleTabResumed);
|
|
|
|
// Chrome and Firefox: tab visibility changed.
|
|
document.addEventListener("visibilitychange", () => {
|
|
if (document.visibilityState === "visible") {
|
|
handleTabResumed();
|
|
}
|
|
});
|
|
|
|
parent.postMessage({ type: "ui-initialized" }, "*");
|