Eva Marco 4d416bd3f2
♻️ Use DS icons and buttons in the settings sidebar and email modal (#12541)
* ♻️ Use DS icons and buttons in the settings sidebar and email modal

- The settings sidebar back arrow and "Contact us" icon use the DS
  icons. The arrow keeps its place; the small DS icon draws 12px inside
  a 16px box, so the feedback icon sits 2px to the right and its margin
  shrinks to keep the label in place.
- The change email modal close button becomes a ghost DS icon button
  named "Close"; the class that places it goes on the tooltip wrapper.

The form submit buttons of the settings pages stay: they are the shared
forms submit button. A visual test covers the settings sidebar and the
change email modal.

AI-assisted-by: claude-opus-5-5

* ♻️ Move settings sidebar and email modal styles to the DS

The settings sidebar no longer imports refactor/: its legacy mixins,
sizes and color aliases resolve to DS values and tokens, with logical
properties. Its z-index (1) has no DS token and keeps a TODO.

The change email modal does the same and keeps refactor/ only for the
modal placeholders (%modal-*), which move with the modals refactor. Its
legacy uppercase title becomes the DS headline-small typography, which
differs only in its size (12px instead of 11px): the modal grows 2px.
Two unused selectors are commented out with a TODO.

AI-assisted-by: claude-opus-5-5

* 🔥 Remove unused styles from the change email modal

The SCSS refactor of the change email modal left rules commented out
with a TODO because the module does not use them, or because they target
an svg inside a DS icon that is the svg itself. CSS modules scope the
classes to this module and no other source uses them, so they go:
.select-title, .cancel-button. No visual change.

AI-assisted-by: claude-opus-5-5

* ♻️ Tidy the settings sidebar and change email styles

The sidebar uses --z-index-panels instead of auto, the change email
submit button gets its own class instead of a bare button selector, and
the sidebar icons keep the DS stroke width (only the feedback icon line
gets thinner).

AI-assisted-by: claude-opus-5-5
2026-10-28 10:39:35 +01:00
..