mirror of
https://github.com/penpot/penpot.git
synced 2026-06-01 13:10:21 +00:00
The main objective is prevent deletion of objects that can leave unreachable orphan objects which we are unable to correctly track. Additionally, this commit includes: 1. Properly implement safe cascade deletion of all participating tables on soft deletion in the objects-gc task; 2. Make the file thumbnail related tables also participate in the touch/refcount mechanism applyign to the same safety checks; 3. Add helper for db query lazy iteration using PostgreSQL support for server side cursors; 4. Fix efficiency issues on gc related task using server side cursors instead of custom chunked iteration for processing data. The problem resided when a large chunk of rows that has identical value on the deleted_at column and the chunk size is small (the default); when the custom chunked iteration only reads a first N items and skip the rest of the set to the next run. This has caused many objects to remain pending to be eliminated, taking up space for longer than expected. The server side cursor based iteration does not has this problem and iterates correctly over all objects. 5. Fix refcount issues on font variant deletion RPC methods
209 lines
6.7 KiB
Clojure
209 lines
6.7 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS INC
|
|
|
|
(ns app.storage.gc-touched
|
|
"This task is part of the garbage collection process of storage
|
|
objects and is responsible on analyzing the touched objects and mark
|
|
them for deletion if corresponds.
|
|
|
|
For example: when file_media_object is deleted, the depending
|
|
storage_object are marked as touched. This means that some files
|
|
that depend on a concrete storage_object are no longer exists and
|
|
maybe this storage_object is no longer necessary and can be eligible
|
|
for elimination. This task periodically analyzes touched objects and
|
|
mark them as freeze (means that has other references and the object
|
|
is still valid) or deleted (no more references to this object so is
|
|
ready to be deleted)."
|
|
(:require
|
|
[app.common.data :as d]
|
|
[app.common.data.macros :as dm]
|
|
[app.common.exceptions :as ex]
|
|
[app.common.logging :as l]
|
|
[app.db :as db]
|
|
[app.storage :as-alias sto]
|
|
[app.storage.impl :as impl]
|
|
[clojure.spec.alpha :as s]
|
|
[integrant.core :as ig]))
|
|
|
|
(def ^:private sql:get-team-font-variant-nrefs
|
|
"SELECT ((SELECT count(*) FROM team_font_variant WHERE woff1_file_id = ?) +
|
|
(SELECT count(*) FROM team_font_variant WHERE woff2_file_id = ?) +
|
|
(SELECT count(*) FROM team_font_variant WHERE otf_file_id = ?) +
|
|
(SELECT count(*) FROM team_font_variant WHERE ttf_file_id = ?)) AS nrefs")
|
|
|
|
(defn- get-team-font-variant-nrefs
|
|
[conn id]
|
|
(-> (db/exec-one! conn [sql:get-team-font-variant-nrefs id id id id])
|
|
(get :nrefs)))
|
|
|
|
|
|
(def ^:private
|
|
sql:get-file-media-object-nrefs
|
|
"SELECT ((SELECT count(*) FROM file_media_object WHERE media_id = ?) +
|
|
(SELECT count(*) FROM file_media_object WHERE thumbnail_id = ?)) AS nrefs")
|
|
|
|
(defn- get-file-media-object-nrefs
|
|
[conn id]
|
|
(-> (db/exec-one! conn [sql:get-file-media-object-nrefs id id])
|
|
(get :nrefs)))
|
|
|
|
|
|
(def ^:private sql:get-profile-nrefs
|
|
"SELECT ((SELECT count(*) FROM profile WHERE photo_id = ?) +
|
|
(SELECT count(*) FROM team WHERE photo_id = ?)) AS nrefs")
|
|
|
|
(defn- get-profile-nrefs
|
|
[conn id]
|
|
(-> (db/exec-one! conn [sql:get-profile-nrefs id id])
|
|
(get :nrefs)))
|
|
|
|
|
|
(def ^:private
|
|
sql:get-file-object-thumbnail-nrefs
|
|
"SELECT (SELECT count(*) FROM file_tagged_object_thumbnail WHERE media_id = ?) AS nrefs")
|
|
|
|
(defn- get-file-object-thumbnails
|
|
[conn id]
|
|
(-> (db/exec-one! conn [sql:get-file-object-thumbnail-nrefs id])
|
|
(get :nrefs)))
|
|
|
|
|
|
(def ^:private
|
|
sql:get-file-thumbnail-nrefs
|
|
"SELECT (SELECT count(*) FROM file_thumbnail WHERE media_id = ?) AS nrefs")
|
|
|
|
(defn- get-file-thumbnails
|
|
[conn id]
|
|
(-> (db/exec-one! conn [sql:get-file-thumbnail-nrefs id])
|
|
(get :nrefs)))
|
|
|
|
|
|
(def ^:private sql:mark-freeze-in-bulk
|
|
"UPDATE storage_object
|
|
SET touched_at = NULL
|
|
WHERE id = ANY(?::uuid[])")
|
|
|
|
(defn- mark-freeze-in-bulk!
|
|
[conn ids]
|
|
(let [ids (db/create-array conn "uuid" ids)]
|
|
(db/exec-one! conn [sql:mark-freeze-in-bulk ids])))
|
|
|
|
|
|
(def ^:private sql:mark-delete-in-bulk
|
|
"UPDATE storage_object
|
|
SET deleted_at = now(),
|
|
touched_at = NULL
|
|
WHERE id = ANY(?::uuid[])")
|
|
|
|
(defn- mark-delete-in-bulk!
|
|
[conn ids]
|
|
(let [ids (db/create-array conn "uuid" ids)]
|
|
(db/exec-one! conn [sql:mark-delete-in-bulk ids])))
|
|
|
|
;; NOTE: A getter that retrieves the key which will be used for group
|
|
;; ids; previously we have no value, then we introduced the
|
|
;; `:reference` prop, and then it is renamed to `:bucket` and now is
|
|
;; string instead. This is implemented in this way for backward
|
|
;; comaptibilty.
|
|
|
|
;; NOTE: we use the "file-media-object" as default value for
|
|
;; backward compatibility because when we deploy it we can
|
|
;; have old backend instances running in the same time as
|
|
;; the new one and we can still have storage-objects created
|
|
;; without bucket value. And we know that if it does not
|
|
;; have value, it means :file-media-object.
|
|
|
|
(defn- lookup-bucket
|
|
[{:keys [metadata]}]
|
|
(or (some-> metadata :bucket)
|
|
(some-> metadata :reference d/name)
|
|
"file-media-object"))
|
|
|
|
(defn- process-objects!
|
|
[conn get-fn ids bucket]
|
|
(loop [to-freeze #{}
|
|
to-delete #{}
|
|
ids (seq ids)]
|
|
(if-let [id (first ids)]
|
|
(let [nrefs (get-fn conn id)]
|
|
(if (pos? nrefs)
|
|
(do
|
|
(l/debug :hint "processing object"
|
|
:id (str id)
|
|
:status "freeze"
|
|
:bucket bucket :refs nrefs)
|
|
(recur (conj to-freeze id) to-delete (rest ids)))
|
|
(do
|
|
(l/debug :hint "processing object"
|
|
:id (str id)
|
|
:status "delete"
|
|
:bucket bucket :refs nrefs)
|
|
(recur to-freeze (conj to-delete id) (rest ids)))))
|
|
(do
|
|
(some->> (seq to-freeze) (mark-freeze-in-bulk! conn))
|
|
(some->> (seq to-delete) (mark-delete-in-bulk! conn))
|
|
[(count to-freeze) (count to-delete)]))))
|
|
|
|
(defn- process-bucket!
|
|
[conn bucket ids]
|
|
(case bucket
|
|
"file-media-object" (process-objects! conn get-file-media-object-nrefs ids bucket)
|
|
"team-font-variant" (process-objects! conn get-team-font-variant-nrefs ids bucket)
|
|
"file-object-thumbnail" (process-objects! conn get-file-object-thumbnails ids bucket)
|
|
"file-thumbnail" (process-objects! conn get-file-thumbnails ids bucket)
|
|
"profile" (process-objects! conn get-profile-nrefs ids bucket)
|
|
(ex/raise :type :internal
|
|
:code :unexpected-unknown-reference
|
|
:hint (dm/fmt "unknown reference %" bucket))))
|
|
|
|
|
|
(def ^:private
|
|
sql:get-touched-storage-objects
|
|
"SELECT so.*
|
|
FROM storage_object AS so
|
|
WHERE so.touched_at IS NOT NULL
|
|
ORDER BY touched_at ASC
|
|
FOR UPDATE
|
|
SKIP LOCKED")
|
|
|
|
(defn- group-by-bucket
|
|
[row]
|
|
(d/group-by lookup-bucket :id #{} row))
|
|
|
|
(defn- get-buckets
|
|
[conn]
|
|
(sequence
|
|
(comp (map impl/decode-row)
|
|
(partition-all 25)
|
|
(mapcat group-by-bucket))
|
|
(db/cursor conn sql:get-touched-storage-objects)))
|
|
|
|
(defn- process-touched!
|
|
[{:keys [::db/conn]}]
|
|
(loop [buckets (get-buckets conn)
|
|
freezed 0
|
|
deleted 0]
|
|
(if-let [[bucket ids] (first buckets)]
|
|
(let [[nfo ndo] (process-bucket! conn bucket ids)]
|
|
(recur (rest buckets)
|
|
(+ freezed nfo)
|
|
(+ deleted ndo)))
|
|
(do
|
|
(l/inf :hint "task finished"
|
|
:to-freeze freezed
|
|
:to-delete deleted)
|
|
|
|
{:freeze freezed :delete deleted}))))
|
|
|
|
(defmethod ig/pre-init-spec ::handler [_]
|
|
(s/keys :req [::db/pool]))
|
|
|
|
(defmethod ig/init-key ::handler
|
|
[_ cfg]
|
|
(fn [_]
|
|
(db/tx-run! cfg process-touched!)))
|
|
|