mirror of
https://github.com/penpot/penpot.git
synced 2026-09-25 13:26:16 +00:00
25eff238ae
GitHub does not report mutation-created issue-to-PR links through closedByPullRequestsReferences(userLinkedOnly: true), so the verification in `gh.py link-issue` failed even when addCloseIssueReferences succeeded and the link existed. Drop the re-query and trust the successful mutation: the command now fails only when a link target is missing or the mutation does not return the issue. Update the tests, the gh helper memory, the PR/issue workflow memories, and the create-pr skill so they no longer promise verification. AI-assisted-by: deepseek-v4.1-flash
115 lines
3.5 KiB
Python
115 lines
3.5 KiB
Python
#!/usr/bin/env python3
|
|
"""Tests for scripts/gh.py.
|
|
|
|
Run with:
|
|
|
|
python3 scripts/test_gh.py
|
|
"""
|
|
|
|
import contextlib
|
|
import importlib.machinery
|
|
import importlib.util
|
|
import io
|
|
import json
|
|
import pathlib
|
|
import sys
|
|
import types
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
|
|
# Loading scripts/gh.py should not emit scripts/__pycache__/.
|
|
sys.dont_write_bytecode = True
|
|
|
|
SCRIPT_PATH = pathlib.Path(__file__).resolve().parent / "gh.py"
|
|
|
|
|
|
def load_gh():
|
|
"""Load scripts/gh.py as a module without running its CLI."""
|
|
loader = importlib.machinery.SourceFileLoader("gh_helper", str(SCRIPT_PATH))
|
|
spec = importlib.util.spec_from_loader("gh_helper", loader)
|
|
module = importlib.util.module_from_spec(spec)
|
|
loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
gh = load_gh()
|
|
|
|
|
|
class LinkIssueTests(unittest.TestCase):
|
|
def setUp(self):
|
|
self.target_response = {
|
|
"repository": {
|
|
"issue": {"id": "issue-id", "number": 11235},
|
|
"pullRequest": {"id": "pr-id", "number": 11243},
|
|
}
|
|
}
|
|
self.mutation_response = {
|
|
"addCloseIssueReferences": {
|
|
"issue": {"id": "issue-id", "number": 11235}
|
|
}
|
|
}
|
|
|
|
@patch.object(gh, "run_gh_graphql")
|
|
def test_link_issue_to_pr_adds_reference(self, run_graphql):
|
|
run_graphql.side_effect = [
|
|
self.target_response,
|
|
self.mutation_response,
|
|
]
|
|
|
|
result = gh.link_issue_to_pr(11235, 11243)
|
|
|
|
self.assertTrue(result["linked"])
|
|
self.assertEqual(result["issue"]["number"], 11235)
|
|
self.assertEqual(result["pull_request"]["number"], 11243)
|
|
self.assertEqual(run_graphql.call_count, 2)
|
|
self.assertEqual(
|
|
run_graphql.call_args_list[1].args[1],
|
|
{"issueId": "issue-id", "pullRequestIds": ["pr-id"]},
|
|
)
|
|
|
|
@patch.object(gh, "run_gh_graphql")
|
|
def test_link_issue_to_pr_fails_when_mutation_did_not_link(self, run_graphql):
|
|
run_graphql.side_effect = [
|
|
self.target_response,
|
|
{"addCloseIssueReferences": {"issue": {"id": "issue-id", "number": 999}}},
|
|
]
|
|
|
|
with self.assertRaisesRegex(RuntimeError, "did not link issue #11235"):
|
|
gh.link_issue_to_pr(11235, 11243)
|
|
|
|
@patch.object(gh, "link_issue_to_pr")
|
|
def test_cmd_link_issue_outputs_result(self, link_issue):
|
|
expected = {
|
|
"linked": True,
|
|
"issue": {"number": 11235},
|
|
"pull_request": {"number": 11243},
|
|
}
|
|
link_issue.return_value = expected
|
|
args = types.SimpleNamespace(issue_number=11235, pr_number=11243)
|
|
stdout = io.StringIO()
|
|
stderr = io.StringIO()
|
|
|
|
with contextlib.redirect_stdout(stdout), contextlib.redirect_stderr(stderr):
|
|
gh.cmd_link_issue(args)
|
|
|
|
self.assertEqual(json.loads(stdout.getvalue()), expected)
|
|
self.assertIn("Linked issue #11235", stderr.getvalue())
|
|
link_issue.assert_called_once_with(11235, 11243)
|
|
|
|
@patch.object(gh, "link_issue_to_pr", side_effect=RuntimeError("link missing"))
|
|
def test_cmd_link_issue_exits_on_error(self, _link_issue):
|
|
args = types.SimpleNamespace(issue_number=11235, pr_number=11243)
|
|
stderr = io.StringIO()
|
|
|
|
with contextlib.redirect_stderr(stderr):
|
|
with self.assertRaises(SystemExit) as error:
|
|
gh.cmd_link_issue(args)
|
|
|
|
self.assertEqual(error.exception.code, 1)
|
|
self.assertIn("link missing", stderr.getvalue())
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main(verbosity=2)
|