mirror of
https://github.com/penpot/penpot.git
synced 2026-11-20 09:00:49 +00:00
On the SVG renderer, opening a page measures auto-grow text copies with overridden content and writes back their size and position data when they drifted. The write went through the normal text commits, which stack onto the user's last undo entry. So the first Ctrl+Z after opening a page also reverted the heal. A component sync also set the position data of a copy to nil, even for a fill change on the main. Such a copy skipped the check and went through the normal path, with undo. Heal requests now take :save-undo? false. resize-text and update-position-data accept optional opts, and a request with :save-undo? false marks its text as a heal for the current batch. A later user request for the same text in the batch removes that mark. The batch commit splits in two. User texts commit as before. Heal texts commit with :save-undo? false and :skip-component-sync? true, so each copy heals on its own page open instead of syncing. The heal resize asks for the parents' reflow with :save-undo? false. The layout buffer lays out heal updates apart from user ones and passes the flag to apply-modifiers, so the reflow records no undo step either. The :check phase also heals a copy without position data, with no undo. When the size drifted, the text moves to a new :settle phase. The measurement that the heal resize causes also commits without undo. Known limit: when the heal's reflow moves the text (for example, re-centering it in a flex parent), the renderer measures the text again with no phase. That position-data commit still stacks onto the last undo entry. Left for a follow-up. Tests: frontend-tests.data.workspace-heal-undo-test (SVG store) covers a heal resize with no undo, no component sync and a reflow without undo; a heal and a user change in one batch; a user request after a heal of the same text; and the layout buffer keeping a heal's reflow apart. frontend-tests.ui.viewport-texts-html-test covers the options each phase sends: drifted copy, matching copy, copy without position data, unmeasurable text, settle, and no phase. Relates to #12721 Relates to #13065 AI-assisted-by: claude-opus-5-5