mirror of
https://github.com/penpot/penpot.git
synced 2026-11-20 09:00:49 +00:00
After a font size change on a main text, the main resizes itself in a commit that stacks onto the edit's undo entry. That commit still took the group its undo transaction was opened with, and the component sync it starts inherited that group. So the sync became a separate undo entry: the first Ctrl+Z undid only that sync, the copies were measured again right away, and nothing visible changed. The user had to press Ctrl+Z twice to undo the edit. A stack-undo? commit that records undo (save-undo? and undo changes, the same test the history watcher uses) and has no undo group of its own now takes the group of the entry at the current undo index. The commits it starts, such as the component sync, inherit it, so one Ctrl+Z reverts the edit, the resize and the sync. A stacked commit that records no undo joins no entry, so it keeps a group of its own: the automatic text heals must not take the rollback unit of the user's last action. A stacked commit that joins an open transaction that already holds changes keeps the transaction's group, as append-undo adds it to the transaction. The rule for commit groups in mem:frontend/workspace-state-persistence-subtleties now includes the stacked-entry step. Tests: frontend-tests.data.workspace-undo-test covers a stacked commit with no transaction, in an empty transaction and in a transaction that already holds changes; a stacked commit that records no undo; and one undo over an edit, its stacked commit and a follow-up commit of the same group. frontend-tests.data.workspace-heal-undo-test drives the real resize-text and component watcher on a main text with a copy: one undo reverts the edit, the resize and the syncs on both. Closes #13207 Relates to #12721 Relates to #13065 AI-assisted-by: claude-opus-5-5