mirror of
https://github.com/penpot/penpot.git
synced 2026-09-24 04:46:14 +00:00
2255266d45
* ✨ Enable closed schemas for RPC methods * 🐛 Fix duplicate make-dummy-request test helper definition The branch added a variadic DummyRequest/make-dummy-request pair but left the pre-existing single-arg definition in place. Because it was loaded last, zero-arg (make-dummy-request) calls added by prepare-rpc-params and rpc-nitrate-test threw ArityException, which broke 384 tests and caused 14 downstream assertion failures. Remove the stale duplicate so the variadic definition is the only one, and drop the now-unused yrq alias and duplicate yres alias. AI-assisted-by: deepseek-v4.1-flash * ✨ Add focused tests for make-dummy-request helper Pin the call contract of make-dummy-request, which the suite uses in three styles: no arguments, a single options map, and keyword arguments. The helper's redefinition shadowing in 8ca95adb98 was only caught by a full-suite run with hundreds of unrelated errors; these tests fail locally in a focused --focus run. Cover the zero-arg defaults, map and keyword overrides, the :body-bytes -> ByteArrayInputStream wrapping, :body-stream precedence, and cookie readback. Also clarify the docstring to list all supported call styles. AI-assisted-by: deepseek-v4.1-flash * 🚑 Prevent RPC client params from overriding auth context Strip qualified keys from decoded request params before merging them with the server-built auth context, so transit bodies can no longer override ::profile-id, ::auth-type or ::token-perms. Adds a regression test proving the override and the fix. AI-assisted-by: muse-spark-1.3-contributor * 📚 Merge backend subtleties memories under generic name Rename rpc-db-worker-subtleties to subtleties and fold in http-storage-filedata-subtleties, so the name no longer enumerates topics. Update all mem: references accordingly. AI-assisted-by: muse-spark-1.3-contributor * ✨ Add realistic tests for RPC auth override Cover the transit wire vector and the real wrapped :get-profile method with two database profiles, proving a session cannot read another profile by smuggling :app.rpc/profile-id in the body. AI-assisted-by: muse-spark-1.3-contributor * ✨ Add e2e test for RPC auth context override Parametrize rpcPost with contentType, accept and query so e2e can send hand-written transit bodies without new dependencies. The new test proves a transit-smuggled :app.rpc/profile-id no longer overrides the session in get-profile. Also fix the demo email assertion in auth-flow to the current uuid format. AI-assisted-by: muse-spark-1.3-contributor
38 lines
1.5 KiB
Clojure
38 lines
1.5 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS INC Sucursal en España SL
|
|
|
|
(ns backend-tests.rpc-auth-override-test
|
|
(:require
|
|
[app.common.time :as ct]
|
|
[app.http :as-alias http]
|
|
[app.rpc :as-alias rpc]
|
|
[backend-tests.helpers :as th]
|
|
[clojure.test :as t]))
|
|
|
|
(t/use-fixtures :once th/state-init)
|
|
(t/use-fixtures :each th/database-reset)
|
|
|
|
;; --- RPC: client params cannot override the server auth context
|
|
;;
|
|
;; Exercises the real wrapped :get-profile method. The handler only
|
|
;; reads ::rpc/profile-id, and its params schema ([:map]) accepts
|
|
;; anything, so before the fix a session authenticated as A asking
|
|
;; for B's profile-id received B's profile (id + email).
|
|
|
|
(t/deftest get-profile-ignores-client-supplied-profile-id
|
|
(let [attacker (th/create-profile* 1)
|
|
victim (th/create-profile* 2)
|
|
[_ method-fn] (get-in th/*system* [:app.rpc/methods :get-profile])
|
|
;; Simulates what wrap-parse-request leaves in
|
|
;; (:params request) after a body carrying a qualified key.
|
|
body {:app.rpc/profile-id (:id victim)}
|
|
params (with-meta {::rpc/profile-id (:id attacker)
|
|
::rpc/request-at (ct/now)}
|
|
{::http/request {:params body}})
|
|
result (method-fn params)]
|
|
(t/is (= (:id attacker) (:id result)))
|
|
(t/is (= (:email attacker) (:email result)))))
|