mirror of
https://github.com/penpot/penpot.git
synced 2026-11-19 08:30:42 +00:00
* ✨ Delay building schemas in check-fn check-fn eagerly builds its schemas which contributes to the startup time. But we can delay this to when the check function is actually called, which seems to be when an edit is made. On the Travel A2B - Locofy Sample project file this reduced the time to the first viewport render by ~15%. * ✨ Make schema resolution lazy only on production builds Add a lazy-delay macro that defers the expression only on builds that set the app.common.data.macros/lazy-delay? closure define, and use it in check-fn to resolve the schema. The previous change made the schema resolution unconditionally lazy, which hid wrong schema definitions until the first check call. With this change development builds, tests and storybook resolve the schema when the namespace loads, so a bad definition fails early, and production builds keep the deferred resolution and the startup win. The define is enabled in the release builds of frontend (main and worker), exporter and library. On the JVM the expression is always evaluated immediately. AI-assisted-by: deepseek-v4.1-flash --------- Co-authored-by: Andrey Antukh <niwi@niwi.nz>
327 lines
14 KiB
Clojure
327 lines
14 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS SUBSIDIARY SL
|
|
|
|
(ns common-tests.schema-test
|
|
(:require
|
|
[app.common.data :as d]
|
|
[app.common.data.macros :as dm]
|
|
[app.common.schema :as sm]
|
|
[app.common.schema.generators :as sg]
|
|
[app.common.uuid :as uuid]
|
|
[clojure.test :as t]))
|
|
|
|
(t/deftest test-set-of-email
|
|
(t/testing "decoding"
|
|
(let [candidate1 "a@b.com a@c.net"
|
|
schema [::sm/set ::sm/email]
|
|
result1 (sm/decode schema candidate1 sm/string-transformer)
|
|
result2 (sm/decode schema candidate1 sm/json-transformer)]
|
|
(t/is (= result1 #{"a@b.com" "a@c.net"}))
|
|
(t/is (= result2 #{"a@b.com" "a@c.net"}))))
|
|
|
|
(t/testing "encoding"
|
|
(let [candidate #{"a@b.com" "a@c.net"}
|
|
schema [::sm/set ::sm/email]
|
|
result1 (sm/encode schema candidate sm/string-transformer)
|
|
result2 (sm/decode schema candidate sm/json-transformer)]
|
|
(t/is (= result1 "a@b.com, a@c.net"))
|
|
(t/is (= result2 candidate))))
|
|
|
|
(t/testing "validate"
|
|
(let [candidate #{"a@b.com" "a@c.net"}
|
|
schema [::sm/set ::sm/email]]
|
|
|
|
(t/is (true? (sm/validate schema candidate)))
|
|
(t/is (true? (sm/validate schema #{})))
|
|
(t/is (false? (sm/validate schema #{"a"})))))
|
|
|
|
(t/testing "validate 2"
|
|
(let [candidate-1 ["a@b.com" "a@c.net"]
|
|
candidate-2 (into #{} candidate-1)
|
|
candidate-3 (into (d/ordered-set) candidate-1)
|
|
candidate-4 #{"a@b.com"}
|
|
candidate-5 (d/ordered-set "a@b.com")
|
|
schema-1 [::sm/set ::sm/email]
|
|
schema-2 [::sm/set {:ordered true} ::sm/email]
|
|
schema-3 [::sm/set {:ordered true :min 1} ::sm/email]
|
|
schema-4 [::sm/set {:min 1} ::sm/email]
|
|
schema-5 [::sm/set {:ordered true :max 1} ::sm/email]
|
|
schema-6 [::sm/set {:ordered true :min 1 :max 2} ::sm/email]
|
|
schema-7 [::sm/set {:min 1 :max 2} ::sm/email]]
|
|
|
|
(t/is (false? (sm/validate schema-1 [])))
|
|
(t/is (false? (sm/validate schema-1 candidate-1)))
|
|
(t/is (true? (sm/validate schema-1 candidate-2)))
|
|
(t/is (true? (sm/validate schema-1 candidate-3)))
|
|
|
|
(t/is (false? (sm/validate schema-2 [])))
|
|
(t/is (false? (sm/validate schema-2 candidate-1)))
|
|
(t/is (false? (sm/validate schema-2 candidate-2)))
|
|
(t/is (true? (sm/validate schema-2 candidate-3)))
|
|
|
|
(t/is (false? (sm/validate schema-3 [])))
|
|
(t/is (false? (sm/validate schema-3 candidate-1)))
|
|
(t/is (false? (sm/validate schema-3 candidate-2)))
|
|
(t/is (true? (sm/validate schema-3 candidate-3)))
|
|
(t/is (false? (sm/validate schema-3 candidate-4)))
|
|
(t/is (true? (sm/validate schema-3 candidate-5)))
|
|
(t/is (false? (sm/validate schema-3 (d/ordered-set))))
|
|
|
|
(t/is (false? (sm/validate schema-4 [])))
|
|
(t/is (false? (sm/validate schema-4 candidate-1)))
|
|
(t/is (true? (sm/validate schema-4 candidate-2)))
|
|
(t/is (true? (sm/validate schema-4 candidate-3)))
|
|
(t/is (true? (sm/validate schema-4 candidate-4)))
|
|
(t/is (true? (sm/validate schema-4 candidate-5)))
|
|
(t/is (false? (sm/validate schema-4 (d/ordered-set))))
|
|
(t/is (false? (sm/validate schema-4 #{})))
|
|
|
|
(t/is (false? (sm/validate schema-5 [])))
|
|
(t/is (false? (sm/validate schema-5 candidate-1)))
|
|
(t/is (false? (sm/validate schema-5 candidate-2)))
|
|
(t/is (false? (sm/validate schema-5 candidate-3)))
|
|
(t/is (false? (sm/validate schema-5 candidate-4)))
|
|
(t/is (true? (sm/validate schema-5 candidate-5)))
|
|
(t/is (true? (sm/validate schema-5 (d/ordered-set))))
|
|
(t/is (false? (sm/validate schema-5 #{})))
|
|
|
|
(t/is (false? (sm/validate schema-6 [])))
|
|
(t/is (false? (sm/validate schema-6 candidate-1)))
|
|
(t/is (false? (sm/validate schema-6 candidate-2)))
|
|
(t/is (true? (sm/validate schema-6 candidate-3)))
|
|
(t/is (false? (sm/validate schema-6 candidate-4)))
|
|
(t/is (true? (sm/validate schema-6 candidate-5)))
|
|
(t/is (false? (sm/validate schema-6 (d/ordered-set))))
|
|
(t/is (false? (sm/validate schema-6 #{})))
|
|
(t/is (false? (sm/validate schema-6 (conj candidate-3 "r@r.com"))))
|
|
|
|
(t/is (false? (sm/validate schema-7 [])))
|
|
(t/is (false? (sm/validate schema-7 candidate-1)))
|
|
(t/is (true? (sm/validate schema-7 candidate-2)))
|
|
(t/is (true? (sm/validate schema-7 candidate-3)))
|
|
(t/is (true? (sm/validate schema-7 candidate-4)))
|
|
(t/is (true? (sm/validate schema-7 candidate-5)))
|
|
(t/is (false? (sm/validate schema-7 (d/ordered-set))))
|
|
(t/is (false? (sm/validate schema-7 #{})))
|
|
(t/is (false? (sm/validate schema-7 (conj candidate-2 "r@r.com"))))
|
|
(t/is (false? (sm/validate schema-7 (conj candidate-3 "r@r.com"))))))
|
|
|
|
(t/testing "generate"
|
|
(let [schema [::sm/set ::sm/email]
|
|
value (sg/generate schema)]
|
|
(t/is (true? (sm/validate schema (sg/generate schema)))))))
|
|
|
|
|
|
(t/deftest test-set-1
|
|
(let [candidate-1 "cff4b058-ca31-8197-8005-32aeb2377d83, cff4b058-ca31-8197-8005-32aeb2377d82"
|
|
candidate-2 ["cff4b058-ca31-8197-8005-32aeb2377d82",
|
|
"cff4b058-ca31-8197-8005-32aeb2377d83"]
|
|
candidate-3 #{"cff4b058-ca31-8197-8005-32aeb2377d82", "cff4b058-ca31-8197-8005-32aeb2377d83"}
|
|
candidate-4 [#uuid "cff4b058-ca31-8197-8005-32aeb2377d82"
|
|
#uuid "cff4b058-ca31-8197-8005-32aeb2377d83"]
|
|
candidate-5 #{#uuid "cff4b058-ca31-8197-8005-32aeb2377d82"
|
|
#uuid "cff4b058-ca31-8197-8005-32aeb2377d83"}
|
|
|
|
expected candidate-5
|
|
|
|
schema [::sm/set ::sm/uuid]
|
|
decode-s (sm/decoder schema sm/string-transformer)
|
|
decode-j (sm/decoder schema sm/json-transformer)
|
|
encode-s (sm/encoder schema sm/string-transformer)
|
|
encode-j (sm/encoder schema sm/json-transformer)]
|
|
|
|
|
|
(t/is (= expected (decode-s candidate-1)))
|
|
(t/is (= expected (decode-s candidate-2)))
|
|
(t/is (= expected (decode-s candidate-3)))
|
|
(t/is (= expected (decode-s candidate-4)))
|
|
(t/is (= expected (decode-s candidate-5)))
|
|
|
|
(t/is (= candidate-1 (encode-s expected)))
|
|
(t/is (= candidate-3 (encode-j expected)))))
|
|
|
|
|
|
(t/deftest test-vec-1
|
|
(let [candidate-1 "cff4b058-ca31-8197-8005-32aeb2377d83, cff4b058-ca31-8197-8005-32aeb2377d82"
|
|
candidate-2 ["cff4b058-ca31-8197-8005-32aeb2377d83",
|
|
"cff4b058-ca31-8197-8005-32aeb2377d82"]
|
|
candidate-3 #{"cff4b058-ca31-8197-8005-32aeb2377d82", "cff4b058-ca31-8197-8005-32aeb2377d83"}
|
|
candidate-4 [#uuid "cff4b058-ca31-8197-8005-32aeb2377d83"
|
|
#uuid "cff4b058-ca31-8197-8005-32aeb2377d82"]
|
|
candidate-5 #{#uuid "cff4b058-ca31-8197-8005-32aeb2377d82"
|
|
#uuid "cff4b058-ca31-8197-8005-32aeb2377d83"}
|
|
|
|
expected candidate-4
|
|
|
|
schema [::sm/vec ::sm/uuid]
|
|
decode-s (sm/decoder schema sm/string-transformer)
|
|
decode-j (sm/decoder schema sm/json-transformer)
|
|
encode-s (sm/encoder schema sm/string-transformer)
|
|
encode-j (sm/encoder schema sm/json-transformer)]
|
|
|
|
|
|
(t/is (= expected (decode-s candidate-1)))
|
|
(t/is (= expected (decode-s candidate-2)))
|
|
(t/is (= expected (decode-s candidate-3)))
|
|
(t/is (= expected (decode-s candidate-4)))
|
|
(t/is (= expected (decode-s candidate-5)))
|
|
|
|
(t/is (= candidate-1 (encode-s expected)))
|
|
(t/is (= candidate-2 (encode-j expected)))))
|
|
|
|
|
|
(t/deftest test-boolean
|
|
(let [decode-s (sm/decoder ::sm/boolean sm/string-transformer)]
|
|
(t/is (= true (decode-s "true")))
|
|
(t/is (= true (decode-s "True")))
|
|
(t/is (= true (decode-s "TrUe")))
|
|
(t/is (= true (decode-s "TRUE")))
|
|
(t/is (= false (decode-s "false")))
|
|
(t/is (= false (decode-s "False")))
|
|
(t/is (= false (decode-s "fAlSe")))
|
|
(t/is (= false (decode-s "FALSE")))
|
|
|
|
(t/is (= true (decode-s "T")))
|
|
(t/is (= false (decode-s "F")))
|
|
(t/is (= true (decode-s "t")))
|
|
(t/is (= false (decode-s "f")))
|
|
(t/is (= true (decode-s "1")))
|
|
(t/is (= false (decode-s "0")))))
|
|
|
|
(t/deftest test-email-validation
|
|
(t/testing "accepts well-formed email addresses"
|
|
(doseq [email ["user@domain.com"
|
|
"user.name@domain.com"
|
|
"user+tag@domain.com"
|
|
"user-name@domain.com"
|
|
"user_name@domain.com"
|
|
"user123@domain.com"
|
|
"USER@DOMAIN.COM"
|
|
"u@domain.io"
|
|
"user@sub.domain.com"
|
|
"user@domain.co.uk"
|
|
"user@domain.dev"
|
|
"a@bc.co"]]
|
|
(t/is (sm/validate ::sm/email email) (str "should accept: " email))
|
|
(t/is (= email (sm/decode ::sm/email email sm/json-transformer)))))
|
|
|
|
(t/testing "rejects domain with consecutive dots (dot-dot)"
|
|
(t/is (false? (sm/validate ::sm/email "user@gmail.com..")))
|
|
(t/is (false? (sm/validate ::sm/email "user@sub..domain.com")))
|
|
(t/is (false? (sm/validate ::sm/email "eissaalbothigi@gmail.com..")))
|
|
(t/is (nil? (sm/parse-email "user@gmail.com..")))
|
|
(t/is (nil? (sm/parse-email "eissaalbothigi@gmail.com.."))))
|
|
|
|
(t/testing "rejects domain ending with a dot"
|
|
(t/is (false? (sm/validate ::sm/email "user@domain.")))
|
|
(t/is (nil? (sm/parse-email "user@domain."))))
|
|
|
|
(t/testing "rejects domain starting with a dot"
|
|
(t/is (false? (sm/validate ::sm/email "user@.domain.com")))
|
|
(t/is (nil? (sm/parse-email "user@.domain.com"))))
|
|
|
|
(t/testing "rejects local part with consecutive dots"
|
|
(t/is (false? (sm/validate ::sm/email "user..name@domain.com")))
|
|
(t/is (nil? (sm/parse-email "user..name@domain.com"))))
|
|
|
|
(t/testing "rejects local part starting with a dot"
|
|
(t/is (false? (sm/validate ::sm/email ".user@domain.com")))
|
|
(t/is (nil? (sm/parse-email ".user@domain.com"))))
|
|
|
|
(t/testing "rejects label starting or ending with hyphen"
|
|
(t/is (false? (sm/validate ::sm/email "user@-domain.com")))
|
|
(t/is (false? (sm/validate ::sm/email "user@domain-.com"))))
|
|
|
|
(t/testing "rejects TLD shorter than 2 chars"
|
|
(t/is (false? (sm/validate ::sm/email "user@domain.c"))))
|
|
|
|
(t/testing "rejects domain without a dot"
|
|
(t/is (false? (sm/validate ::sm/email "user@domain"))))
|
|
|
|
(t/testing "rejects empty or malformed emails"
|
|
(t/is (false? (sm/validate ::sm/email "")))
|
|
(t/is (false? (sm/validate ::sm/email "@domain.com")))
|
|
(t/is (false? (sm/validate ::sm/email "user@")))
|
|
(t/is (false? (sm/validate ::sm/email "userdomain.com")))
|
|
(t/is (false? (sm/validate ::sm/email "user@@domain.com")))))
|
|
|
|
(t/deftest test-user-provided-uuid
|
|
(let [v4 (uuid/uuid "550e8400-e29b-41d4-a716-446655440000")
|
|
v7 (uuid/uuid "0191062e-3f50-7a5e-9f5a-1a2b3c4d5e6f")
|
|
v8 (uuid/uuid "0227df82-63d7-8016-8005-48d9c0f33011")
|
|
v1 (uuid/uuid "6ba7b810-9dad-11d1-80b4-00c04fd430c8")
|
|
v3 (uuid/uuid "6fa459ea-ee8a-3ca4-894e-db77e160355e")
|
|
v5 (uuid/uuid "886313e1-3b8a-5372-9b90-0c9aee199e5d")]
|
|
|
|
(t/testing "accepts v4, v7 and v8 instances"
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid v4)))
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid v7)))
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid v8)))
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid (uuid/random))))
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid (uuid/next)))))
|
|
|
|
(t/testing "rejects reserved and other versions"
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid v1)))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid v3)))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid v5)))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid uuid/zero)))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid nil)))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid "not-an-uuid"))))
|
|
|
|
(t/testing "decodes strings like the RPC layer does"
|
|
(let [decode (sm/decoder ::sm/user-provided-uuid sm/json-transformer)]
|
|
(t/is (= v4 (decode (str v4))))
|
|
(t/is (= v3 (decode (str v3))))
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid (decode (str v4)))))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid (decode (str v3)))))))
|
|
|
|
(t/testing "rejects raw strings without decoding, like ::sm/uuid does"
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid (str v4))))
|
|
(t/is (false? (sm/validate ::sm/user-provided-uuid (str v3)))))
|
|
|
|
(t/testing "generate"
|
|
(t/is (true? (sm/validate ::sm/user-provided-uuid (sg/generate ::sm/user-provided-uuid)))))))
|
|
|
|
(defn- catch-error
|
|
[f]
|
|
(try
|
|
(f)
|
|
nil
|
|
(catch #?(:clj Throwable :cljs :default) cause
|
|
cause)))
|
|
|
|
(defn- lazy-resolution?
|
|
"Mirrors the build mode check performed by `app.common.data.macros/lazy-delay`."
|
|
[]
|
|
#?(:clj false
|
|
:cljs dm/lazy-delay?))
|
|
|
|
(t/deftest test-check-fn
|
|
(t/testing "returns the value when it is valid"
|
|
(let [check (sm/check-fn ::sm/uuid)]
|
|
(t/is (= uuid/zero (check uuid/zero)))))
|
|
|
|
(t/testing "raises with the explain data when the value is invalid"
|
|
(let [check (sm/check-fn ::sm/uuid :hint "invalid uuid"
|
|
:type :custom :code :custom-code)
|
|
cause (catch-error #(check "not-a-uuid"))
|
|
data (ex-data cause)]
|
|
(t/is (some? cause))
|
|
(t/is (= "invalid uuid" (ex-message cause)))
|
|
(t/is (= :custom (:type data)))
|
|
(t/is (= :custom-code (:code data)))
|
|
(t/is (= "invalid uuid" (:hint data)))
|
|
(t/is (map? (::sm/explain data)))))
|
|
|
|
(t/testing "resolves the schema definition according to the build mode"
|
|
;; A schema that does not exist raises only when it is resolved, so this
|
|
;; checks when the resolution happens: on `check-fn` on non production
|
|
;; builds, on the first call of the returned function on production ones.
|
|
(let [check (catch-error #(sm/check-fn ::unknown-schema))]
|
|
(if (lazy-resolution?)
|
|
(t/is (some? (catch-error #(check ::anything))))
|
|
(t/is (some? check))))))
|