mirror of
https://github.com/penpot/penpot.git
synced 2026-08-28 07:38:42 +00:00
03cd3fa70f
* ✨ Auto-link libraries during import based on slugified name When a Penpot file is exported without bundled libraries and then imported into a different environment, external library links are broken because library UUIDs differ across environments. This feature adds a heuristic to auto-relink libraries by matching slugified library names against shared files in the target team: - Export: embed external library metadata (id, name, slug, used-by) in the manifest when libraries are not included in the export. - Import: resolve external libraries by slugifying shared file names in the destination team and matching against manifest slugs. - Single match: auto-link silently (creates file-library-rel row). - Multiple matches: emit SSE event so the frontend shows a selection dialog for the user to pick the correct library. - No match: import continues without linking (current behavior). Backend changes: - Extended manifest schema with optional :external-libraries field - Added slugify-name, get-files-names, get-shared-files-for-team, find-shared-files-by-slug helpers in app.binfile.common - Threaded team-id into import cfg from RPC layer - Added resolve-external-libraries and auto-link-libraries in v3 - Emit :library-candidates SSE event for multi-match cases Frontend changes: - Worker captures library-candidates SSE events and forwards them - Import dialog shows auto-link notification and multi-match selection UI with select dropdowns - Added link-files-to-library! RPC helper for user selections - Added en/es translations for new UI strings Closes #9263 Signed-off-by: Andrey Antukh <niwi@niwi.nz> * ✨ Add UI for the auto-link plumbing * ♻️ Consolidate auto-link libraries with unified export-type and fix ref integrity Consolidates the auto-link libraries feature into a single coherent implementation: - Unify boolean flags (embed-assets, include-libraries, link-later) into single ::bfc/export-type parameter - Fix critical reference-integrity bug: pre-resolution no longer remaps :component-file refs when no link is created (multi-match / no-permission) - compute-link-decisions as single source of truth for auto-link logic - 80+ backend tests covering round-trip, cross-team, permissions, edge cases, and reference integrity AI-assisted-by: longcat-2.0 --------- Signed-off-by: Andrey Antukh <niwi@niwi.nz> Co-authored-by: Eva Marco <evamarcod@gmail.com>
1886 lines
81 KiB
Clojure
1886 lines
81 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS SUBSIDIARY SL
|
|
|
|
(ns backend-tests.binfile-test
|
|
"Internal binfile test, no RPC involved"
|
|
(:require
|
|
[app.binfile.common :as bfc]
|
|
[app.binfile.v1 :as v1]
|
|
[app.binfile.v3 :as v3]
|
|
[app.common.data :as d]
|
|
[app.common.features :as cfeat]
|
|
[app.common.files.validate :as cfv]
|
|
[app.common.pprint :as pp]
|
|
[app.common.thumbnails :as thc]
|
|
[app.common.time :as ct]
|
|
[app.common.types.shape :as cts]
|
|
[app.common.uuid :as uuid]
|
|
[app.config :as cf]
|
|
[app.db :as db]
|
|
[app.db.sql :as sql]
|
|
[app.http :as http]
|
|
[app.rpc :as-alias rpc]
|
|
[app.rpc.commands.binfile :as binfile]
|
|
[app.storage :as sto]
|
|
[app.storage.tmp :as tmp]
|
|
[backend-tests.helpers :as th]
|
|
[clojure.test :as t]
|
|
[cuerdas.core :as str]
|
|
[datoteka.fs :as fs]
|
|
[datoteka.io :as io])
|
|
(:import
|
|
java.io.ByteArrayInputStream
|
|
java.io.DataInputStream))
|
|
|
|
(t/use-fixtures :once th/state-init)
|
|
(t/use-fixtures :each th/database-reset)
|
|
|
|
(defn- update-file!
|
|
[& {:keys [profile-id file-id changes revn] :or {revn 0}}]
|
|
(let [params {::th/type :update-file
|
|
::rpc/profile-id profile-id
|
|
:id file-id
|
|
:session-id (uuid/random)
|
|
:revn revn
|
|
:vern 0
|
|
:features cfeat/supported-features
|
|
:changes changes}
|
|
out (th/command! params)]
|
|
;; (th/print-result! out)
|
|
(t/is (nil? (:error out)))
|
|
(:result out)))
|
|
|
|
(defn- prepare-simple-file
|
|
[profile]
|
|
(let [page-id-1 (uuid/custom 1 1)
|
|
page-id-2 (uuid/custom 1 2)
|
|
shape-id (uuid/custom 2 1)
|
|
file (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
(update-file!
|
|
:file-id (:id file)
|
|
:profile-id (:id profile)
|
|
:revn 0
|
|
:vern 0
|
|
:changes
|
|
[{:type :add-page
|
|
:name "test 1"
|
|
:id page-id-1}
|
|
{:type :add-page
|
|
:name "test 2"
|
|
:id page-id-2}])
|
|
|
|
(update-file!
|
|
:file-id (:id file)
|
|
:profile-id (:id profile)
|
|
:revn 0
|
|
:vern 0
|
|
:changes
|
|
[{:type :add-obj
|
|
:page-id page-id-1
|
|
:id shape-id
|
|
:parent-id uuid/zero
|
|
:frame-id uuid/zero
|
|
:components-v2 true
|
|
:obj (cts/setup-shape
|
|
{:id shape-id
|
|
:name "image"
|
|
:frame-id uuid/zero
|
|
:parent-id uuid/zero
|
|
:type :rect})}])
|
|
|
|
(dissoc file :data)))
|
|
|
|
(def ^:private svg-raw-page-id (uuid/custom 1 1))
|
|
(def ^:private svg-raw-root-id (uuid/custom 3 1))
|
|
(def ^:private svg-raw-child-id (uuid/custom 3 2))
|
|
|
|
(defn- prepare-svg-raw-file
|
|
"A file containing an svg-raw subtree (an svg-raw parent with an
|
|
svg-raw child), which is what importing an SVG produces."
|
|
[profile]
|
|
(let [page-id svg-raw-page-id
|
|
root-id svg-raw-root-id
|
|
child-id svg-raw-child-id
|
|
|
|
file (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
(update-file!
|
|
:file-id (:id file)
|
|
:profile-id (:id profile)
|
|
:revn 0
|
|
:vern 0
|
|
:changes
|
|
[{:type :add-page
|
|
:name "page 1"
|
|
:id page-id}])
|
|
|
|
(update-file!
|
|
:file-id (:id file)
|
|
:profile-id (:id profile)
|
|
:revn 0
|
|
:vern 0
|
|
:changes
|
|
[{:type :add-obj
|
|
:page-id page-id
|
|
:id root-id
|
|
:parent-id uuid/zero
|
|
:frame-id uuid/zero
|
|
:components-v2 true
|
|
:obj (cts/setup-shape
|
|
{:id root-id
|
|
:name "svg-root"
|
|
:frame-id uuid/zero
|
|
:parent-id uuid/zero
|
|
:type :svg-raw
|
|
:content {:tag :svg :attrs {} :content []}})}
|
|
{:type :add-obj
|
|
:page-id page-id
|
|
:id child-id
|
|
:parent-id root-id
|
|
:frame-id uuid/zero
|
|
:components-v2 true
|
|
:obj (cts/setup-shape
|
|
{:id child-id
|
|
:name "svg-text"
|
|
:frame-id uuid/zero
|
|
:parent-id root-id
|
|
:type :svg-raw
|
|
:content {:tag :text :attrs {} :content []}})}])
|
|
|
|
(dissoc file :data)))
|
|
|
|
(t/deftest import-binfile-v3-preserves-svg-raw-children
|
|
(let [profile (th/create-profile* 1)
|
|
file (prepare-svg-raw-file profile)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :detach-libraries))
|
|
(io/output-stream output))
|
|
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
file-id (first (:file-ids result))
|
|
imported (:result (th/command! {::th/type :get-file
|
|
::rpc/profile-id (:id profile)
|
|
:id file-id
|
|
:components-v2 true}))
|
|
root (get-in imported [:data :pages-index svg-raw-page-id
|
|
:objects svg-raw-root-id])]
|
|
|
|
(t/is (= 1 (count (:file-ids result))))
|
|
|
|
;; The child ids of an svg-raw shape must survive the JSON round
|
|
;; trip as uuids; when they came back as plain strings they no
|
|
;; longer resolved against the objects map.
|
|
(t/is (every? uuid? (:shapes root)))
|
|
(t/is (= [svg-raw-child-id] (vec (:shapes root))))
|
|
|
|
;; ...so the imported file passes referential integrity instead
|
|
;; of failing with :child-not-found on the next update-file.
|
|
(t/is (nil? (cfv/validate-file imported []))))))
|
|
|
|
(t/deftest export-binfile-v3
|
|
(let [profile (th/create-profile* 1)
|
|
file (prepare-simple-file profile)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :detach-libraries))
|
|
(io/output-stream output))
|
|
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
(t/is (map? result))
|
|
(t/is (= 1 (count (:file-ids result))))
|
|
(t/is (every? uuid? (:file-ids result)))
|
|
;; No external libraries in simple case - resolution should be empty
|
|
(t/is (= {} (:resolution result))))))
|
|
|
|
(t/deftest export-binfile-preserves-public-uri-subpath
|
|
(let [profile (th/create-profile* 1)
|
|
file (prepare-simple-file profile)
|
|
config (assoc cf/config :public-uri "https://example.com/penpot")
|
|
params {:file-id (:id file)
|
|
::bfc/export-type :detach-libraries}
|
|
uri (binding [cf/config config]
|
|
(#'binfile/export-binfile th/*system* params))]
|
|
(t/is (str/starts-with? (str uri)
|
|
"https://example.com/penpot/assets/by-id/"))))
|
|
|
|
(t/deftest import-binfile-v3-persists-manifest-metadata
|
|
(let [profile (th/create-profile* 1)
|
|
file (prepare-simple-file profile)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :detach-libraries))
|
|
(io/output-stream output))
|
|
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
imported (bfc/get-file th/*system* (first (:file-ids result)))]
|
|
|
|
(t/is (= 1 (count (:file-ids result))))
|
|
(t/is (some? (get-in imported [:metadata :generated-by])))
|
|
(t/is (= "penpot" (get-in imported [:metadata :referer]))))))
|
|
|
|
(t/deftest read-obj-rejects-oversized-buffer
|
|
;; N1-07: read-obj! must reject objects exceeding max-object-size
|
|
;; before attempting to allocate the buffer
|
|
(let [size (+ bfc/max-object-size 1)
|
|
baos (java.io.ByteArrayOutputStream. 17)
|
|
dos (java.io.DataOutputStream. baos)]
|
|
(.writeByte dos 5)
|
|
(.writeLong dos (long size))
|
|
(.flush dos)
|
|
(let [input (java.io.DataInputStream.
|
|
(ByteArrayInputStream. (.toByteArray baos)))]
|
|
(binding [v1/*position* (atom 0)]
|
|
(let [out (try
|
|
(v1/read-obj! input)
|
|
nil
|
|
(catch clojure.lang.ExceptionInfo e
|
|
(ex-data e)))]
|
|
;; Without the guard, read-obj! will either OOM or proceed
|
|
;; to read-bytes! on a truncated stream (no :max-file-size-reached).
|
|
;; With the guard, it raises :validation :max-file-size-reached.
|
|
(t/is (= :validation (:type out)))
|
|
(t/is (= :max-file-size-reached (:code out))))))))
|
|
|
|
(t/deftest slugify-name-test
|
|
(t/is (= "my-design-system" (bfc/slugify-name "My Design System!")))
|
|
(t/is (= "icons" (bfc/slugify-name "Icons")))
|
|
(t/is (= "brand-colors-2024" (bfc/slugify-name "Brand Colors 2024")))
|
|
(t/is (= "" (bfc/slugify-name "---"))))
|
|
|
|
(t/deftest export-includes-external-libraries
|
|
(let [profile (th/create-profile* 1)
|
|
;; Create a shared library file
|
|
library (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
;; Create a file that uses the library
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Link file to library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file)
|
|
:library-file-id (:id library)})
|
|
|
|
;; Export without including libraries
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Read the manifest and check external-libraries
|
|
(let [manifest (v3/get-manifest output)]
|
|
(t/is (some? (:external-libraries manifest)))
|
|
(t/is (= 1 (count (:external-libraries manifest))))
|
|
(let [ext-lib (first (:external-libraries manifest))]
|
|
(t/is (= (:id library) (:id ext-lib)))
|
|
(t/is (= "Icons Library" (:name ext-lib)))
|
|
(t/is (= "icons-library" (:slug ext-lib)))
|
|
(t/is (= [(:id file)] (:used-by ext-lib))))))))
|
|
|
|
(t/deftest import-auto-links-single-candidate
|
|
(let [profile (th/create-profile* 1)
|
|
;; Create a shared library file
|
|
library (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
;; Create a file that uses the library
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Link file to library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file)
|
|
:library-file-id (:id library)})
|
|
|
|
;; Export without including libraries
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Remove the source library to simulate a cross-environment import
|
|
;; where the original library does not exist in the target team.
|
|
(db/update! th/*system* :file
|
|
{:deleted-at (ct/now)}
|
|
{:id (:id library)})
|
|
|
|
;; Now create a new shared library with the same name in the same team
|
|
;; (simulating the library existing in the target environment)
|
|
(let [library2 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:default-team-id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
|
|
;; Check that the library was auto-linked in the resolution
|
|
(let [resolution (:resolution result)
|
|
file-id (first (:file-ids result))
|
|
file-res (get resolution file-id)]
|
|
;; File should have name
|
|
(t/is (some? (:name file-res)))
|
|
;; File should have one auto-linked library in :done
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(let [done-entry (first (:done file-res))]
|
|
(t/is (= (:id library) (:id done-entry)))
|
|
(t/is (= (:id library2) (:linked-to done-entry))))
|
|
;; No pending candidates
|
|
(t/is (= [] (:pending file-res))))
|
|
|
|
;; Verify the file-library-rel was created
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library2)})]
|
|
(t/is (= 1 (count rels))))))))
|
|
|
|
(t/deftest import-no-auto-link-no-match
|
|
(let [profile (th/create-profile* 1)
|
|
;; Create a shared library file
|
|
library (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
;; Create a file that uses the library
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Link file to library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file)
|
|
:library-file-id (:id library)})
|
|
|
|
;; Export without including libraries
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :detach-libraries))
|
|
(io/output-stream output))
|
|
|
|
;; Remove the source library to simulate a cross-environment import
|
|
;; where no matching library exists in the target team.
|
|
(db/update! th/*system* :file
|
|
{:deleted-at (ct/now)}
|
|
{:id (:id library)})
|
|
|
|
;; Import without any matching library in the team
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:default-team-id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
|
|
;; No auto-linking should happen - resolution should be empty
|
|
(t/is (= {} (:resolution result)))))))
|
|
|
|
(t/deftest import-returns-multi-match-candidates
|
|
(let [profile (th/create-profile* 1)
|
|
;; Create a shared library file
|
|
library (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
;; Create a file that uses the library
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Link file to library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file)
|
|
:library-file-id (:id library)})
|
|
|
|
;; Export without including libraries
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Remove the source library to simulate a cross-environment import
|
|
;; where the original library does not exist in the target team.
|
|
(db/update! th/*system* :file
|
|
{:deleted-at (ct/now)}
|
|
{:id (:id library)})
|
|
|
|
;; Create TWO shared libraries with the same name
|
|
(let [library2 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
library3 (th/create-file* 4 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:default-team-id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
|
|
;; No auto-linking (multi-match) - check resolution structure
|
|
(let [resolution (:resolution result)
|
|
file-id (first (:file-ids result))
|
|
file-res (get resolution file-id)]
|
|
;; File should have name
|
|
(t/is (some? (:name file-res)))
|
|
;; No auto-linked libraries
|
|
(t/is (= [] (:done file-res)))
|
|
;; Should have pending candidates
|
|
(t/is (= 1 (count (:pending file-res))))
|
|
(let [pending-entry (first (:pending file-res))]
|
|
(t/is (= (:id library) (:id pending-entry)))
|
|
(t/is (= 2 (count (:candidates pending-entry))))
|
|
;; Each candidate should have project info
|
|
(doseq [candidate (:candidates pending-entry)]
|
|
(t/is (some? (:project-id candidate)))
|
|
(t/is (some? (:project-name candidate))))))
|
|
|
|
;; No file-library-rel should be created automatically
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library2)})]
|
|
(t/is (= 0 (count rels))))
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library3)})]
|
|
(t/is (= 0 (count rels))))))))
|
|
|
|
(t/deftest import-auto-link-respects-library-permissions
|
|
(let [owner (th/create-profile* 1)
|
|
team (th/create-team* 1 {:profile-id (:id owner)})
|
|
viewer (th/create-profile* 2)
|
|
_ (th/create-team-role* {:team-id (:id team)
|
|
:profile-id (:id viewer)
|
|
:role :viewer})
|
|
|
|
library (th/create-file* 1 {:profile-id (:id owner)
|
|
:project-id (:default-project-id owner)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file (th/create-file* 2 {:profile-id (:id owner)
|
|
:project-id (:default-project-id owner)
|
|
:is-shared false})]
|
|
|
|
;; Link file to library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file)
|
|
:library-file-id (:id library)})
|
|
|
|
;; Export with link-later to compute external-libraries
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Remove the source library and recreate a matching one owned by owner
|
|
(db/update! th/*system* :file
|
|
{:deleted-at (ct/now)}
|
|
{:id (:id library)})
|
|
|
|
;; Create a project in the team for the matched library and import.
|
|
(let [project (th/create-project* 1 {:profile-id (:id owner)
|
|
:team-id (:id team)})
|
|
|
|
library2 (th/create-file* 3 {:profile-id (:id owner)
|
|
:project-id (:id project)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:id project))
|
|
(assoc ::bfc/profile-id (:id viewer))
|
|
(assoc ::bfc/team-id (:id team))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
|
|
;; Auto-link must be skipped because viewer cannot edit the library
|
|
(let [resolution (:resolution result)
|
|
file-id (first (:file-ids result))
|
|
file-res (get resolution file-id)]
|
|
;; No auto-linked libraries - file may not be in resolution map at all
|
|
(t/is (or (nil? file-res)
|
|
(= [] (:done file-res)))))
|
|
|
|
;; No file-library-rel should have been created
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library2)})]
|
|
(t/is (= 0 (count rels))))
|
|
|
|
;; Control: the same import performed by the owner (who has edit
|
|
;; permission on the library) should auto-link.
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:id project))
|
|
(assoc ::bfc/profile-id (:id owner))
|
|
(assoc ::bfc/team-id (:id team))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
|
|
(let [resolution (:resolution result)
|
|
file-id (first (:file-ids result))
|
|
file-res (get resolution file-id)]
|
|
;; Should have name
|
|
(t/is (some? (:name file-res)))
|
|
;; Should have one auto-linked library
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= (:id library2) (:linked-to (first (:done file-res))))))
|
|
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library2)})]
|
|
(t/is (= 1 (count rels)))))))))
|
|
|
|
(t/deftest import-auto-link-only-files-that-used-library
|
|
(let [profile (th/create-profile* 1)
|
|
library (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file1 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})
|
|
file2 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Only file1 uses the library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file1)
|
|
:library-file-id (:id library)})
|
|
|
|
;; Export both files without including libraries
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file1) (:id file2)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Remove the source library and recreate a matching one
|
|
(db/update! th/*system* :file
|
|
{:deleted-at (ct/now)}
|
|
{:id (:id library)})
|
|
|
|
(let [library2 (th/create-file* 4 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:default-team-id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
|
|
;; The library should be auto-linked for the file that used it
|
|
(let [resolution (:resolution result)
|
|
;; Find the file that has auto-linked libraries
|
|
file-with-done (d/seek #(seq (:done %)) (vals resolution))]
|
|
(t/is (some? file-with-done))
|
|
;; Should have name
|
|
(t/is (some? (:name file-with-done)))
|
|
(t/is (= 1 (count (:done file-with-done))))
|
|
(t/is (= (:id library2) (:linked-to (first (:done file-with-done)))))
|
|
|
|
;; But only one file-library-rel should exist (for file1)
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library2)})]
|
|
(t/is (= 1 (count rels)))))))))
|
|
|
|
;; =============================================================================
|
|
;; COMPREHENSIVE LINK-LATER TESTS
|
|
;; =============================================================================
|
|
|
|
(defn- import-sample-file
|
|
"Import the file-with-library.penpot sample file and return
|
|
{:profile :file :library :team}. The sample contains a library and
|
|
a file that uses it."
|
|
([]
|
|
(import-sample-file th/*system*))
|
|
([system]
|
|
(let [profile (th/create-profile* system 1 {})
|
|
input (th/tempfile "backend_tests/test_files/file-with-library.penpot")
|
|
result (-> system
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:default-team-id profile))
|
|
(assoc ::bfc/input input)
|
|
(v3/import-files!))
|
|
file-ids (:file-ids result)
|
|
;; Find the file-library-rel to identify which id is the file
|
|
;; and which is the library. Relation: file-id -> library-file-id.
|
|
rels (keep #(when-let [r (db/query system :file-library-rel
|
|
{:file-id %})]
|
|
(first r))
|
|
file-ids)
|
|
rel (first rels)
|
|
file-id (:file-id rel)
|
|
library-id (:library-file-id rel)]
|
|
{:profile profile
|
|
:file-id file-id
|
|
:library-id library-id
|
|
:all-file-ids (set file-ids)
|
|
:team-id (:default-team-id profile)})))
|
|
|
|
(defn- create-named-library
|
|
"Create a shared library with the given name in the given team."
|
|
([team-id name]
|
|
(create-named-library th/*system* 1 team-id name))
|
|
([system i team-id name]
|
|
(let [profile (th/create-profile* system i {})
|
|
project (th/create-project* system i {:profile-id (:id profile)
|
|
:team-id team-id})]
|
|
(th/create-file* system i {:profile-id (:id profile)
|
|
:project-id (:id project)
|
|
:is-shared true
|
|
:name name}))))
|
|
|
|
(defn- get-file-shapes
|
|
"Get all shapes from a file's data."
|
|
[file-data]
|
|
(let [pages (vals (:pages-index file-data))]
|
|
(mapcat vals (map :objects pages))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 1: Same-Team Round-Trip
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-same-team-round-trip
|
|
(let [{:keys [profile file-id team-id]} (import-sample-file)
|
|
_ (t/is (some? file-id))
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Verify manifest has external-libraries
|
|
(let [manifest (v3/get-manifest output)
|
|
ext-libs (:external-libraries manifest)]
|
|
(t/is (some? ext-libs))
|
|
(t/is (pos? (count ext-libs))))
|
|
|
|
;; Re-import in same team
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Should have auto-linked library
|
|
(t/is (some? file-res))
|
|
(t/is (some? (:name file-res)))
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= [] (:pending file-res)))
|
|
|
|
;; Verify file-library-rel was created
|
|
(let [rels (db/query th/*system* :file-library-rel {:file-id new-file-id})]
|
|
(t/is (pos? (count rels)))))))
|
|
|
|
(t/deftest link-later-same-team-idempotent
|
|
(let [{:keys [profile file-id team-id]} (import-sample-file)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; First import
|
|
(let [result1 (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
(t/is (= 1 (count (:file-ids result1)))))
|
|
|
|
;; Second import (should succeed)
|
|
(let [result2 (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
(t/is (= 1 (count (:file-ids result2))))
|
|
(let [resolution (:resolution result2)
|
|
new-file-id (first (:file-ids result2))
|
|
file-res (get resolution new-file-id)]
|
|
(t/is (some? file-res))
|
|
(t/is (= 1 (count (:done file-res))))))))
|
|
|
|
(t/deftest link-later-overwrite-import-no-resolution
|
|
(let [{:keys [profile file-id team-id]} (import-sample-file)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import with overwrite (file-id set)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/file-id file-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
;; Overwrite should have empty resolution
|
|
(t/is (= {} (:resolution result))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 2: Cross-Team Migration
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-cross-team-library-pre-exists
|
|
(let [{:keys [profile file-id team-id]} (import-sample-file)
|
|
;; Create a second team with a library named "LIbrary"
|
|
team2 (th/create-team* 2 {:profile-id (:id profile)})
|
|
library2 (create-named-library th/*system* 10 (:id team2) "LIbrary")
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later from team 1
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import in team 2 (where library with same name exists)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:id team2))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Should auto-link to library2
|
|
(t/is (some? file-res))
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= (:id library2) (:linked-to (first (:done file-res)))))
|
|
|
|
;; Verify file-library-rel was created
|
|
(let [rels (db/query th/*system* :file-library-rel
|
|
{:library-file-id (:id library2)})]
|
|
(t/is (= 1 (count rels)))))))
|
|
|
|
(t/deftest link-later-cross-team-no-library
|
|
(let [{:keys [profile file-id]} (import-sample-file)
|
|
team2 (th/create-team* 2 {:profile-id (:id profile)})
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import in team 2 (no library exists)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:id team2))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; No linking should happen
|
|
(t/is (= {} resolution)))))
|
|
|
|
(t/deftest link-later-cross-team-different-library-name
|
|
(let [{:keys [profile file-id]} (import-sample-file)
|
|
team2 (th/create-team* 2 {:profile-id (:id profile)})
|
|
library2 (create-named-library th/*system* 10 (:id team2) "Buttons Library")
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import in team 2 (library with different name)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:id team2))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; No linking (slug mismatch)
|
|
(t/is (= {} resolution)))))
|
|
|
|
(t/deftest link-later-cross-team-library-not-shared
|
|
(let [{:keys [profile file-id]} (import-sample-file)
|
|
team2 (th/create-team* 2 {:profile-id (:id profile)})
|
|
;; Create a private (non-shared) library
|
|
_ (let [priv-project (th/create-project* th/*system* 20 {:profile-id (:id profile)
|
|
:team-id (:id team2)})
|
|
priv-lib (th/create-file* th/*system* 21 {:profile-id (:id profile)
|
|
:project-id (:id priv-project)
|
|
:is-shared false
|
|
:name "LIbrary"})])
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import in team 2 (library exists but not shared)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:id team2))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; No linking (library not shared)
|
|
(t/is (= {} resolution)))))
|
|
|
|
(t/deftest link-later-cross-team-library-deleted
|
|
(let [{:keys [profile file-id]} (import-sample-file)
|
|
team2 (th/create-team* 2 {:profile-id (:id profile)})
|
|
library2 (create-named-library th/*system* 10 (:id team2) "LIbrary")
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete the library in team 2
|
|
(db/update! th/*system* :file
|
|
{:deleted-at (ct/now)}
|
|
{:id (:id library2)})
|
|
|
|
;; Import in team 2 (library deleted)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:id team2))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; No linking (library deleted)
|
|
(t/is (= {} resolution)))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 3: Multiple Libraries
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-multiple-libraries-both-match
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
;; Create two libraries
|
|
lib1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
;; Create file linked to both
|
|
file (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Link file to both libraries
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib1)})
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib2)})
|
|
|
|
;; Export with link-later
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original libraries
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib1)})
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib2)})
|
|
|
|
;; Create new libraries with same names
|
|
(let [lib1b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib2b (th/create-file* 11 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Both libraries should be auto-linked
|
|
(t/is (some? file-res))
|
|
(t/is (= 2 (count (:done file-res))))
|
|
(t/is (= [] (:pending file-res)))
|
|
|
|
;; Verify both linked-to ids
|
|
(let [linked-ids (set (map :linked-to (:done file-res)))]
|
|
(t/is (contains? linked-ids (:id lib1b)))
|
|
(t/is (contains? linked-ids (:id lib2b))))))))
|
|
|
|
(t/deftest link-later-multiple-libraries-one-matches
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
file (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib1)})
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib2)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete both libraries
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib1)})
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib2)})
|
|
|
|
;; Only recreate Icons (not Colors)
|
|
(let [lib1b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Only Icons should be auto-linked
|
|
(t/is (some? file-res))
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= (:id lib1b) (:linked-to (first (:done file-res)))))))))
|
|
|
|
(t/deftest link-later-multiple-libraries-both-multi-match
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
file (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib1)})
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib2)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original libraries
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib1)})
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib2)})
|
|
|
|
;; Create TWO of each library (multi-match)
|
|
(let [_ (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
_ (th/create-file* 11 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
_ (th/create-file* 12 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
_ (th/create-file* 13 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Both libraries should be pending (multi-match)
|
|
(t/is (some? file-res))
|
|
(t/is (= [] (:done file-res)))
|
|
(t/is (= 2 (count (:pending file-res))))
|
|
|
|
;; Each pending should have 2 candidates
|
|
(doseq [pending-entry (:pending file-res)]
|
|
(t/is (= 2 (count (:candidates pending-entry)))))))))
|
|
|
|
(t/deftest link-later-multiple-libraries-mixed-single-and-multi
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib1 (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib2 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
file (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib1)})
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib2)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original libraries
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib1)})
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib2)})
|
|
|
|
;; Create ONE Icons (single match) and TWO Colors (multi-match)
|
|
(let [lib1b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
_ (th/create-file* 11 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
_ (th/create-file* 12 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Icons done, Colors pending
|
|
(t/is (some? file-res))
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= (:id lib1b) (:linked-to (first (:done file-res)))))
|
|
(t/is (= 1 (count (:pending file-res))))
|
|
(t/is (= 2 (count (:candidates (first (:pending file-res))))))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 4: Multiple Files
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-multiple-files-same-library
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file1 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})
|
|
file2 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Both files use the library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file1) :library-file-id (:id lib)})
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file2) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file1) (:id file2)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original library and recreate
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib)})
|
|
(let [lib-b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; Both files should have auto-linked
|
|
(t/is (= 2 (count (keys resolution))))
|
|
(doseq [[file-id file-res] resolution]
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= (:id lib-b) (:linked-to (first (:done file-res))))))))))
|
|
|
|
(t/deftest link-later-multiple-files-only-one-uses-library
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file1 (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})
|
|
file2 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; Only file1 uses the library
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file1) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file1) (:id file2)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original library and recreate
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib)})
|
|
(let [lib-b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; Only file1 should have auto-linked
|
|
(let [files-with-done (filter #(seq (:done (val %))) resolution)]
|
|
(t/is (= 1 (count files-with-done)))
|
|
(let [[file-id file-res] (first files-with-done)]
|
|
(t/is (= (:id lib-b) (:linked-to (first (:done file-res)))))))))))
|
|
|
|
(t/deftest link-later-multiple-files-different-libraries
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib-icons (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib-colors (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
file1 (th/create-file* 3 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})
|
|
file2 (th/create-file* 4 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
;; file1 uses Icons, file2 uses Colors
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file1) :library-file-id (:id lib-icons)})
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file2) :library-file-id (:id lib-colors)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file1) (:id file2)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original libraries and recreate
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib-icons)})
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib-colors)})
|
|
(let [lib-icons-b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
lib-colors-b (th/create-file* 11 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Colors Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)]
|
|
|
|
;; Each file should have its respective library
|
|
(t/is (= 2 (count (keys resolution))))
|
|
(doseq [[file-id file-res] resolution]
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(let [linked-id (:linked-to (first (:done file-res)))]
|
|
(t/is (or (= linked-id (:id lib-icons-b))
|
|
(= linked-id (:id lib-colors-b))))))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 5: Permission Scenarios
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-permission-viewer-cannot-link
|
|
(let [owner (th/create-profile* 1)
|
|
team (th/create-team* 1 {:profile-id (:id owner)})
|
|
viewer (th/create-profile* 2)
|
|
_ (th/create-team-role* {:team-id (:id team)
|
|
:profile-id (:id viewer)
|
|
:role :viewer})
|
|
project (th/create-project* 1 {:profile-id (:id owner)
|
|
:team-id (:id team)})
|
|
lib (th/create-file* 1 {:profile-id (:id owner)
|
|
:project-id (:id project)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file (th/create-file* 2 {:profile-id (:id owner)
|
|
:project-id (:id project)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import as viewer (no edit permission on library)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:id project))
|
|
(assoc ::bfc/profile-id (:id viewer))
|
|
(assoc ::bfc/team-id (:id team))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; No auto-link (viewer lacks edit permission)
|
|
(t/is (or (nil? file-res)
|
|
(= [] (:done file-res))))))))
|
|
|
|
(t/deftest link-later-permission-editor-can-link
|
|
(let [owner (th/create-profile* 1)
|
|
team (th/create-team* 1 {:profile-id (:id owner)})
|
|
editor (th/create-profile* 2)
|
|
_ (th/create-team-role* {:team-id (:id team)
|
|
:profile-id (:id editor)
|
|
:role :editor})
|
|
project (th/create-project* 1 {:profile-id (:id owner)
|
|
:team-id (:id team)})
|
|
lib (th/create-file* 1 {:profile-id (:id owner)
|
|
:project-id (:id project)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file (th/create-file* 2 {:profile-id (:id owner)
|
|
:project-id (:id project)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import as editor (has edit permission)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:id project))
|
|
(assoc ::bfc/profile-id (:id editor))
|
|
(assoc ::bfc/team-id (:id team))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Auto-link should succeed
|
|
(t/is (some? file-res))
|
|
(t/is (= 1 (count (:done file-res))))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 6: Edge Cases
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-edge-special-chars-in-name
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons & Buttons!"})
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Verify slug in manifest
|
|
(let [manifest (v3/get-manifest output)
|
|
ext-lib (first (:external-libraries manifest))]
|
|
(t/is (= "icons-buttons" (:slug ext-lib)))))))
|
|
|
|
(t/deftest link-later-edge-empty-slug-library
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
;; Library name that slugifies to empty
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "---"})
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Library with empty slug should be dropped from external-libraries
|
|
(let [manifest (v3/get-manifest output)
|
|
ext-libs (:external-libraries manifest)]
|
|
(t/is (or (nil? ext-libs)
|
|
(empty? ext-libs)))))))
|
|
|
|
(t/deftest link-later-edge-file-without-libraries
|
|
(let [profile (th/create-profile* 1)
|
|
file (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with no libraries
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Manifest should have no external-libraries
|
|
(let [manifest (v3/get-manifest output)]
|
|
(t/is (nil? (:external-libraries manifest))))
|
|
|
|
;; Import should succeed with empty resolution
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:default-team-id profile))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))]
|
|
(t/is (= {} (:resolution result))))))
|
|
|
|
(t/deftest link-later-edge-case-insensitive-match
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "ICONS Library"})
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete original and create with different case
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib)})
|
|
(let [lib-b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "icons library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Should match (slug is lowercase)
|
|
(t/is (some? file-res))
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(t/is (= (:id lib-b) (:linked-to (first (:done file-res)))))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 7: Reference Integrity
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-reference-integrity-component-file-remapped
|
|
(let [{:keys [profile file-id team-id file]} (import-sample-file)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Re-import in same team
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
new-file-id (first (:file-ids result))
|
|
resolution (:resolution result)
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Verify auto-link happened
|
|
(t/is (= 1 (count (:done file-res))))
|
|
(let [linked-lib-id (:linked-to (first (:done file-res)))]
|
|
;; Get the imported file's data
|
|
(let [imported (:result (th/command! {::th/type :get-file
|
|
::rpc/profile-id (:id profile)
|
|
:id new-file-id
|
|
:components-v2 true}))
|
|
shapes (get-file-shapes (:data imported))]
|
|
;; Check that component-file references point to the new library
|
|
(doseq [shape shapes]
|
|
(when (contains? shape :component-file)
|
|
(t/is (= linked-lib-id (:component-file shape))
|
|
"component-file should reference the linked library"))))))))
|
|
|
|
(t/deftest link-later-reference-integrity-no-match-dangling-refs
|
|
(let [{:keys [profile file-id]} (import-sample-file)
|
|
team2 (th/create-team* 2 {:profile-id (:id profile)})
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Import in team 2 (no library exists)
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id (:id team2))
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
new-file-id (first (:file-ids result))]
|
|
|
|
;; Get the original library id from the manifest
|
|
(let [manifest (v3/get-manifest output)
|
|
original-lib-id (:id (first (:external-libraries manifest)))]
|
|
;; Get the imported file's data
|
|
(let [imported (:result (th/command! {::th/type :get-file
|
|
::rpc/profile-id (:id profile)
|
|
:id new-file-id
|
|
:components-v2 true}))
|
|
file-data (:data imported)
|
|
pages (vals (:pages-index file-data))
|
|
all-shapes (mapcat vals (map :objects pages))
|
|
shapes-with-refs (filter #(contains? % :component-file) all-shapes)]
|
|
;; component-file refs should remain as original (dangling)
|
|
(t/is (seq shapes-with-refs) "expected shapes with component-file refs")
|
|
(doseq [shape shapes-with-refs]
|
|
(t/is (= original-lib-id (:component-file shape))
|
|
"component-file should remain as original UUID when no match")))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Category 8: Resolution Structure Verification
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-resolution-structure-single-file-single-lib
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete and recreate library
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib)})
|
|
(let [lib-b (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Verify exact structure
|
|
(t/is (map? file-res))
|
|
(t/is (= new-file-id (:id file-res)))
|
|
(t/is (some? (:name file-res)))
|
|
(t/is (vector? (:done file-res)))
|
|
(t/is (vector? (:pending file-res)))
|
|
(t/is (= 1 (count (:done file-res))))
|
|
|
|
;; Verify done entry structure
|
|
(let [done-entry (first (:done file-res))]
|
|
(t/is (contains? done-entry :id))
|
|
(t/is (contains? done-entry :name))
|
|
(t/is (contains? done-entry :linked-to))
|
|
(t/is (= (:id lib) (:id done-entry)))
|
|
(t/is (= "Icons Library" (:name done-entry)))
|
|
(t/is (= (:id lib-b) (:linked-to done-entry))))))))
|
|
|
|
(t/deftest link-later-resolution-structure-multi-match
|
|
(let [profile (th/create-profile* 1)
|
|
team-id (:default-team-id profile)
|
|
lib (th/create-file* 1 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
file (th/create-file* 2 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared false})]
|
|
|
|
(db/insert! th/*system* :file-library-rel
|
|
{:file-id (:id file) :library-file-id (:id lib)})
|
|
|
|
(let [output (tmp/tempfile :suffix ".zip")]
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{(:id file)})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Delete and create two libraries with same name
|
|
(db/update! th/*system* :file {:deleted-at (ct/now)} {:id (:id lib)})
|
|
(let [_ (th/create-file* 10 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
_ (th/create-file* 11 {:profile-id (:id profile)
|
|
:project-id (:default-project-id profile)
|
|
:is-shared true
|
|
:name "Icons Library"})
|
|
|
|
result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
resolution (:resolution result)
|
|
new-file-id (first (:file-ids result))
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Verify pending structure
|
|
(t/is (= [] (:done file-res)))
|
|
(t/is (= 1 (count (:pending file-res))))
|
|
|
|
(let [pending-entry (first (:pending file-res))]
|
|
(t/is (contains? pending-entry :id))
|
|
(t/is (contains? pending-entry :name))
|
|
(t/is (contains? pending-entry :candidates))
|
|
(t/is (= (:id lib) (:id pending-entry)))
|
|
(t/is (= "Icons Library" (:name pending-entry)))
|
|
(t/is (= 2 (count (:candidates pending-entry))))
|
|
|
|
;; Verify candidate structure
|
|
(doseq [candidate (:candidates pending-entry)]
|
|
(t/is (contains? candidate :id))
|
|
(t/is (contains? candidate :name))
|
|
(t/is (contains? candidate :project-id))
|
|
(t/is (contains? candidate :project-name))))))))
|
|
|
|
;; -----------------------------------------------------------------------------
|
|
;; Code Review Regression Tests: Reference Integrity Bug Fix
|
|
;; -----------------------------------------------------------------------------
|
|
|
|
(t/deftest link-later-multi-match-leaves-refs-dangling
|
|
(let [{:keys [profile file-id team-id library-id]} (import-sample-file)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Create a SECOND library with the same name in the same team
|
|
(create-named-library th/*system* 2 team-id "LIbrary")
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Re-import in same team
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id profile))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
new-file-id (first (:file-ids result))
|
|
resolution (:resolution result)
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Multi-match should produce pending candidates, not auto-link
|
|
(t/is (seq (:pending file-res))
|
|
"multi-match should produce pending candidates")
|
|
(t/is (= [] (:done file-res))
|
|
"multi-match should NOT auto-link")
|
|
|
|
;; Refs must remain as original UUID (dangling), NOT remapped to any
|
|
;; of the candidate libraries
|
|
(let [manifest (v3/get-manifest output)
|
|
original-lib-id (:id (first (:external-libraries manifest)))
|
|
imported (:result (th/command! {::th/type :get-file
|
|
::rpc/profile-id (:id profile)
|
|
:id new-file-id
|
|
:components-v2 true}))
|
|
file-data (:data imported)
|
|
pages (vals (:pages-index file-data))
|
|
all-shapes (mapcat vals (map :objects pages))
|
|
shapes-with-refs (filter #(contains? % :component-file) all-shapes)]
|
|
(t/is (seq shapes-with-refs) "expected shapes with component-file refs")
|
|
;; The key assertion: refs should NOT be remapped to any candidate
|
|
;; (they should remain as the original UUID from the manifest)
|
|
(let [slug (-> manifest :external-libraries first :slug)
|
|
matching (into #{} (map :id (bfc/find-shared-files-by-slug th/*system* team-id slug)))
|
|
candidate-ids (disj matching original-lib-id)]
|
|
(doseq [shape shapes-with-refs]
|
|
(t/is (not (contains? candidate-ids (:component-file shape)))
|
|
"component-file must NOT be remapped to any candidate library")
|
|
(t/is (= original-lib-id (:component-file shape))
|
|
"component-file must remain as original UUID on multi-match")))))))
|
|
|
|
(t/deftest link-later-no-edit-permission-leaves-refs-dangling
|
|
(let [{:keys [profile file-id team-id library-id]} (import-sample-file)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Export file with link-later
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later))
|
|
(io/output-stream output))
|
|
|
|
;; Create a viewer profile (no edit permission on the library)
|
|
(let [viewer (th/create-profile* th/*system* 2 {})
|
|
_ (th/create-team-role* {:team-id team-id
|
|
:profile-id (:id viewer)
|
|
:role :viewer})]
|
|
|
|
;; Import as viewer
|
|
(let [result (-> th/*system*
|
|
(assoc ::bfc/project-id (:default-project-id profile))
|
|
(assoc ::bfc/profile-id (:id viewer))
|
|
(assoc ::bfc/team-id team-id)
|
|
(assoc ::bfc/input output)
|
|
(v3/import-files!))
|
|
new-file-id (first (:file-ids result))
|
|
resolution (:resolution result)
|
|
file-res (get resolution new-file-id)]
|
|
|
|
;; Viewer lacks edit permission, so no auto-link
|
|
(t/is (or (nil? file-res)
|
|
(= [] (:done file-res)))
|
|
"viewer should NOT auto-link")
|
|
|
|
;; Refs must remain as original UUID (dangling)
|
|
(let [manifest (v3/get-manifest output)
|
|
original-lib-id (:id (first (:external-libraries manifest)))
|
|
imported (:result (th/command! {::th/type :get-file
|
|
::rpc/profile-id (:id viewer)
|
|
:id new-file-id
|
|
:components-v2 true}))
|
|
file-data (:data imported)
|
|
pages (vals (:pages-index file-data))
|
|
all-shapes (mapcat vals (map :objects pages))
|
|
shapes-with-refs (filter #(contains? % :component-file) all-shapes)]
|
|
(t/is (seq shapes-with-refs) "expected shapes with component-file refs")
|
|
(doseq [shape shapes-with-refs]
|
|
(t/is (= original-lib-id (:component-file shape))
|
|
"component-file must remain as original UUID when viewer has no edit permission")))))))
|
|
|
|
(t/deftest export-type-takes-precedence-over-legacy-boolean
|
|
(let [{:keys [file-id]} (import-sample-file)
|
|
output (tmp/tempfile :suffix ".zip")]
|
|
|
|
;; Call export with BOTH type=:link-later AND include-libraries=true
|
|
;; type should win
|
|
(v3/export-files!
|
|
(-> th/*system*
|
|
(assoc ::bfc/ids #{file-id})
|
|
(assoc ::bfc/export-type :link-later)
|
|
(assoc ::bfc/include-libraries true))
|
|
(io/output-stream output))
|
|
|
|
;; Verify manifest has external-libraries (only produced by link-later)
|
|
(let [manifest (v3/get-manifest output)
|
|
ext-libs (:external-libraries manifest)]
|
|
(t/is (some? ext-libs)
|
|
"type :link-later should produce external-libraries even with include-libraries=true")
|
|
(t/is (pos? (count ext-libs))))))
|