mirror of
https://github.com/penpot/penpot.git
synced 2026-04-25 11:18:36 +00:00
b99157a246
Cache in-progress frame traversals before following parent frame links so thumbnail updates stop recursing forever on cyclic or transiently inconsistent shape graphs. Add a regression test that covers cyclic frame-id chains and keeps the expected frame/component extraction behavior intact. Signed-off-by: Andrey Antukh <niwi@niwi.nz>
37 lines
1.6 KiB
Clojure
37 lines
1.6 KiB
Clojure
;; This Source Code Form is subject to the terms of the Mozilla Public
|
|
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
;;
|
|
;; Copyright (c) KALEIDOS INC
|
|
|
|
(ns frontend-tests.data.workspace-thumbnails-test
|
|
(:require
|
|
[app.common.uuid :as uuid]
|
|
[app.main.data.workspace.thumbnails :as thumbnails]
|
|
[cljs.test :as t :include-macros true]))
|
|
|
|
(t/deftest extract-frame-changes-handles-cyclic-frame-links
|
|
(let [page-id (uuid/next)
|
|
root-id (uuid/next)
|
|
shape-a-id (uuid/next)
|
|
shape-b-id (uuid/next)
|
|
event {:changes [{:type :mod-obj
|
|
:page-id page-id
|
|
:id shape-a-id}]}
|
|
old-data {:pages-index
|
|
{page-id
|
|
{:objects
|
|
{root-id {:id root-id :type :frame :frame-id uuid/zero}
|
|
shape-a-id {:id shape-a-id :type :rect :frame-id shape-b-id}
|
|
shape-b-id {:id shape-b-id :type :group :frame-id shape-a-id}}}}}
|
|
new-data {:pages-index
|
|
{page-id
|
|
{:objects
|
|
{root-id {:id root-id :type :frame :frame-id uuid/zero}
|
|
shape-a-id {:id shape-a-id :type :rect :frame-id root-id}
|
|
shape-b-id {:id shape-b-id :type :group :frame-id shape-a-id
|
|
:component-root true}}}}}]
|
|
(t/is (= #{["frame" root-id]
|
|
["component" shape-b-id]}
|
|
(#'thumbnails/extract-frame-changes page-id [event [old-data new-data]])))))
|