mirror of
https://github.com/penpot/penpot.git
synced 2026-11-02 16:10:42 +00:00
f5ca5755a5
Operators get a full instance administration panel behind a new
"superuser" access rule. The :app.auth/superusers service resolves
the configured :superusers emails to profile ids once at startup,
so guarded calls are a plain contains? with no query. A token
carrying "superuser" as an operator-granted scope also passes, for
automation without a session; tokens are created with empty perms,
so this opens nothing by itself.
The check is a branch of wrap-authentication, after auth and
before params validation, so outsiders get 403
:superuser-required without leaking expected params. Other token
scopes keep their exact meaning. get-profile and the login
response report the same answer as :is-superuser; the team-scoped
:is-admin is untouched. On devenv any authenticated profile
passes, as the /dbg gate does. The :admins config becomes
:superusers (PENPOT_SUPERUSERS) with no compatibility layer:
operators must rename it or instance-admin access fails closed.
Quote notifications go to the same set.
Admin operations live in app.rpc.admin.* behind
/api/admin/methods, with the same auth wrapping as main but
excluded from the main API docs. Profiles can be listed,
inspected, blocked, unblocked, deleted and restored, teams listed
with members and features, projects and files listed with validate
and repair, error reports listed and shared through JWE links,
and the virtual clock read and set.
Delete and restore run as durable jobs on the unified job table:
the command stamps the object's own row inline so it reads back
instantly, then a delete-object or restore-object job walks the
rest of the tree through app.features.object-cascade. Listing
uses created-at cursors over the new 0157 indexes.
The panel itself is a static SPA served under /admin (public like
any asset; the JS gate reads :is-superuser from get-profile)
with dashboard, users, teams, projects, files and error-report
pages. Devenv points /admin at the backend.
Covered by backend-tests rpc-superuser-test plus
rpc-admin-{users,teams,project,file,delete,restore,misc,
error-reports,error-share} and http-admin tests, with green
regressions on profile, auth and quotes.
Relates to #12015
AI-assisted-by: muse-spark-1.3-contributor
48 lines
1.4 KiB
JavaScript
48 lines
1.4 KiB
JavaScript
// Shared delete UI for a live object.
|
|
//
|
|
// command: "delete-team" and friends; id: the object id.
|
|
// label: "this team" for messages; kind: "Team" for toasts;
|
|
// name: the object name for the confirm.
|
|
// onDeleted(): what the page does after success (usually reloading,
|
|
// which then paints the restore actions).
|
|
// Asks for confirmation first. Every string is painted as text.
|
|
|
|
import { rpc, errorHint } from "../api.js";
|
|
import { showToast } from "./toast.js";
|
|
|
|
// Delete action for the bar of a live object's detail page.
|
|
// Carries a tooltip; asks for confirmation first. Returns a
|
|
// cleanup function removing everything added.
|
|
export function paintDeleteAction(bar, {
|
|
command,
|
|
id,
|
|
label,
|
|
name,
|
|
kind,
|
|
onDeleted,
|
|
}) {
|
|
const del = document.createElement("button");
|
|
del.className = "admin-button admin-button-danger";
|
|
del.textContent = "Delete";
|
|
del.title = `Delete ${label}. It can be restored afterwards.`;
|
|
del.addEventListener("click", async () => {
|
|
if (!window.confirm(`Delete ${name}? It can be restored afterwards.`)) {
|
|
return;
|
|
}
|
|
del.disabled = true;
|
|
try {
|
|
await rpc(command, { id });
|
|
showToast(`${kind} deleted.`);
|
|
onDeleted();
|
|
} catch (err) {
|
|
showToast(errorHint(err) ?? `Could not delete ${label}.`, "error");
|
|
del.disabled = false;
|
|
}
|
|
});
|
|
bar.appendChild(del);
|
|
|
|
return () => {
|
|
del.remove();
|
|
};
|
|
}
|