Alonso Torres
|
4ac14cfd08
|
✨ Add component synchronization to waitForLayoutUpdate (#10964)
* ✨ Add component synchronization to waitForLayoutUpdate
* 🐛 Fix async mock leak in workspace-reflow-test
Use mock/with-mocks instead of with-redefs for http/send! mock in
failed-google-font-css-does-not-abort-shared-consumers test.
with-redefs restores bindings when the block exits synchronously,
but the RxJS subscription fires asynchronously. This caused the mock
to leak into subsequent tests (workspace-media-test), producing 3
spurious failures.
AI-assisted-by: mimo-v2.5-pro
* ♻️ Replace async with-redefs with mock/with-mocks in frontend tests
with-redefs restores bindings when the block exits synchronously,
which is too early for async code (t/async, rx/subs!, promises).
mock/with-mocks uses set! and restores in the done callback, keeping
mocks alive across async boundaries.
Converted 15 with-redefs usages across 4 test files:
- workspace_reflow_test.cljs: 2 genuinely async tests (P1)
- routes_test.cljs: 3 SSO caching tests (P2)
- main_errors_test.cljs: 8 expired-org SSO tests (P2)
- comments_test.cljs: 2 comment thread tests (P2)
36 purely sync with-redefs usages left unchanged — with-redefs
is correct for synchronous code.
AI-assisted-by: mimo-v2.5-pro
* 📎 Fix fmt issues
---------
Co-authored-by: Andrey Antukh <niwi@niwi.nz>
|
2026-08-18 17:45:42 +02:00 |
|