github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-04-30 21:59:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

✨ Move several mem write helpers to mem.heap32 ns

Browse Source 
For simplify usage and make it clear the required addressing
is used for that functions
This commit is contained in:
Andrey Antukh 2025-08-12 10:53:02 +02:00
parent 6b6e80f4b8
commit f9d757bb85
3 changed files with 70 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
frontend/src/app/render_wasm/api.cljs
View File

@ -26,6 +26,7 @@
[app.render-wasm.deserializers :as dr]
[app.render-wasm.helpers :as h]
[app.render-wasm.mem :as mem]
[app.render-wasm.mem.heap32 :as mem.h32]
[app.render-wasm.performance :as perf]
[app.render-wasm.serializers :as sr]
[app.render-wasm.serializers.color :as sr-clr]
@ -156,7 +157,7 @@
size (mem/get-alloc-size children UUID-U8-SIZE)
offset (mem/alloc->offset-32 size)]
(reduce (fn [offset id]
(sr/write-uuid offset heap id))
(mem.h32/write-uuid offset heap id))
offset
children)
@ -458,10 +459,11 @@
buffer (buf/wrap heapu8)]
(reduce (fn [offset {:keys [type value]}]
;; NOTE: because the not well alligned nature of grid
;; row data structure, we use buffer/dataview way for
;; write data instead of the used to way of secuentally
;; write chaining the offset.
;; NOTE: because of the nature of the grid row data
;; structure memory layout we can't use fully 32 bits
;; alligned writes, so for heteregeneus writes we use
;; the buffer abstraction (DataView) for perform
;; surgical writes.
(buf/write-byte buffer (+ offset 0) (sr/translate-grid-track-type type))
(buf/write-float buffer (+ offset 1) value)
(+ offset GRID-LAYOUT-ROW-U8-SIZE))
@ -804,7 +806,7 @@
offset (mem/alloc->offset-32 size)]
(reduce (fn [offset id]
(sr/write-uuid offset heap id))
(mem.h32/write-uuid offset heap id))
offset
entries)
@ -823,11 +825,11 @@
(reduce (fn [offset {:keys [type parent id index value]}]
(-> offset
(sr/write-u32 heapu32 (sr/translate-structure-modifier-type type))
(sr/write-u32 heapu32 (d/nilv index 0))
(sr/write-uuid heapu32 parent)
(sr/write-uuid heapu32 id)
(sr/write-f32 heapf32 value)))
(mem.h32/write-u32 heapu32 (sr/translate-structure-modifier-type type))
(mem.h32/write-u32 heapu32 (d/nilv index 0))
(mem.h32/write-uuid heapu32 parent)
(mem.h32/write-uuid heapu32 id)
(mem.h32/write-f32 heapf32 value)))
offset
entries)
@ -843,8 +845,8 @@
(reduce (fn [offset [id transform]]
(-> offset
(sr/write-uuid heapu32 id)
(sr/write-matrix heapf32 transform)))
(mem.h32/write-uuid heapu32 id)
(mem.h32/write-matrix heapf32 transform)))
offset
entries)
@ -873,7 +875,7 @@
heapf32 (mem/get-heap-f32)]
(reduce (fn [offset id]
(sr/write-uuid offset heapu32 id))
(mem.h32/write-uuid offset heapu32 id))
offset
entries)
@ -907,8 +909,8 @@
(reduce (fn [offset [id transform]]
(-> offset
(sr/write-uuid heapu32 id)
(sr/write-matrix heapf32 transform)))
(mem.h32/write-uuid heapu32 id)
(mem.h32/write-matrix heapf32 transform)))
offset
modifiers)
@ -1020,7 +1022,7 @@
offset (mem/alloc->offset-32 size)]
(reduce (fn [offset id]
(sr/write-uuid offset heap id))
(mem.h32/write-uuid offset heap id))
offset
(rseq ids))

51
frontend/src/app/render_wasm/mem/heap32.cljs Normal file
View File

@ -0,0 +1,51 @@
;; This Source Code Form is subject to the terms of the Mozilla Public
;; License, v. 2.0. If a copy of the MPL was not distributed with this
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
;;
;; Copyright (c) KALEIDOS INC
(ns app.render-wasm.mem.heap32
"A memory write helpers that uses 32 bits addressed offsets."
(:require
[app.common.data.macros :as dm]
[app.common.uuid :as uuid]))
(defn write-u32
[offset heap value]
(assert (instance? js/Uint32Array heap) "expected Uint32Array instance for `heap`")
(aset heap offset value)
(inc offset))
(defn write-f32
[offset heap value]
(assert (instance? js/Float32Array heap) "expected Float32Array instance for `heap`")
(aset heap offset value)
(inc offset))
(defn write-uuid
"Write a uuid to 32 bits addressed heap and return the offset
after write."
[offset heap id]
(assert (instance? js/Uint32Array heap) "expected Uint32Array instance for `heap`")
(let [buffer (uuid/get-u32 id)]
(.set heap buffer offset)
(+ offset 4)))
(defn write-matrix
"Write a matrix to 32 bits addressed heap and return the offset
after write."
[offset heap matrix]
(assert (instance? js/Float32Array heap) "expected Float32Array instance for `heap`")
(let [a (dm/get-prop matrix :a)
b (dm/get-prop matrix :b)
c (dm/get-prop matrix :c)
d (dm/get-prop matrix :d)
e (dm/get-prop matrix :e)
f (dm/get-prop matrix :f)]
(aset heap (+ offset 0) a)
(aset heap (+ offset 1) b)
(aset heap (+ offset 2) c)
(aset heap (+ offset 3) d)
(aset heap (+ offset 4) e)
(aset heap (+ offset 5) f)
(+ offset 6)))

40
frontend/src/app/render_wasm/serializers.cljs
View File

@ -55,46 +55,6 @@
(catch :default _e
[uuid/zero])))
(defn write-u32
[offset heap value]
(assert (instance? js/Uint32Array heap) "expected Uint32Array instance for `heap`")
(aset heap offset value)
(inc offset))
(defn write-f32
[offset heap value]
(assert (instance? js/Float32Array heap) "expected Float32Array instance for `heap`")
(aset heap offset value)
(inc offset))
(defn write-uuid
"Write a uuid to 32 bits addressed heap and return the offset
after write."
[offset heap id]
(assert (instance? js/Uint32Array heap) "expected Uint32Array instance for `heap`")
(let [buffer (uuid/get-u32 id)]
(.set heap buffer offset)
(+ offset 4)))
(defn write-matrix
"Write a matrix to 32 bits addressed heap and return the offset
after write."
[offset heap matrix]
(assert (instance? js/Float32Array heap) "expected Float32Array instance for `heap`")
(let [a (dm/get-prop matrix :a)
b (dm/get-prop matrix :b)
c (dm/get-prop matrix :c)
d (dm/get-prop matrix :d)
e (dm/get-prop matrix :e)
f (dm/get-prop matrix :f)]
(aset heap (+ offset 0) a)
(aset heap (+ offset 1) b)
(aset heap (+ offset 2) c)
(aset heap (+ offset 3) d)
(aset heap (+ offset 4) e)
(aset heap (+ offset 5) f)
(+ offset 6)))
(defn translate-shape-type
[type]
(case type