From f60254e3eb4e98f2630b7df3a250ede99b202981 Mon Sep 17 00:00:00 2001
From: Aitor Moreno <asakon28@gmail.com>
Date: Tue, 17 Jun 2025 16:19:28 +0200
Subject: [PATCH] WIP

---
 frontend/resources/wasm-playground/rects.html |  6 +-
 render-wasm/src/render.rs                     | 66 +++++++++----------
 2 files changed, 35 insertions(+), 37 deletions(-)

diff --git a/frontend/resources/wasm-playground/rects.html b/frontend/resources/wasm-playground/rects.html
index bb05ecbdac..9719e167f2 100644
--- a/frontend/resources/wasm-playground/rects.html
+++ b/frontend/resources/wasm-playground/rects.html
@@ -64,19 +64,19 @@
 
         Module._add_shape_center_stroke(10, 0,  0, 0);
         const argb2 = hexToU32ARGB(color, getRandomFloat(0.1, 1.0));
-        addShapeSolidStrokeFill(argb2);        
+        addShapeSolidStrokeFill(argb2);
       }
 
       useShape("00000000-0000-0000-0000-000000000000");
       setShapeChildren(children);
 
       performance.mark('render:begin');
-      Module._render(Date.now());
+      Module._render(Date.now(), false);
       performance.mark('render:end');
       const { duration } = performance.measure('render', 'render:begin', 'render:end');
       // alert(`render time: ${duration.toFixed(2)}ms`);
     });
-    
+
   </script>
 </body>
 </html>
diff --git a/render-wasm/src/render.rs b/render-wasm/src/render.rs
index e4e52a05a0..e6f5cbb62d 100644
--- a/render-wasm/src/render.rs
+++ b/render-wasm/src/render.rs
@@ -672,6 +672,7 @@ impl RenderState {
 
     pub fn cancel_animation_frame(&mut self) {
         if self.render_in_progress {
+            self.render_in_progress = false;
             if let Some(frame_id) = self.render_request_id {
                 wapi::cancel_animation_frame!(frame_id);
             }
@@ -762,8 +763,12 @@ impl RenderState {
         performance::end_measure!("tile_cache");
 
         self.pending_nodes.prepare(tree);
-        // reorder by distance to the center.
+
         self.current_tile = None;
+        if let Some(next_tile) = self.pending_tiles.pop() {
+            self.update_render_context(&next_tile);
+        }
+
         self.render_in_progress = true;
         self.render_is_full = full;
         if self.render_is_full {
@@ -1004,12 +1009,12 @@ impl RenderState {
         modifiers: &HashMap<Uuid, Matrix>,
         _structure: &HashMap<Uuid, Vec<StructureEntry>>,
         scale_content: &HashMap<Uuid, f32>,
-    ) {
+    ) -> bool {
         let NodeRenderState {
             id: _node_id,
-            visited_children: _visited_children,
+            visited_children,
             clip_bounds,
-            visited_mask: _visited_mask,
+            visited_mask,
             mask,
         } = *node_render_state;
 
@@ -1026,6 +1031,11 @@ impl RenderState {
         } else {
             self.apply_drawing_to_render_canvas(Some(element));
         }
+        if visited_children {
+            self.render_shape_exit(element, visited_mask);
+            return false;
+        }
+        true
     }
 
     pub fn render_shape_tree_full_uncached_shape_tiles(
@@ -1074,9 +1084,9 @@ impl RenderState {
             );
             let NodeRenderState {
                 id: node_id,
-                visited_children,
+                visited_children: _visited_children,
                 clip_bounds: _clip_bounds,
-                visited_mask,
+                visited_mask: _visited_mask,
                 mask,
             } = node_render_state;
 
@@ -1109,43 +1119,30 @@ impl RenderState {
             // If the shape is not in the tile set, then we update
             // it.
             if self.get_tiles_of(node_id).is_none() {
+                println!("updating tiles for {}", element.id);
                 self.update_tile_for(element);
             }
 
-            let mut tiles_opt = self.get_tiles_of(element.id);
-            let tiles = tiles_opt.as_mut().unwrap().clone();
-            self.render_shape_tree_full_uncached_shape_tiles(
-                element,
-                &node_render_state,
-                &tiles,
-                modifiers,
-                structure,
-                scale_content,
-            );
-            if visited_children {
-                if !visited_mask {
-                    if let Type::Group(group) = element.shape_type {
-                        // When we're dealing with masked groups we need to
-                        // do a separate extra step to draw the mask (the last
-                        // element of a masked group) and blend (using
-                        // the blend mode 'destination-in') the content
-                        // of the group and the mask.
-                        if group.masked {
-                            self.pending_nodes.add_mask(element);
-                        }
-                    }
-                }
-                self.render_shape_exit(element, visited_mask);
-                continue;
-            }
+            if !element.id.is_nil() {
+                let mut tiles_opt = self.get_tiles_of(element.id);
+                let tiles = tiles_opt.as_mut().unwrap().clone();
+                self.render_shape_tree_full_uncached_shape_tiles(
+                    element,
+                    &node_render_state,
+                    &tiles,
+                    modifiers,
+                    structure,
+                    scale_content,
+                );
 
-            self.pending_nodes.add_children_safeguard(element, mask);
+                self.pending_nodes.add_children_safeguard(element, mask);
+            }
 
             if element.is_recursive() {
                 let children_clip_bounds =
                     node_render_state.get_children_clip_bounds(element, modifiers.get(&element.id));
 
-                let mut children_ids = modified_children_ids(element, structure.get(&element.id));
+                let mut children_ids = modified_children_ids(element, structure.get(&element.id), false);
 
                 // Z-index ordering on Layouts
                 if element.has_layout() {
@@ -1157,6 +1154,7 @@ impl RenderState {
                 }
 
                 for child_id in children_ids.iter() {
+                    println!("children id {}", child_id);
                     self.pending_nodes.add_child(child_id, children_clip_bounds);
                 }
             }