github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-09-11 14:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

🔧 Remove legacy pnpm build key and clarify updating doc

Browse Source 
Drop the ignored-since-pnpm-11 onlyBuiltDependencies entry from
render-wasm/pnpm-workspace.yaml, keeping allowBuilds as the single
source of build approvals. Clarify the updating-pnpm gotcha so it no
longer claims pnpm writes ignoredBuiltDependencies.

AI-assisted-by: muse-spark-1.3-contributor
This commit is contained in:
Andrey Antukh 2026-09-09 09:42:58 +00:00
parent d263c23a58
commit eca1d81692
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.serena/memories/workflow/updating-pnpm.md
View File

@ -52,10 +52,12 @@ file (never pipe tool output through filters).
then re-run `corepack use pnpm@<tag>` in that directory. then re-run `corepack use pnpm@<tag>` in that directory.
- A workspace may fail with `ERR_PNPM_IGNORED_BUILDS`, and pnpm then writes - A workspace may fail with `ERR_PNPM_IGNORED_BUILDS`, and pnpm then writes
a placeholder scaffold into its `pnpm-workspace.yaml`: a placeholder scaffold into its `pnpm-workspace.yaml`:
`allowBuilds: esbuild: set this to true or false` plus `allowBuilds: esbuild: set this to true or false`. Current pnpm writes
`ignoredBuiltDependencies`. Repo convention is `allowBuilds: esbuild: true`. only the `allowBuilds` placeholder; any legacy key still present
Replace the placeholder and drop the `ignoredBuiltDependencies` entry, (`ignoredBuiltDependencies`, `onlyBuiltDependencies`,
then re-run. `neverBuiltDependencies`) is ignored since pnpm 11. Repo convention is
`allowBuilds: esbuild: true`. Replace the placeholder and drop the
legacy entry, then re-run.
- `plugins/apps/composable-test-suite` once had its own - `plugins/apps/composable-test-suite` once had its own
`pnpm-workspace.yaml` and acted as a nested workspace root. That state is `pnpm-workspace.yaml` and acted as a nested workspace root. That state is
gone on purpose: pnpm picks the nearest `pnpm-workspace.yaml` walking up, gone on purpose: pnpm picks the nearest `pnpm-workspace.yaml` walking up,

2
render-wasm/pnpm-workspace.yaml
View File

@ -2,5 +2,3 @@ storeDir: ../.pnpm-store
allowBuilds: allowBuilds:
esbuild: true esbuild: true
onlyBuiltDependencies:
- esbuild