github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-08-01 19:06:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix size badge shows "x" instead of dimensions when creating a path (#10550)

Browse Source
This commit is contained in:
Luis de Dios 2026-07-03 14:58:43 +02:00 committed by GitHub
parent 618ec57b6f
commit e5d3ea14d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
frontend/playwright/ui/specs/workspace.spec.js
View File

@ -158,6 +158,35 @@ test("Selection size badge shows unrotated dimensions for rotated single selecti
await expect(badgeText).toHaveText("126 x 134"); await expect(badgeText).toHaveText("126 x 134");
}); });
test("Selection size badge shows dimensions for path shapes", async ({ page }) => {
const workspacePage = new WasmWorkspacePage(page);
await workspacePage.setupEmptyFile();
await workspacePage.mockRPC(
"update-file?id=*",
"workspace/update-file-empty.json",
);
await workspacePage.goToWorkspace();
// Workaround: hover viewport first to avoid nil mouse position crash
await workspacePage.viewport.hover();
// Draw a path
await workspacePage.pathButton.click();
await workspacePage.clickAt(779, 163);
await workspacePage.clickAt(951, 258);
// Finish drawing (commits path, path enters edition mode)
await page.keyboard.press("Escape");
// Exit edition mode (path stays selected, badge becomes visible)
await page.keyboard.press("Escape");
const badgeText = page.locator(".selection-size-badge text");
await expect(badgeText).toBeVisible();
await expect(badgeText).toHaveText(/\d+\.?\d* x \d+\.?\d*/);
});
test("User makes a group", async ({ page }) => { test("User makes a group", async ({ page }) => {
const workspacePage = new WasmWorkspacePage(page); const workspacePage = new WasmWorkspacePage(page);
await workspacePage.setupEmptyFile(); await workspacePage.setupEmptyFile();

6
frontend/src/app/main/ui/measurements.cljs
View File

@ -232,10 +232,12 @@
;; For single shapes we show the original dimensions, ;; For single shapes we show the original dimensions,
;; for multiple shapes show the bounding box ;; for multiple shapes show the bounding box
shape-width (if single-shape shape-width (if single-shape
(dm/get-prop single-shape :width) (or (dm/get-prop single-shape :width)
(:width selrect))
(:width selrect)) (:width selrect))
shape-height (if single-shape shape-height (if single-shape
(dm/get-prop single-shape :height) (or (dm/get-prop single-shape :height)
(:height selrect))
(:height selrect)) (:height selrect))
text (dm/str (fmt/format-number shape-width) " x " (fmt/format-number shape-height)) text (dm/str (fmt/format-number shape-width) " x " (fmt/format-number shape-height))