From e49b7ce14cad02d99a72cf3b0579d33aa0af5808 Mon Sep 17 00:00:00 2001 From: Dexterity <173429049+Dexterity104@users.noreply.github.com> Date: Thu, 9 Apr 2026 11:09:19 -0400 Subject: [PATCH] :bug: Fix warnings for unsupported token $type (#8873) * :bug: Fix warnings for unsupported token $type Signed-off-by: Dexterity104 * :bug: Add changelog entry for Github #8790 --------- Signed-off-by: Dexterity104 Signed-off-by: Dexterity <173429049+Dexterity104@users.noreply.github.com> --- CHANGES.md | 1 + .../main/data/workspace/tokens/import_export.cljs | 14 +++++++++++--- frontend/translations/de.po | 8 ++++---- frontend/translations/en.po | 8 ++++---- frontend/translations/es.po | 10 ++++------ frontend/translations/fr.po | 8 ++++---- frontend/translations/he.po | 8 ++++---- frontend/translations/hi.po | 8 ++++---- frontend/translations/it.po | 10 ++++------ frontend/translations/lv.po | 4 ++-- frontend/translations/nl.po | 8 ++++---- frontend/translations/ro.po | 8 ++++---- frontend/translations/sv.po | 8 ++++---- frontend/translations/tr.po | 8 ++++---- frontend/translations/ukr_UA.po | 4 ++-- 15 files changed, 60 insertions(+), 55 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index b91412bf54..98e3a212b9 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -23,6 +23,7 @@ - Add drag-to-change for numeric inputs in workspace sidebar [Github #2466](https://github.com/penpot/penpot/issues/2466) - Add CSS linter [Taiga #13790](https://tree.taiga.io/project/penpot/us/13790) - Save and restore selection state in undo/redo (by @eureka928) [Github #6007](https://github.com/penpot/penpot/issues/6007) +- Fix warnings for unsupported token $type (by @Dexterity104) [Github #8790](https://github.com/penpot/penpot/issues/8790) - Add per-group add button for typographies (by @eureka928) [Github #5275](https://github.com/penpot/penpot/issues/5275) ### :bug: Bugs fixed diff --git a/frontend/src/app/main/data/workspace/tokens/import_export.cljs b/frontend/src/app/main/data/workspace/tokens/import_export.cljs index 32ba61fd70..545d893d27 100644 --- a/frontend/src/app/main/data/workspace/tokens/import_export.cljs +++ b/frontend/src/app/main/data/workspace/tokens/import_export.cljs @@ -7,6 +7,7 @@ (ns app.main.data.workspace.tokens.import-export (:require [app.common.json :as json] + [app.common.logging :as l] [app.common.path-names :as cpn] [app.common.types.tokens-lib :as ctob] [app.config :as cf] @@ -44,10 +45,17 @@ (defn- show-unknown-types-warning [unknown-tokens] (let [type->tokens (group-by-value unknown-tokens)] + (l/wrn :hint "unsupported token types found during import" + :tokens (str/join ", " (map (fn [[path type]] (str path " (" type ")")) unknown-tokens))) (ntf/show {:content (tr "workspace.tokens.unknown-token-type-message") - :detail (->> (for [[token-type tokens] type->tokens] - (tr "workspace.tokens.unknown-token-type-section" token-type (count tokens))) - (str/join "
")) + :detail (->> (for [[token-type token-paths] type->tokens] + (str (tr "workspace.tokens.unknown-token-type-section" token-type (count token-paths)) + "
" + (->> token-paths + (sort) + (map #(str "  • " %)) + (str/join "
")))) + (str/join "

")) :type :toast :level :info}))) diff --git a/frontend/translations/de.po b/frontend/translations/de.po index b1bead45b4..510ad2f093 100644 --- a/frontend/translations/de.po +++ b/frontend/translations/de.po @@ -8023,13 +8023,13 @@ msgstr "TOKENS - %s" msgid "workspace.tokens.tools" msgstr "Werkzeuge" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "Der Import war erfolgreich. Einige Token wurden nicht übernommen." +msgstr "Der Import war erfolgreich, aber einige Token wurden übersprungen, da sie nicht unterstützte $type-Werte verwenden. Details aufklappen, um zu sehen, welche Token betroffen sind." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "„%s“ wird nicht als Datentyp unterstützt (%s)\n" +msgstr "„%s“ wird nicht als Datentyp unterstützt (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/en.po b/frontend/translations/en.po index 9b98da0cd0..68521498ed 100644 --- a/frontend/translations/en.po +++ b/frontend/translations/en.po @@ -8626,13 +8626,13 @@ msgstr "TOKENS - %s" msgid "workspace.tokens.tools" msgstr "Tools" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "Import was successful. Some tokens were not included." +msgstr "Import was successful, but some tokens were skipped because they use unsupported $type values. Expand details to see which tokens were affected." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Type '%s' is not supported (%s)\n" +msgstr "Type '%s' is not supported (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/es.po b/frontend/translations/es.po index 3381ae09bf..3d74830dce 100644 --- a/frontend/translations/es.po +++ b/frontend/translations/es.po @@ -8477,15 +8477,13 @@ msgstr "Introduce un valor o un alias usando {alias}" msgid "workspace.tokens.tools" msgstr "Herramientas" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "" -"La importación se ha realizado correctamente. Algunos tokens no se " -"incluyeron." +msgstr "La importación se ha realizado correctamente, pero algunos tokens fueron omitidos porque usan valores de $type no soportados. Expande los detalles para ver qué tokens se vieron afectados." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "El tipo '%s' no está soportado (%s)\n" +msgstr "El tipo '%s' no está soportado (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/fr.po b/frontend/translations/fr.po index ef26ef224c..d061e50e7e 100644 --- a/frontend/translations/fr.po +++ b/frontend/translations/fr.po @@ -8150,13 +8150,13 @@ msgstr "TOKENS - %s" msgid "workspace.tokens.tools" msgstr "Outils" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "L'importation a réussi. Certains tokens n'ont pas été inclus." +msgstr "L'importation a réussi, mais certains tokens ont été ignorés car ils utilisent des valeurs $type non prises en charge. Développez les détails pour voir quels tokens ont été affectés." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Le type « %s » n'est pas pris en charge (%s)\n" +msgstr "Le type « %s » n'est pas pris en charge (%s) :" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/he.po b/frontend/translations/he.po index 395bce7724..a66e623ff0 100644 --- a/frontend/translations/he.po +++ b/frontend/translations/he.po @@ -8033,13 +8033,13 @@ msgstr "אסימונים - %s" msgid "workspace.tokens.tools" msgstr "כלים" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "הייבוא הצליח. חלק מהאסימונים לא נכללו." +msgstr "הייבוא הצליח, אך חלק מהאסימונים דולגו כי הם משתמשים בערכי $type שאינם נתמכים. הרחב את הפרטים כדי לראות אילו אסימונים הושפעו." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "הסוג ‚%s’ לא נתמך (%s)\n" +msgstr "הסוג ‚%s’ לא נתמך (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/hi.po b/frontend/translations/hi.po index 54c563fd5d..a169abe7a7 100644 --- a/frontend/translations/hi.po +++ b/frontend/translations/hi.po @@ -8187,13 +8187,13 @@ msgstr "टोकन - %s" msgid "workspace.tokens.tools" msgstr "औजार" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "आयात सफल रहा। कुछ टोकन शामिल नहीं किए गए।" +msgstr "आयात सफल रहा, लेकिन कुछ टोकन छोड़ दिए गए क्योंकि वे असमर्थित $type मानों का उपयोग करते हैं। प्रभावित टोकन देखने के लिए विवरण विस्तृत करें।" -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "टाइप '%s' समर्थित नहीं है (%s)\n" +msgstr "टाइप '%s' समर्थित नहीं है (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/it.po b/frontend/translations/it.po index a6d88a564c..75f3d4ed1f 100644 --- a/frontend/translations/it.po +++ b/frontend/translations/it.po @@ -8419,15 +8419,13 @@ msgstr "TOKEN - %s" msgid "workspace.tokens.tools" msgstr "Strumenti" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "" -"L’importazione è stata completata con successo. Alcuni token non sono stati " -"inclusi." +msgstr "L’importazione è stata completata con successo, ma alcuni token sono stati ignorati perché utilizzano valori $type non supportati. Espandi i dettagli per vedere quali token sono stati interessati." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Il tipo '%s' non è supportato (%s)\n" +msgstr "Il tipo '%s' non è supportato (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/lv.po b/frontend/translations/lv.po index 72fef0e36f..4268d7a133 100644 --- a/frontend/translations/lv.po +++ b/frontend/translations/lv.po @@ -7720,9 +7720,9 @@ msgstr "TEKSTVIENĪBAS - %s" msgid "workspace.tokens.tools" msgstr "Rīki" -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Veids \"%s\" nav atbalstīts (%s)\n" +msgstr "Veids \"%s\" nav atbalstīts (%s):" #: src/app/main/ui/workspace/tokens/management/token_pill.cljs:132 msgid "workspace.tokens.value-not-valid" diff --git a/frontend/translations/nl.po b/frontend/translations/nl.po index 819e3da13d..d78724baee 100644 --- a/frontend/translations/nl.po +++ b/frontend/translations/nl.po @@ -8435,13 +8435,13 @@ msgstr "TOKENS - %s" msgid "workspace.tokens.tools" msgstr "Hulpmiddelen" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "Importeren was succesvol. Sommige tokens zijn niet inbegrepen." +msgstr "Importeren was succesvol, maar sommige tokens zijn overgeslagen omdat ze niet-ondersteunde $type-waarden gebruiken. Klap de details uit om te zien welke tokens getroffen zijn." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Typ '%s' wordt niet ondersteund (%s)\n" +msgstr "Typ '%s' wordt niet ondersteund (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/ro.po b/frontend/translations/ro.po index 11d1473623..d0807b28a9 100644 --- a/frontend/translations/ro.po +++ b/frontend/translations/ro.po @@ -7956,13 +7956,13 @@ msgstr "TOKEN-URI- %s" msgid "workspace.tokens.tools" msgstr "Unelte" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "Import cu succes. Unele token-uri nu au fost incluse." +msgstr "Importul a fost realizat cu succes, dar unele token-uri au fost omise deoarece folosesc valori $type neacceptate. Extindeți detaliile pentru a vedea care token-uri au fost afectate." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Tipul '%s' nu este suportat (%s)\n" +msgstr "Tipul '%s' nu este suportat (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/sv.po b/frontend/translations/sv.po index 810055f737..6d57efaf41 100644 --- a/frontend/translations/sv.po +++ b/frontend/translations/sv.po @@ -8107,13 +8107,13 @@ msgstr "TOKEN - %s" msgid "workspace.tokens.tools" msgstr "Verktyg" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "Importen lyckades. Vissa tokens inkluderades ej." +msgstr "Importen lyckades, men vissa tokens hoppades över eftersom de använder $type-värden som inte stöds. Expandera detaljerna för att se vilka tokens som påverkades." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Typen '%s' stödjs ej (%s)\n" +msgstr "Typen '%s' stöds ej (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/tr.po b/frontend/translations/tr.po index c430de809f..72c1bfbedf 100644 --- a/frontend/translations/tr.po +++ b/frontend/translations/tr.po @@ -8393,13 +8393,13 @@ msgstr "TOKENLER - %s" msgid "workspace.tokens.tools" msgstr "Araçlar" -#: src/app/main/data/workspace/tokens/import_export.cljs:46 +#: src/app/main/data/workspace/tokens/import_export.cljs:50 msgid "workspace.tokens.unknown-token-type-message" -msgstr "İçe aktarma başarılı oldu. Bazı tokenler dahil edilmedi." +msgstr "İçe aktarma başarılı oldu, ancak bazı tokenler desteklenmeyen $type değerleri kullandıkları için atlandı. Hangi tokenlerin etkilendiğini görmek için ayrıntıları genişletin." -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "'%s' türü desteklenmiyor (%s)\n" +msgstr "'%s' türü desteklenmiyor (%s):" #: src/app/main/ui/workspace/tokens/management/forms/shadow.cljs:244, src/app/main/ui/workspace/tokens/management/forms/typography.cljs:199 msgid "workspace.tokens.use-reference" diff --git a/frontend/translations/ukr_UA.po b/frontend/translations/ukr_UA.po index 4769f8e70a..e587f083dc 100644 --- a/frontend/translations/ukr_UA.po +++ b/frontend/translations/ukr_UA.po @@ -7421,9 +7421,9 @@ msgstr "ТОКЕНИ - %s" msgid "workspace.tokens.tools" msgstr "Інструменти" -#: src/app/main/data/workspace/tokens/import_export.cljs:48 +#: src/app/main/data/workspace/tokens/import_export.cljs:52 msgid "workspace.tokens.unknown-token-type-section" -msgstr "Тип \"%s\" непідтримуваний (%s)\n" +msgstr "Тип \"%s\" непідтримуваний (%s):" #: src/app/main/ui/workspace/tokens/management/token_pill.cljs:132 msgid "workspace.tokens.value-not-valid"