From da36e3683649b536a8d255cb8fb314c08f4361dc Mon Sep 17 00:00:00 2001 From: Eva Marco Date: Wed, 28 Oct 2026 14:26:43 +0100 Subject: [PATCH] :sparkles: Add the share, handlers and snap icons to the DS (#12659) * :sparkles: Add the share, handlers and snap icons to the DS The share button and the path editing bar could not move to the DS buttons because their icons were missing from the DS icon set. As agreed with design: - handlers-equal, handlers-independent, handlers-mirror and snap join the DS as they are (their SVGs already follow the DS format). - share keeps its drawing, moved onto the 16x16 grid as a single path with no fixed color. - snap-nodes is deleted: nothing used it, and snap is the icon of the snap nodes button. The legacy share button in the workspace header uses the same SVG: its icon is about 6% smaller and now takes the hover color, which the fixed stroke color blocked before. AI-assisted-by: claude-opus-5-5 * :bug: Show the share icon lines outside the app The share SVG had no fill or stroke, so plain SVG viewers used the defaults (black fill, no stroke) and drew only three dots. Set fill="none" and stroke="currentColor", like settings.svg. The app already sets both in CSS, so nothing changes there. AI-assisted-by: claude-opus-5-5 * :bug: Show the handlers and snap icons right outside the app Like share, these SVGs had no fill or stroke, so plain SVG viewers filled the shapes black and drew no lines. Set fill="none" and stroke="currentColor". The app sets both in CSS, so nothing changes there. AI-assisted-by: claude-opus-5-5 --- frontend/resources/images/icons/handlers-equal.svg | 2 +- frontend/resources/images/icons/handlers-independent.svg | 2 +- frontend/resources/images/icons/handlers-mirror.svg | 2 +- frontend/resources/images/icons/share.svg | 4 +++- frontend/resources/images/icons/snap-nodes.svg | 3 --- frontend/resources/images/icons/snap.svg | 2 +- frontend/src/app/main/ui/ds/foundations/assets/icon.cljs | 6 +++++- frontend/src/app/main/ui/icons.cljs | 1 - 8 files changed, 12 insertions(+), 10 deletions(-) delete mode 100644 frontend/resources/images/icons/snap-nodes.svg diff --git a/frontend/resources/images/icons/handlers-equal.svg b/frontend/resources/images/icons/handlers-equal.svg index 645e773d8c..c1b3cb33aa 100644 --- a/frontend/resources/images/icons/handlers-equal.svg +++ b/frontend/resources/images/icons/handlers-equal.svg @@ -1,3 +1,3 @@ - + diff --git a/frontend/resources/images/icons/handlers-independent.svg b/frontend/resources/images/icons/handlers-independent.svg index 36e1c06917..cb782fbfe2 100644 --- a/frontend/resources/images/icons/handlers-independent.svg +++ b/frontend/resources/images/icons/handlers-independent.svg @@ -1,3 +1,3 @@ - + diff --git a/frontend/resources/images/icons/handlers-mirror.svg b/frontend/resources/images/icons/handlers-mirror.svg index 78f71c740e..1e8ac8868c 100644 --- a/frontend/resources/images/icons/handlers-mirror.svg +++ b/frontend/resources/images/icons/handlers-mirror.svg @@ -1,3 +1,3 @@ - + diff --git a/frontend/resources/images/icons/share.svg b/frontend/resources/images/icons/share.svg index 2c0d41de63..0677a583d3 100644 --- a/frontend/resources/images/icons/share.svg +++ b/frontend/resources/images/icons/share.svg @@ -1 +1,3 @@ - \ No newline at end of file + + + diff --git a/frontend/resources/images/icons/snap-nodes.svg b/frontend/resources/images/icons/snap-nodes.svg deleted file mode 100644 index 6ce0a90d67..0000000000 --- a/frontend/resources/images/icons/snap-nodes.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - \ No newline at end of file diff --git a/frontend/resources/images/icons/snap.svg b/frontend/resources/images/icons/snap.svg index 0acdce1f20..b2f88cb835 100644 --- a/frontend/resources/images/icons/snap.svg +++ b/frontend/resources/images/icons/snap.svg @@ -1,3 +1,3 @@ - + diff --git a/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs b/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs index 991532c963..6d05480deb 100644 --- a/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs +++ b/frontend/src/app/main/ui/ds/foundations/assets/icon.cljs @@ -165,6 +165,9 @@ (def ^:icon-id group "group") (def ^:icon-id gutter-horizontal "gutter-horizontal") (def ^:icon-id gutter-vertical "gutter-vertical") +(def ^:icon-id handlers-equal "handlers-equal") +(def ^:icon-id handlers-independent "handlers-independent") +(def ^:icon-id handlers-mirror "handlers-mirror") (def ^:icon-id help "help") (def ^:icon-id hide "hide") (def ^:icon-id history "history") @@ -238,10 +241,11 @@ (def ^:icon-id search "search") (def ^:icon-id separate-nodes "separate-nodes") (def ^:icon-id settings "settings") +(def ^:icon-id share "share") (def ^:icon-id shown "shown") (def ^:icon-id size-horizontal "size-horizontal") (def ^:icon-id size-vertical "size-vertical") -(def ^:icon-id snap-nodes "snap-nodes") +(def ^:icon-id snap "snap") (def ^:icon-id status-alert "status-alert") (def ^:icon-id status-tick "status-tick") (def ^:icon-id status-update "status-update") diff --git a/frontend/src/app/main/ui/icons.cljs b/frontend/src/app/main/ui/icons.cljs index 7dec276e5d..59708eef1a 100644 --- a/frontend/src/app/main/ui/icons.cljs +++ b/frontend/src/app/main/ui/icons.cljs @@ -224,7 +224,6 @@ (def ^:icon size-horizontal (icon-xref :size-horizontal)) (def ^:icon size-vertical (icon-xref :size-vertical)) (def ^:icon snap (icon-xref :snap)) -(def ^:icon snap-nodes (icon-xref :snap-nodes)) (def ^:icon status-alert (icon-xref :status-alert)) (def ^:icon status-tick (icon-xref :status-tick)) (def ^:icon status-update (icon-xref :status-update))