github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-04-25 11:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Avoid unnecesary repainting of frames when mouse hover

Browse Source
This commit is contained in:
Alejandro Alonso 2026-04-22 06:51:33 +02:00
parent f331325941
commit ca97a28408
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
frontend/src/app/main/ui/workspace/viewport_wasm.cljs
View File

@ -157,6 +157,10 @@
text-editor-ref (mf/use-ref nil) text-editor-ref (mf/use-ref nil)
last-vern-ref (mf/use-ref nil) last-vern-ref (mf/use-ref nil)
;; WASM grid overlay was visible last run (`hover-grid?` true). Used so `clear-grid`
;; (expensive: `_hide_grid` + full `request-render`) runs only when hiding the overlay.
prev-hover-grid-shown?-ref (mf/use-ref false)
;; STATE REFS ;; STATE REFS
disable-paste-ref (mf/use-ref false) disable-paste-ref (mf/use-ref false)
in-viewport-ref (mf/use-ref false) in-viewport-ref (mf/use-ref false)
@ -253,9 +257,10 @@
(not page-transition?)) (not page-transition?))
show-text-editor? (and editing-shape (= :text (:type editing-shape)) (not page-transition?)) show-text-editor? (and editing-shape (= :text (:type editing-shape)) (not page-transition?))
hover-grid? (and (some? @hover-top-frame-id) has-grid? (and (some? @hover-top-frame-id)
(ctl/grid-layout? objects @hover-top-frame-id) (ctl/grid-layout? objects @hover-top-frame-id))
(not page-transition?))
hover-grid? (and has-grid? (not page-transition?))
show-grid-editor? (and editing-shape (ctl/grid-layout? editing-shape) (not page-transition?)) show-grid-editor? (and editing-shape (ctl/grid-layout? editing-shape) (not page-transition?))
show-presence? (and page-id (not page-transition?)) show-presence? (and page-id (not page-transition?))
@ -425,11 +430,19 @@
(when (and @canvas-init? @initialized?) (when (and @canvas-init? @initialized?)
(wasm.api/set-canvas-background background))) (wasm.api/set-canvas-background background)))
(mf/with-effect [@canvas-init? hover-grid? @hover-top-frame-id] ;; Grid overlay: `clear-grid` must run only when the overlay was shown and is now off
;; (e.g. leave grid frame, or `page-transition?`). Do not call it on every
;; `hover-top-frame-id` change while not hovering a grid frame.
(mf/with-effect [@canvas-init? hover-grid?]
(when @canvas-init? (when @canvas-init?
(if hover-grid? (when (and (not hover-grid?) (mf/ref-val prev-hover-grid-shown?-ref))
(wasm.api/show-grid @hover-top-frame-id) (wasm.api/clear-grid))
(wasm.api/clear-grid)))) (mf/set-ref-val! prev-hover-grid-shown?-ref hover-grid?)))
(mf/with-effect [@canvas-init? has-grid? hover-grid?
(if (and has-grid? hover-grid?) @hover-top-frame-id ::no-grid-hover-id)]
(when (and @canvas-init? hover-grid?)
(wasm.api/show-grid @hover-top-frame-id)))
(hooks/setup-dom-events zoom disable-paste-ref in-viewport-ref read-only? drawing-tool path-drawing?) (hooks/setup-dom-events zoom disable-paste-ref in-viewport-ref read-only? drawing-tool path-drawing?)
(hooks/setup-viewport-size vport viewport-ref) (hooks/setup-viewport-size vport viewport-ref)