github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-08-01 02:46:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Guard finalize-view-interaction! against spurious pointerup events (#10917)

Browse Source 
Every pointerup unconditionally fires finish-panning and finish-zooming,
which call finalize-view-interaction!. This triggered internal-render
(and reset_canvas) on plain clicks — causing a visible white flash on
large viewports or weak GPUs.

Add a guard so finalize-view-interaction! only runs when a view
interaction (pan/zoom) is actually active.

Fixes #10915

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Alejandro Alonso 2026-07-29 11:43:29 +02:00 committed by GitHub
parent 6063a45c3c
commit c8d1f5b397
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/app/render_wasm/api.cljs
View File

@ -1347,10 +1347,15 @@
(or (:panning local) (:zooming local)))) (or (:panning local) (:zooming local))))
(defn finalize-view-interaction! (defn finalize-view-interaction!
"Ends the view interaction and triggers a full-quality render." "Ends an in-progress pan/zoom view interaction and triggers a full-quality
render. No-ops when no view interaction is active.
`finish-panning` runs on every pointerup, so without this guard we would
call `internal-render` (and WASM `reset_canvas`) on plain clicks."
[] []
(view-interaction-end!) (when @view-interaction-active?
(internal-render 0 0)) (view-interaction-end!)
(internal-render 0 0)))
(def render-finish (def render-finish
(letfn [(do-render [] (letfn [(do-render []