github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-08-27 23:28:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Port the foreign-font-id test to the uploads API

Browse Source 
`create-font-variant-rejects-foreign-font-id` sends `:data`, which
`schema:create-font-variant` no longer accepts: the same commit that
added the test documents that param as removed in 2.18 in favour of
`:uploads`. Both of the test's requests are therefore rejected by params
validation before they reach `check-font-team-ownership!`, which is the
thing the test exists to check. It asserted nothing about ownership and
failed three assertions.

Upload the font through `upload-font-chunked!`, the helper the other
tests in this namespace already use, and pass the session id in
`:uploads`.

`backend-tests.rpc-font-test` is 16 tests, 172 assertions, 0 failures
with this applied.

AI-assisted-by: mixed models
This commit is contained in:
Álvaro Tejero Cantero 2026-08-07 08:02:58 +02:00 committed by Andrey Antukh
parent 5359ff04cf
commit bc9319eac5
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
backend/test/backend_tests/rpc_font_test.clj
View File

@ -623,27 +623,29 @@
(io/read*))] (io/read*))]
;; prof1 creates a font variant in team1 with font-id ;; prof1 creates a font variant in team1 with font-id
(let [params {::th/type :create-font-variant (let [session-id (upload-font-chunked! prof1 data "font/ttf" (* 4 1024 1024))
params {::th/type :create-font-variant
::rpc/profile-id (:id prof1) ::rpc/profile-id (:id prof1)
:team-id team1 :team-id team1
:font-id font-id :font-id font-id
:font-family "SharedFont" :font-family "SharedFont"
:font-weight 400 :font-weight 400
:font-style "normal" :font-style "normal"
:data {"font/ttf" data}} :uploads {"font/ttf" session-id}}
out (th/command! params)] out (th/command! params)]
(t/is (nil? (:error out)))) (t/is (nil? (:error out))))
;; prof2 tries to create a variant using the same font-id but ;; prof2 tries to create a variant using the same font-id but
;; in team2 — must be rejected because font-id belongs to team1 ;; in team2, which must be rejected because font-id belongs to team1
(let [params {::th/type :create-font-variant (let [session-id (upload-font-chunked! prof2 data "font/ttf" (* 4 1024 1024))
params {::th/type :create-font-variant
::rpc/profile-id (:id prof2) ::rpc/profile-id (:id prof2)
:team-id team2 :team-id team2
:font-id font-id :font-id font-id
:font-family "SharedFont" :font-family "SharedFont"
:font-weight 700 :font-weight 700
:font-style "normal" :font-style "normal"
:data {"font/ttf" data}} :uploads {"font/ttf" session-id}}
out (th/command! params)] out (th/command! params)]
(t/is (some? (:error out))) (t/is (some? (:error out)))
(t/is (= :not-found (-> out :error ex-data :type))) (t/is (= :not-found (-> out :error ex-data :type)))