From af10cf71db865c67247e78651c8d40970c5850b2 Mon Sep 17 00:00:00 2001
From: "alonso.torres" <alonso.torres@kaleidos.net>
Date: Mon, 8 Nov 2021 16:15:43 +0100
Subject: [PATCH] :bug: Add placeholder to create shareable link

---
 CHANGES.md                               |  1 +
 frontend/src/app/main/ui/share_link.cljs | 12 ++++++++----
 frontend/translations/en.po              |  2 ++
 frontend/translations/es.po              |  3 +++
 4 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/CHANGES.md b/CHANGES.md
index b41c87e1e1..992e7bef81 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -26,6 +26,7 @@
 - Fix viewer comment position when zoom applied [Taiga #2240](https://tree.taiga.io/project/penpot/issue/2240)
 - Remove change style on hover for options [Taiga #2172](https://tree.taiga.io/project/penpot/issue/2172)
 - Fix problem in viewer with dropdowns when comments active [#1303](https://github.com/penpot/penpot/issues/1303)
+- Add placeholder to create shareable link
 
 ### :arrow_up: Deps updates
 ### :heart: Community contributions by (Thank you!)
diff --git a/frontend/src/app/main/ui/share_link.cljs b/frontend/src/app/main/ui/share_link.cljs
index f8823ddd6d..1bb520416a 100644
--- a/frontend/src/app/main/ui/share_link.cljs
+++ b/frontend/src/app/main/ui/share_link.cljs
@@ -127,10 +127,14 @@
        [:div.share-link-section
         [:label (tr "labels.link")]
         [:div.custom-input.with-icon
-         [:input {:type "text" :value (or @link "") :read-only true}]
-         [:div.help-icon {:title (tr "labels.copy")
-                          :on-click copy-link}
-          i/copy]]
+         [:input {:type "text"
+                  :value (or @link "")
+                  :placeholder (tr "common.share-link.placeholder")
+                  :read-only true}]
+         (when (some? @link)
+           [:div.help-icon {:title (tr "labels.copy")
+                            :on-click copy-link}
+            i/copy])]
 
         [:div.hint (tr "common.share-link.permissions-hint")]]]
 
diff --git a/frontend/translations/en.po b/frontend/translations/en.po
index 696cb3fd3f..5588830e45 100644
--- a/frontend/translations/en.po
+++ b/frontend/translations/en.po
@@ -3232,3 +3232,5 @@ msgstr "X"
 msgid "workspace.options.y"
 msgstr "Y"
 
+msgid "common.share-link.placeholder"
+msgstr "Shareable link will appear here"
diff --git a/frontend/translations/es.po b/frontend/translations/es.po
index 7e63324be7..6db9b999c3 100644
--- a/frontend/translations/es.po
+++ b/frontend/translations/es.po
@@ -3228,3 +3228,6 @@ msgstr "X"
 
 msgid "workspace.options.y"
 msgstr "Y"
+
+msgid "common.share-link.placeholder"
+msgstr "El enlace para compartir aparecerá aquí"